From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by dpdk.org (Postfix) with ESMTP id 34C291C97C for ; Thu, 5 Apr 2018 09:39:01 +0200 (CEST) Received: by mail-wm0-f44.google.com with SMTP id x4so4049822wmh.5 for ; Thu, 05 Apr 2018 00:39:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=HfR3VEKJu4jI1bNQa02cHwu5X3zLYgCUGBPVOEu7wG8=; b=lus7GnMpiAt/wrnp9AOwGmhArVlv49aYCJbFVWCuf21nmATHJoHTSsA4BSllqFVKL1 vxmFlRdcq3SLiQ1s5lO0RQuEQHpjmbmfK5VLfDgbiVlA5ehQTe9b1rHVnw81OTD3x25r TVZ91y2Zj9hpN1DsinflLy2ve1SKmlZ2qCxpha0POeN2/6+4ZDl4hHPc/CDVZI3wWaXW FbAJ9qCWPrXXzaDGZilM73rtUe6Dn81+PD2CuM1JbklzvvvGXzjOjZS0wMR8/7Rkps1k IERBxruk7fa8I4CDzINhm+QsmcBahQEVBCuHIrvliC3akrlBgmaqlwRp4J9weyuv6plk SGEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=HfR3VEKJu4jI1bNQa02cHwu5X3zLYgCUGBPVOEu7wG8=; b=PpUWwCoGZIuyPUSO86FW9yNScHRz9pwoa5rU/9Zu/E0PvFOvyTzLtlFaQCxQLr/h8j LUEWGB61U9NHeo2YJGxV4yot/5Kb/ckgAXNpeNXXo5xSflJ5XwKb8I74ib64ifC3rHr5 0NHLemeBr7gPOYHX8Hge8cLhX4Xt77y5HY57Y0ArPjAs3RuCuENay3bt5ZKmjYT2/YKV OcfswTRK2T6dKkOJ+Xp01n+D15P8CkV5gVE2SmZZMplIYoAysmQaLH0PQymWSE7tDg7X wVDUyEGt4WQuirfp2Y225FEjpzSFhho2VWZ8Ha3/s2thXapIygR1Unl8uimxMw/+eK0q n1Qw== X-Gm-Message-State: ALQs6tB3k7uiQFZmipkpumGC/F2W/qZHuVONprZz/uChL50EVMgmLfRY 0vW6uCGzNzRG1IrVwItWxH7H X-Google-Smtp-Source: AIpwx49enR902Xc59FYFEx2avC2wVAUOR3nwosEVj1l7i8RXwKh9cuhhDkUO33w4t0mQRRXfmeLPXQ== X-Received: by 10.28.12.17 with SMTP id 17mr8882702wmm.75.1522913941631; Thu, 05 Apr 2018 00:39:01 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m35sm8547044wrm.59.2018.04.05.00.39.00 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Apr 2018 00:39:01 -0700 (PDT) Date: Thu, 5 Apr 2018 09:39:07 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org, Wenzhuo Lu , Jingjing Wu Message-ID: <20180405073907.dlpy22n4pyzqzukj@laranjeiro-vm.dev.6wind.com> References: <20180323124725.15806-1-adrien.mazarguil@6wind.com> <20180404144805.11966-1-adrien.mazarguil@6wind.com> <20180404144805.11966-9-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180404144805.11966-9-adrien.mazarguil@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 08/13] app/testpmd: fix RSS flow action configuration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 07:39:02 -0000 On Wed, Apr 04, 2018 at 04:57:59PM +0200, Adrien Mazarguil wrote: > Except for a list of queues, RSS configuration (hash key and fields) cannot > be specified from the flow command line and testpmd does not provide safe > defaults either. > > In order to validate their implementation with testpmd, PMDs had to > interpret its NULL RSS configuration parameters somehow, however this has > never been valid to begin with. > > This patch makes testpmd always provide default values. > > Fixes: 05d34c6e9d2c ("app/testpmd: add queue actions to flow command") > Cc: stable@dpdk.org > > Signed-off-by: Adrien Mazarguil > Cc: Wenzhuo Lu > Cc: Jingjing Wu Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND