From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id 512F41C9C5 for ; Thu, 5 Apr 2018 10:17:44 +0200 (CEST) Received: by mail-wr0-f196.google.com with SMTP id y55so26904522wry.3 for ; Thu, 05 Apr 2018 01:17:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=7io3+rAZrbPnFhWAYuJt2whwQEMm/XMGkmKs3olCLcc=; b=p9YHk/54DHe13geP6xqnL86V7XzShhipc02x9j/Cr/gV1/nFgGjLLBBIcRBd+QQS5K bpi7pzSluwLgMBCR/IxUfUTFQykHABzgrrAobhAZn9y8W3J3F2vU6Q3ZqhLqXO/WDSVI h86iYHmK12tQYTGOruW/P6eLuMXp8J1Hsvo2bw7Vp4HptpSH5lY49jLe+Ou4SZJV+c3E +XtCAZGqvvEvumRJBsFH95WOazMORaUOOhUDyvMVSaEqQ5HvVQZY39E7dOMuyqH/XiTJ jOidXz1rcRaCw2uH3vPjCt1Wvb0MAngd53sYsXNXoHJJcBhcMpdUTKbfjkZlaiJFNHAr LPmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=7io3+rAZrbPnFhWAYuJt2whwQEMm/XMGkmKs3olCLcc=; b=Q6ZMQait7DkSmTGLtKdSZdVLo+NjDRnd2QKOW/cYQ585N/8diZVT6mKxe0dVu775qn LdzS/Dtg24yFyY3cEXtC4KWWofypFUYP89+tf7nnBA5jLymIdDJWvyutWSZzOJNPlOk1 0QDaE770pJ0NsHLoejrPBRL43kHNyfhZqyPrw2yhtFLXquEYyDaSxyzIo49cRX+3HF76 8kPlZNzkE3lBnF1bLjxeZidFFR05CkOjr8YTU7aFO0o3K4gcYE7Q+OMGC8svrXk2SRGz UcVJajjR/JXOMJuVuBN2ETcT/53XQwATGqjVJK5KufpP5NA7W/1AiUNw/dLLbHl5KthH etYw== X-Gm-Message-State: AElRT7HrUJ04j5bLgnHOe5CO5gjE76RoOQV0aGbcG6EjBWQPiILvAmxK BlM0sQt4o+X1A/r9t9DzImew X-Google-Smtp-Source: AIpwx4+IdcXMaUvqreo5fDKndyfJzKu6uzbkMK6HmPXAWDLDSsNqrb2z444ZBdPJcePXF1PSkYRhGQ== X-Received: by 10.223.164.142 with SMTP id g14mr14851181wrb.18.1522916264078; Thu, 05 Apr 2018 01:17:44 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f84sm8795490wmh.44.2018.04.05.01.17.43 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 05 Apr 2018 01:17:43 -0700 (PDT) Date: Thu, 5 Apr 2018 10:17:50 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20180405081749.rk4nz73xkfzzn7sv@laranjeiro-vm.dev.6wind.com> References: <20180323124725.15806-1-adrien.mazarguil@6wind.com> <20180404144805.11966-1-adrien.mazarguil@6wind.com> <20180404144805.11966-12-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180404144805.11966-12-adrien.mazarguil@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v2 11/13] ethdev: fix missing boolean values in flow command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 08:17:44 -0000 On Wed, Apr 04, 2018 at 04:58:05PM +0200, Adrien Mazarguil wrote: > Original implementation lacks the on/off toggle. > > This patch shows up as a fix because it has been a popular request ever > since the first DPDK release with the original implementation but was never > addressed. > > Fixes: abc3d81aca1b ("app/testpmd: add item raw to flow command") > Cc: stable@dpdk.org > > Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro > --- > app/test-pmd/cmdline_flow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c > index dbf4afebf..30450f1a4 100644 > --- a/app/test-pmd/cmdline_flow.c > +++ b/app/test-pmd/cmdline_flow.c > @@ -2695,6 +2695,7 @@ static const char *const boolean_name[] = { > "false", "true", > "no", "yes", > "N", "Y", > + "off", "on", > NULL, > }; > > -- > 2.11.0 -- Nélio Laranjeiro 6WIND