From: Adrien Mazarguil <adrien.mazarguil@6wind.com>
To: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc: dev@dpdk.org, Timothy Redaelli <tredaelli@redhat.com>
Subject: Re: [dpdk-dev] Question on documentation / Mellanox ConnectX-3
Date: Thu, 5 Apr 2018 11:26:21 +0200 [thread overview]
Message-ID: <20180405092621.GI4957@6wind.com> (raw)
In-Reply-To: <20180403175938.GA23889@localhost.localdomain>
On Tue, Apr 03, 2018 at 02:59:38PM -0300, Marcelo Ricardo Leitner wrote:
> Hi,
>
> http://docs.openvswitch.org/en/latest/howto/dpdk/ says:
>
> Some NICs (i.e. Mellanox ConnectX-3) have only one PCI address
> associated with multiple ports. Using a PCI device like above won’t
> work. Instead, below usage is suggested:
>
> $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \
> options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:01"
> $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \
> options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:02"
>
> But these MACs are 7 bytes long. Seems the idea was to mention the two
> incremental MAC addresses that the ports have, and thus the ':55'
> should have been removed from there, right?
>
> Reading the code, it doesn't seem prepared to handle the extra byte in
> any (special) way.
After a quick glance at the original patch [1], I confirm it looks like a
mistake in the OVS documentation. MAC addresses should be 6 bytes long, the
7th byte is not a workaround to identify a physical port like I initially
thought.
As you pointed out, since default MAC addresses on mlx4 ports are normally
incremental, documentation should read something like:
$ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \
options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55"
$ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \
options:dpdk-devargs="class=eth,mac=00:11:22:33:44:56"
[1] https://github.com/openvswitch/ovs/commit/5e7588186839
--
Adrien Mazarguil
6WIND
next prev parent reply other threads:[~2018-04-05 9:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-03 17:59 Marcelo Ricardo Leitner
2018-04-05 9:26 ` Adrien Mazarguil [this message]
2018-04-08 21:27 ` Marcelo Ricardo Leitner
2018-04-09 15:07 ` Adrien Mazarguil
2018-04-09 17:08 ` Marcelo Ricardo Leitner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180405092621.GI4957@6wind.com \
--to=adrien.mazarguil@6wind.com \
--cc=dev@dpdk.org \
--cc=marcelo.leitner@gmail.com \
--cc=tredaelli@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).