From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by dpdk.org (Postfix) with ESMTP id E19901CA18 for ; Thu, 5 Apr 2018 11:26:35 +0200 (CEST) Received: by mail-wm0-f43.google.com with SMTP id x82so5040977wmg.1 for ; Thu, 05 Apr 2018 02:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=czQdRpIqbiNMsplpQ20YLwwsObf+jJBEaKSQIQEJsjU=; b=rnDJr2ZfsD9thsraWBK5/QUoy7RwqiB7ZGIDU73vOsVWSlMmrK6IUynF8gX2mFbO7i 8dHIM4FXOa31HvL9K48aV7vmMkdc8M6oMIG/UL/MRfQH3OFvkgXk5NJy4bS2mhQM/Bu4 we0dTkG9EBKnpRrHsqwg28KaXfY9g9KuIwObpC63k+BZCqbzOA31hvUsJCDaicLRu6Ax Cy6sgAUIdjxdnW1gEwXISIgffp5PP96GlLcAjYHi3w6Od5m5XAoyXuW5jyfwSxjjUJJL 2ABhICfJWWU3HHY1PCDyFaMEUfX1bm273KIa63Gp0OrHImBzNEu+bK/AohAZtqKUXF7V rMEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=czQdRpIqbiNMsplpQ20YLwwsObf+jJBEaKSQIQEJsjU=; b=YUROC5jw7EbLG/nA2moD608PlICwkTlSSM4LOucx1u7u0NM6MQk9ZlSa/NYWq5UtVn sLg0+reBBcocW4aLKQRakN8RyKtYJ9Z67XHfi4kqwIQYFduQzPkHn45AZ+VBnvzoOHro JqkCukNDytosXk03suK+hbCzRH0VLrcX+9Rg9LGdSaJFQTs1OELdQqzlaHpHPcEqcSGr 3gG8pVwdU/cNhkmW5GhLz17xdgUMYuEoYjx7sEvus4BOIC8XY167V7dSsc4lWJO+xTE4 zBKiL2hNXnlTkaUP5Bc3oeIxZcoGmIUeoc15k1SBNH0sTLWbuPqj4o/6LR7zNgcn3GFK AfPw== X-Gm-Message-State: ALQs6tC7bBnx+iRpKP4OUCp+BECSZdxU7Rf3p9q1IGKPTGfuKe2s1Cuo oI+r6GE04AbMFVMaVLytsvoN1A== X-Google-Smtp-Source: AIpwx48fLgwNoGUUi69xNDcPlX4mioVo8TyXBzEORq2TlUpoH8HQXDU5+DjHl2TTMq4CFCCzOEhkTw== X-Received: by 10.28.99.84 with SMTP id x81mr4357563wmb.8.1522920395660; Thu, 05 Apr 2018 02:26:35 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r75sm3275098wmf.34.2018.04.05.02.26.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Apr 2018 02:26:34 -0700 (PDT) Date: Thu, 5 Apr 2018 11:26:21 +0200 From: Adrien Mazarguil To: Marcelo Ricardo Leitner Cc: dev@dpdk.org, Timothy Redaelli Message-ID: <20180405092621.GI4957@6wind.com> References: <20180403175938.GA23889@localhost.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180403175938.GA23889@localhost.localdomain> Subject: Re: [dpdk-dev] Question on documentation / Mellanox ConnectX-3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 09:26:36 -0000 On Tue, Apr 03, 2018 at 02:59:38PM -0300, Marcelo Ricardo Leitner wrote: > Hi, > > http://docs.openvswitch.org/en/latest/howto/dpdk/ says: > > Some NICs (i.e. Mellanox ConnectX-3) have only one PCI address > associated with multiple ports. Using a PCI device like above won’t > work. Instead, below usage is suggested: > > $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:01" > $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:02" > > But these MACs are 7 bytes long. Seems the idea was to mention the two > incremental MAC addresses that the ports have, and thus the ':55' > should have been removed from there, right? > > Reading the code, it doesn't seem prepared to handle the extra byte in > any (special) way. After a quick glance at the original patch [1], I confirm it looks like a mistake in the OVS documentation. MAC addresses should be 6 bytes long, the 7th byte is not a workaround to identify a physical port like I initially thought. As you pointed out, since default MAC addresses on mlx4 ports are normally incremental, documentation should read something like: $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55" $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ options:dpdk-devargs="class=eth,mac=00:11:22:33:44:56" [1] https://github.com/openvswitch/ovs/commit/5e7588186839 -- Adrien Mazarguil 6WIND