From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0E2771CAC8 for ; Thu, 5 Apr 2018 12:29:22 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 05 Apr 2018 03:29:21 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,410,1517904000"; d="scan'208";a="45121570" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga001.jf.intel.com with SMTP; 05 Apr 2018 03:29:18 -0700 Received: by (sSMTP sendmail emulation); Thu, 05 Apr 2018 11:29:15 +0100 Date: Thu, 5 Apr 2018 11:29:14 +0100 From: Bruce Richardson To: Tomasz Duszynski Cc: dev@dpdk.org, maxime.coquelin@redhat.com, jianfeng.tan@intel.com, zhihong.wang@intel.com Message-ID: <20180405102914.GA63268@bricha3-MOBL.ger.corp.intel.com> References: <1522915696-26727-1-git-send-email-tdu@semihalf.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1522915696-26727-1-git-send-email-tdu@semihalf.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] vhost: fix meson build issues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 10:29:24 -0000 On Thu, Apr 05, 2018 at 10:08:16AM +0200, Tomasz Duszynski wrote: > This patch addresses following meson build issues: > > 1) Since rte_vdpa.h includes rte_pci.h it introduces pci > dependency thus deps array should be updated accordingly. > > 2) Since vhost.h includes rte_vdpa.h vdpa.c should be added to > the sources list. Otherwise we end up with linker errors > caused by undefined references. > > Fixes: 34b30b2e7e42 ("vhost: add apis for datapath configuration") > Cc: zhihong.wang@intel.com > > Signed-off-by: Tomasz Duszynski > --- Confirmed that meson build on dpdk-next-virtio tree is broken and that this fixes it. Acked-by: Bruce Richardson