From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id E7D4E1CBE0 for ; Thu, 5 Apr 2018 16:19:50 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 897DF722C9; Thu, 5 Apr 2018 14:19:50 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3C20EAB3F5; Thu, 5 Apr 2018 14:19:44 +0000 (UTC) Date: Thu, 5 Apr 2018 16:19:43 +0200 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, yliu@fridaylinux.org, mst@redhat.com Message-ID: <20180405141943.eg26uur3cypupdgf@reserved-198-163.str.redhat.com> References: <20180405101031.26468-1-jfreimann@redhat.com> <20180405101031.26468-2-jfreimann@redhat.com> <2ddbca32-e7b6-e2a4-5785-ea283f34086b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <2ddbca32-e7b6-e2a4-5785-ea283f34086b@redhat.com> User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.79 on 10.11.54.5 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 05 Apr 2018 14:19:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.2]); Thu, 05 Apr 2018 14:19:50 +0000 (UTC) for IP:'10.11.54.5' DOMAIN:'int-mx05.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3 01/21] net/virtio: by default disable packed virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 05 Apr 2018 14:19:51 -0000 On Thu, Apr 05, 2018 at 03:42:47PM +0200, Maxime Coquelin wrote: > > >On 04/05/2018 12:10 PM, Jens Freimann wrote: >>Disable packed virtqueues for now and make it dependend on a build-time >>config option. This can be reverted once we have missing features like >>indirect descriptors implemented. >> >>Signed-off-by: Jens Freimann >>--- >> config/common_base | 1 + >> drivers/net/virtio/virtio_ethdev.c | 4 ++++ >> 2 files changed, 5 insertions(+) >> >>diff --git a/config/common_base b/config/common_base >>index c09c7cf88..cd4b419b4 100644 >>--- a/config/common_base >>+++ b/config/common_base >>@@ -346,6 +346,7 @@ CONFIG_RTE_LIBRTE_VIRTIO_PMD=y >> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_RX=n >> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_TX=n >> CONFIG_RTE_LIBRTE_VIRTIO_DEBUG_DUMP=n >>+CONFIG_RTE_LIBRTE_VIRTIO_PQ=n >> # >> # Compile virtio device emulation inside virtio PMD driver >>diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >>index 11f758929..06fbf7311 100644 >>--- a/drivers/net/virtio/virtio_ethdev.c >>+++ b/drivers/net/virtio/virtio_ethdev.c >>@@ -1149,6 +1149,10 @@ virtio_negotiate_features(struct virtio_hw *hw, uint64_t req_features) >> req_features &= ~(1ULL << VIRTIO_NET_F_MTU); >> } >>+#ifndef RTE_LIBRTE_VIRTIO_PQ >>+ req_features &= ~(1ull << VIRTIO_F_RING_PACKED); >Is VIRTIO_F_RING_PACKED already declared here? >I don't think it is, so would break build when bisecting. yes, you are right it is not. I pushed this patch to far up during git rebase. > >Maybe the thing to do is to not have VIRTIO_F_RING_PACKED in the >feature set by default. And when RTE_LIBRTE_VIRTIO_PQ is set, enable >it and >explicitly disable indirect descs. Yes, both would work. I'll go with your suggestion. Thanks! regards, Jens > >>+#endif >>+ >> /* >> * Negotiate features: Subset of device feature bits are written back >> * guest feature bits. >>