From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by dpdk.org (Postfix) with ESMTP id D5AF71CE8C for ; Fri, 6 Apr 2018 10:12:55 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 767B8406EDAA; Fri, 6 Apr 2018 08:12:55 +0000 (UTC) Received: from localhost (dhcp-192-241.str.redhat.com [10.33.192.241]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 180122024CA4; Fri, 6 Apr 2018 08:12:54 +0000 (UTC) Date: Fri, 6 Apr 2018 10:12:54 +0200 From: Jens Freimann To: Maxime Coquelin Cc: dev@dpdk.org, tiwei.bie@intel.com, yliu@fridaylinux.org, mst@redhat.com Message-ID: <20180406081254.qlp66jngr2kbvsig@reserved-198-163.str.redhat.com> References: <20180405101031.26468-1-jfreimann@redhat.com> <20180405101031.26468-9-jfreimann@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 06 Apr 2018 08:12:55 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.7]); Fri, 06 Apr 2018 08:12:55 +0000 (UTC) for IP:'10.11.54.4' DOMAIN:'int-mx04.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'jfreimann@redhat.com' RCPT:'' Subject: Re: [dpdk-dev] [PATCH v3 08/21] net/virtio: implement receive path for packed queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 08:12:56 -0000 On Fri, Apr 06, 2018 at 09:51:32AM +0200, Maxime Coquelin wrote: >Hi Jens, > >On 04/05/2018 12:10 PM, Jens Freimann wrote: >>From: Yuanhan Liu >> >>Implement the receive part here. No support for mergeable buffers yet. >> >>Signed-off-by: Jens Freimann >>Signed-off-by: Yuanhan Liu >>--- >> drivers/net/virtio/virtio_ethdev.c | 10 ++- >> drivers/net/virtio/virtio_ethdev.h | 2 + >> drivers/net/virtio/virtio_rxtx.c | 137 ++++++++++++++++++++++++++++++++++++- >> 3 files changed, 146 insertions(+), 3 deletions(-) >> >>diff --git a/drivers/net/virtio/virtio_ethdev.c b/drivers/net/virtio/virtio_ethdev.c >>index 089a161ac..dc220c743 100644 >>--- a/drivers/net/virtio/virtio_ethdev.c >>+++ b/drivers/net/virtio/virtio_ethdev.c >>@@ -1315,10 +1315,15 @@ set_rxtx_funcs(struct rte_eth_dev *eth_dev) >> { >> struct virtio_hw *hw = eth_dev->data->dev_private; >>- if (hw->use_simple_rx) { >>+ /* workarount for packed vqs which don't support mrg_rxbuf at this point */ > >I don't think you need such workarounds, just advertise the packed ring >layout feature once full support is introduced. > >Also I'm not cleat what the workaround is needed here, as you set to >virtio_recv_pkts_packed whatever mrg is on or not. yes, I'll change it in v4 to advertise packed virtqueues as the last patch. Thanks! regards, Jens > >