From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id C44B81D05C for ; Fri, 6 Apr 2018 15:22:48 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id 80so1766090wrb.2 for ; Fri, 06 Apr 2018 06:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=0PkH/umcJVjXp/kzzU4kuZCr/2QpIl5tB1o/gkg98wI=; b=PpnoaQBSsb+/XK/o8j9KiYyXGpQLkCDxpe47q3THCpuTZ/zYPHFXLshmMzPN8nwcxR dplTJnrsLA2PyFBYRXKUL+O4iWp56WkCOkkKiL1CdRfv2XbzxOgJ/mUnD6DzzSRqOBjO C7oxwmJgK1/XLqx/N5POJ7bwbuOdHrhEdAAE+G2j+CypuqalHES2g8aPcpNxrSamgh8s X4BDHzze8tNI/vZNRfJNb7H0ctu2onA665HD0nyZH2a2wLa2UiNPSxVMuDwE21djtANC njj5g/M8CWTiDlV9aRqDNS26rzHLlmVJ4SmQvRvXLLaG6OvFWm1BgeDAYEnWBI54k2hj jRdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=0PkH/umcJVjXp/kzzU4kuZCr/2QpIl5tB1o/gkg98wI=; b=MJtYY/Molaf693smClhaIq6eoPXDTvi/n0+I5XedD366ccVrv1k8MmIawOfBDmh7an YOVtC01geLrltuCsK9jIvI173OwXzWztvOWcJqjNRYA9jc5ExMG/JRD+EY9Ht33a5zVT hDzSE8QrtC8g3VtTaN+LaTJwLpmsovoU5T2zNphO0putQHCQOWvdC6vCuF7s2RQivPSV qlZ7jQYDi41ggnQ20vW8Ccyy1rmJDrxX7vxzsa7wW/wNC0wTdYEJqIiqWwRVKdysfT96 a1V/rwEIUAyj7rQgesdyQEq+ZqsyM9wr2WfBqYN5c6Wej3A20aR/vjLCW63J2mh9GT2m uhfQ== X-Gm-Message-State: AElRT7HsLonB/9ifcpRRTVmGtnzS+otPVJm90PesCpzhw8yxkapcXG4R 6lUe1zgQs92StQ+TI7igWXSPt8TA X-Google-Smtp-Source: AIpwx48D1EniRBpydO9mTp+jbIvhnoHgQAwd96H7tHuNptA7UFASippnJkII5owCc9m3AoWEYpCmQg== X-Received: by 10.223.163.195 with SMTP id m3mr20362150wrb.91.1523020968276; Fri, 06 Apr 2018 06:22:48 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id d48sm16559197wrd.12.2018.04.06.06.22.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 06 Apr 2018 06:22:47 -0700 (PDT) Date: Fri, 6 Apr 2018 15:22:34 +0200 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Shahaf Shuler Message-ID: <20180406131243.19037-2-adrien.mazarguil@6wind.com> References: <20180404144805.11966-1-adrien.mazarguil@6wind.com> <20180406131243.19037-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180406131243.19037-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v3 01/11] net/mlx4: fix RSS resource leak in case of error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 13:22:49 -0000 When memory cannot be allocated for a flow rule, its RSS context reference is not dropped. Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil Cc: Shahaf Shuler --- drivers/net/mlx4/mlx4_flow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index 2d55bfe03..a3b4480b4 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -820,11 +820,14 @@ mlx4_flow_prepare(struct priv *priv, }, }; - if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) + if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) { + if (temp.rss) + mlx4_rss_put(temp.rss); return rte_flow_error_set (error, -rte_errno, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "flow rule handle allocation failure"); + } /* Most fields will be updated by second pass. */ *flow = (struct rte_flow){ .ibv_attr = temp.ibv_attr, -- 2.11.0