From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-BL2-obe.outbound.protection.outlook.com (mail-bl2nam02on0083.outbound.protection.outlook.com [104.47.38.83]) by dpdk.org (Postfix) with ESMTP id 496D41CCFC for ; Fri, 6 Apr 2018 20:25:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=f78z+w2hQNPXsbJSjng3C8w6FNijiWH965jQAOQJeOU=; b=ka/jAC0CFxXBeabl1HnUYS4kMYUTklqoj32FaUoMSx45Q0KqwhKOJrymNgLOvjeqBukjFiTHaoo8BhWNRZ+gaZ/xcCmv7DMnwNjRRzr/+my3GA068R2LpB++jzjdul/aX5Ss3tkW82yocs/3xC9sPMY1nnRsFSbnK7Mzlh40e4U= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by BN6PR07MB3459.namprd07.prod.outlook.com (2603:10b6:405:64::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Fri, 6 Apr 2018 18:25:38 +0000 Date: Fri, 6 Apr 2018 23:55:18 +0530 From: Pavan Nikhilesh To: Thomas Monjalon , jerin.jacob@caviumnetworks.com, ferruh.yigit@intel.com, stephen@networkplumber.org, konstantin.ananyev@intel.com Cc: dev@dpdk.org Message-ID: <20180406182516.GA13313@ltp-pvn> References: <20180406110103.29163-1-pbhagavatula@caviumnetworks.com> <1655998.KI4tD34sB9@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1655998.KI4tD34sB9@xps> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: SG2PR04CA0174.apcprd04.prod.outlook.com (2603:1096:4::36) To BN6PR07MB3459.namprd07.prod.outlook.com (2603:10b6:405:64::22) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: de4b896e-a24f-4114-e7bb-08d59bebcd7d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BN6PR07MB3459; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 3:kzNR3c2Rh9qJZybJRHX1SyY/iO2MAMmAnbsOhQir2vuMdHlOwBBC7LieI9MZbMrs6mkos2d/I5+wAE9BGIJfnGN8IPe61ZPUqL27OIL861RdJx/kEfn7b5ROLL5U9feZyTZJ8FxttbVAyHNp0mDc6+RsAA8c1Mny1cLlVcdY+Llxr3uzBrUbAmN4gnbL6CgT51Nhv0ek6qfpGKWKWMyRN4Gy2G54GbfX1YJDsByKhGYn+6iCu8A36QyHr8NJyMqP; 25:RnQDj0B5nnB+d4I7qZTPfxGYsvWspwXuWC8FvtFMvz60oQwi+aT5QFw3ZfY3v1XyyM04CFOSVEJj8NeriRVjN1f8koTNCasfFBzYbPfPFNSY6bAfuRZbIgi+SaHKPEVLRoxyqOJEGOwUX6fNGg9ApC7+eeKvBnvtOsU6Tf/pHY0ccWNKXBWkuaGKd6RqI5bSjaQcs5PKa+Gy0zv10UY84GphFjPzOhiFTAmyD/oOU7kFfO8PqA1vC16/dvZvWDFTiQ+XAAmAjaluZq/IX2Rqyl+MgraBbJ4FCCSIYx520Yo+pYYYBokQtGK+0UWGstc/HK2+/XEn8PghW+xhqBodVg==; 31:J2Npsb2idt9VNUoXIfZrPBm6Eo05fCcP2cRbrH8oqDWpHJoaochnmntOiIn28YD5N75ObM3GzL+d95SSBbAVTt5LK3cacigBythEzL8/LirHkg7DBAKCaw9TUmMKCIe4uT/dJpT3+7czHjplT8vdeMVfWLEgWGe6iGrun63ESYwnzxPZXFs8l5+eyO00TZmdW3ISkdoAgb8jvVevQRfdeGwLxMTQhmkNiahgz53NjQ4= X-MS-TrafficTypeDiagnostic: BN6PR07MB3459: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 20:Cz/r8bu6NJXXfTJlKzCoQzDsRrSmJAVR3QOYLqhqhMzrTe4cdSjktSX91wxiKFm+kqvTHZyg5kbdgvm8mPwU/efDUGbZ1wUFqnXmRQkncHAYPv5p2Tk6zhq1F8O986GhF/1kgBpn3aJv6zcXZJ8IWxSFvJ3nxTWs6u1UQ4fXnSCzYXqIMPvfYX3cH8wQFgkJbdBoEK7czSH/DByN8OwHX7d1Ea4D56IgbbKGHBhoPxMOqkZ9gkg7MXY1Eb0oFsmhcIskjhbY1mRDUHm0v/XObo2+6XTQ5M5sArpErfJcQ3Cfzl3fKXPhFHTIkLVmrRagG6fB6l9w94HwL8b7AAoPDGPMakwtJHrI8QmjS6WUULKycMdtU6wE3L/E7Wckk90sNs2sMgrPt46b5VwgPGEF2S8/AAJQaMyJIZCENoJHF/9EJ2b3aHY5G8gf89DadWA9s5f4f6nE/UrkT+12hoVVpefteyx3D29xaEtKynbKaPKbaeA+scDCOKhXYdVaLrQfWNFKn3hR0bmGffLR6dzAbgpfjXXw1P+NTtTvpOh2XU3GyVSgnJV07TYjVTfqtJfqQqZJxnaD8s7A5q+piNUiNCjcksjbsjwfSom05ZPi85Y=; 4:WRGk0VmkA2g/sfsS+GR5k3PM0LgIP2E6Nw6n2eMVET++4CzMs5Wb/okKSqldmV0yjSTnNoQGdhkvWAR0nKx9YJ8wfIikxyGHJm2Mj2QOZBbvsjKxESQ9O8rXoRK21hGtIlPSWMC+4EwOhDGxlfqVv3ORfU1nbVril61Vhz98/81AbC1qZBMYsiSPoQuPBxdj/lOClUPxOMwzIghki4GR0an67gGZtr9wY8y02p68oqm0vmKdE18LxMD3lAUFAjzhEgzLPO6lNJoydH37tKg21/HHYIrYgpBW3/IzUVM4OEY7GgqjakYviBF+5KY0otK8 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(262104967686372); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(10201501046)(93006095)(3231221)(944501327)(52105095)(3002001)(6041310)(20161123560045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(20161123562045)(20161123558120)(6072148)(201708071742011); SRVR:BN6PR07MB3459; BCL:0; PCL:0; RULEID:; SRVR:BN6PR07MB3459; X-Forefront-PRVS: 0634F37BFF X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39860400002)(396003)(366004)(346002)(39380400002)(376002)(199004)(189003)(8936002)(2906002)(305945005)(7736002)(55016002)(186003)(6246003)(16526019)(50466002)(25786009)(229853002)(316002)(81156014)(81166006)(16586007)(9686003)(6306002)(4326008)(68736007)(33716001)(42882007)(53936002)(97736004)(58126008)(8676002)(956004)(476003)(11346002)(446003)(105586002)(23726003)(47776003)(486006)(1076002)(3846002)(966005)(6666003)(106356001)(33656002)(386003)(72206003)(5660300001)(478600001)(26005)(52116002)(6116002)(66066001)(5009440100003)(6496006)(76176011)(33896004)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3459; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3459; 23:IqOUYB70NqsF9vmnyBDd6ZZeJN8+f3isA1nzwN3K1?= =?us-ascii?Q?OIhoBpIhxWfJOteo7d7SuckRKJ6XX6F+Tzbea/CZL6zYlN2KdzLsaqXlbJ/O?= =?us-ascii?Q?Lly0qQJcly0YWoYZa8VH7Sec41lwg4o6ktbT/BNM1wxbi4yE+xpPqoJ63pE5?= =?us-ascii?Q?zzG2Sy1L1LW7PhWieSLX9TZAWHnPIbCRI08JOIJmtFL/a6wZHh7YIK6WHIjV?= =?us-ascii?Q?Dr1ynH8kEs8LowLcQ5NmDLHRiuDxI/2YnJ51j0L7sW4ClCKC/aIVqVnkVZyW?= =?us-ascii?Q?prsvJSoQAZW5bE6f2DJxIqBGliD+5umvFn1MXVotkInpFSaylvrakowq/UOZ?= =?us-ascii?Q?O7cq7Muok02XG+sNuyn50+b+suLPJZZ+630soFjTWiU6lOtT09vYSnYrxuEu?= =?us-ascii?Q?Ivlf2exm2hwgOQuIi9WrZBXO4mzYfpzAROfF70L2ThDQDk+sGETJ5VZ5/gLT?= =?us-ascii?Q?aOhECvYjm+UE6F+Izay+/LVkH6myKfS9F1aP1RaUbKJ9RhGAVXBAamQ2jXor?= =?us-ascii?Q?XOwR/eh9hvlsSFGR11eF82V/Vt4qX3thXcMLWFY9svL+Ps0DjKiPrl3gqaxX?= =?us-ascii?Q?M8CefAhMSRg3j41UNSdNGsKCL19GdDNkFALznFB/1BXPVCW0sCXKVdmXk1n7?= =?us-ascii?Q?GjbGh73LE73iFs0hihFLKSTo9iRO8IdRBa9lsBXzTSzTGALha/FE1kJVkFWj?= =?us-ascii?Q?o01Haah64Ah61BI5eKOMmzpvyIqojCFtpBnIHE5ryuYI0nbAjl5V3cdkqfTC?= =?us-ascii?Q?rua1D8xbO+gSojuVNGy7p0ELcyy6dJHLrt5pngqriETgKqMOYqmhDjUIpsWP?= =?us-ascii?Q?zRy9eoQNBk3q2yt1KztkOqHmMN2U4vf8kGNX0q5dQWvM5u5p63UCgSODh/sB?= =?us-ascii?Q?0DJwQh1vAjcuel53KlImvsas8QdxhguViQ5h3ej2KBjn8A5kXGnkuiJxzARp?= =?us-ascii?Q?g1Y6gQ8MXzqwS4OOXscagEDMR3Jp5EaKtoUXaaTDgV29WG/Dr+aY1bTIPW7u?= =?us-ascii?Q?mfVw+k3izeMCf5yMqyDjkU9ebUujMzdiSeC0wBJ2KdGq4yvaK3MBeTsjwmfr?= =?us-ascii?Q?tZwoZIF+oJ3LuaVUQl4Yx5ACOp0O1d6iyd7i83jGELotqHvuseKcC8z6BptN?= =?us-ascii?Q?xMb2srPo1UFijVCG0nOVbSGGu5iEEEUgeMoFNEA/eirzh5F1DBRdZD+BKPST?= =?us-ascii?Q?cYdLF7dSJQV/fvqz3jQH2GVeLSdaITFO7fN/Qw/Qvf7EgpUfeonl9pxJCrNn?= =?us-ascii?Q?J2ZWqJbdknUsBcBhV+gohZnXImO0dUdA74PgcHYzx/SWrBQjmAWBSENyuCFG?= =?us-ascii?Q?u61ya1pmoISIajETLW1Hp4iupvUETPwHCqhXmYSPL2yw3K5T0wp8tTu4XoV7?= =?us-ascii?Q?WfY8pNgWWPFJ9GXWJWqtGiSfJQ=3D?= X-Microsoft-Antispam-Message-Info: vwtVZjwK8oMt04QcXEukohvYb/wDnxu8i9ENRt0lWCvKbLraiq5dWw7jSo1OJ5gN8dolvyVF1S5DCrZPvFO2WnWxEK2ZMQEt9DCyMpmqXhxxHV4HMdQAUeaATz598Tr8lsMy1MjxX4b+1X5ayFLykIR4H7yzMQ/8mdGs2f57RQ4GNKQSCFKo28t+AZFec/1q X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 6:ff3EkVYeVlC/VeHE9kr1/bEzMrGMoV7BMpsbd+tsMYnM2waxXOglcid2Lh2u6v3JajU0Lc/2DXNkL9tqUl+0XCPOCwyZ3Z5ZeVWZzYPEbTcRnqC7DnA19TdWP19hWMffLcFSh5TVAgqEfhPNvdZzdRKMPJ3CY3CIMOuluBIAP4/mRvaYJT7JR1n3J3MExDhE7cvMMxUZfDQ14KTgz3BwEqatKVAa0DMLpiZzPtPu1+iLcJwbksgO26Fi0DHeRCAhlfHI/E0rYRaC6947E4rHKx2sw0ISG2QGIibD4SGIIdYBEePZEbKU523xHnj7n7BXIRn/dJfvDUFpTqJhfVNEUqkvKCJNcfe0Fl1Gz0unW8xSHuRSiEXanTjjh504eFSX03Ou89YwNQbrRvkx16fvrCvK8GDFAbSVww7c0q90v00rL9s2yxG5KhDFHp2Ziv9929CF7bj07/Oxl3hjekK4bg==; 5:0DOVKEX2h0RTtyUd57uIrVhQdUfouXx4Qkf09V9KJv+0rV3pMMzC1Uc7mxFwrrhMrw8qLsl7tMF/TTudewGk+rwQfVJ2xm3LG/nJjen1Rfb7qzLwelVZRBKhp3pU3v+AAgsuepfxwi4h9P2z95gQp95bSTf2RxzfGkMoSdyrA6Y=; 24:gsEQZ+ji8ZmIQVP0HJFmQsWzNEwkwqtYcqNjHJjSOY5d3PLcgIGINg1uAVVXwWKYw7ZzzJiAyjzXpRL9FBcji4QsXPDLsGXyVPIF+BrfAHM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3459; 7:B2+ApQulRT9mrWIeCmdXOSPN9ZD6pus4qocFl0Rk2htrUObhk2nuAr7+FZmU95yUEuM5Vbie1NmSpV3HKs2Fs/+3NH5r2HSU1uBydA5pv3NKMDMbqEhvRk5QkFXx60fHE1/r8ipPGNFFMSVWlmEiNKdk5Tvtjrkn6tBNkZp6LWzfDxwIhD7bRbpNMYmrSUc74OLEVLPiQZs3bdCdrZ3tU9YO6bZiRt4NcljNeF3xtv8Gfapn9MZm7AlEAgB0Mg7x X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2018 18:25:38.3274 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: de4b896e-a24f-4114-e7bb-08d59bebcd7d X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3459 Subject: Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Apr 2018 18:25:44 -0000 On Fri, Apr 06, 2018 at 06:24:34PM +0200, Thomas Monjalon wrote: > 06/04/2018 13:01, Pavan Nikhilesh: > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > Please, could you provide a log of the error? CC eal.o In file included from /root/dpdk/lib/librte_eal/linuxapp/eal/eal.c:33: In file included from /root/dpdk/build/include/rte_eal_memconfig.h:13: In file included from /root/dpdk/build/include/rte_rwlock.h:10: In file included from /root/dpdk/build/include/generic/rte_rwlock.h:25: In file included from /root/dpdk/build/include/rte_atomic.h:37: In file included from /root/dpdk/build/include/rte_atomic_64.h:16: /root/dpdk/build/include/generic/rte_atomic.h:215:9: error: implicit declaration of function '__atomic_exchange_2' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return __atomic_exchange_2(dst, val, __ATOMIC_SEQ_CST); ^ /root/dpdk/build/include/generic/rte_atomic.h:215:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] /root/dpdk/build/include/generic/rte_atomic.h:494:9: error: implicit declaration of function '__atomic_exchange_4' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return __atomic_exchange_4(dst, val, __ATOMIC_SEQ_CST); ^ /root/dpdk/build/include/generic/rte_atomic.h:494:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] /root/dpdk/build/include/generic/rte_atomic.h:772:9: error: implicit declaration of function '__atomic_exchange_8' is invalid in C99 [-Werror,-Wimplicit-function-declaration] return __atomic_exchange_8(dst, val, __ATOMIC_SEQ_CST); ^ /root/dpdk/build/include/generic/rte_atomic.h:772:9: error: this function declaration is not a prototype [-Werror,-Wstrict-prototypes] 6 errors generated. make[5]: *** [/root/dpdk/mk/internal/rte.compile-pre.mk:116: eal.o] Error 1 > > Why __atomic_exchange_n is fixing the compilation? I guess __atomic_exchange_2/5/8 fall under c++11 standard? https://llvm.org/docs/Atomics.html > > >