From: Bruce Richardson <bruce.richardson@intel.com>
To: "Van Haaren, Harry" <harry.van.haaren@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>,
"shreyansh.jain@nxp.com" <shreyansh.jain@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 0/6] enable easier app compilation testing with meson
Date: Mon, 9 Apr 2018 14:50:39 +0100 [thread overview]
Message-ID: <20180409135039.GA136012@bricha3-MOBL.ger.corp.intel.com> (raw)
In-Reply-To: <E923DB57A917B54B9182A2E928D00FA65E01F0DA@IRSMSX101.ger.corp.intel.com>
On Fri, Apr 06, 2018 at 01:10:54PM +0100, Van Haaren, Harry wrote:
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson
> > Sent: Thursday, March 29, 2018 2:55 PM
> > To: dev@dpdk.org
> > Cc: hemant.agrawal@nxp.com; shreyansh.jain@nxp.com; Richardson, Bruce
> > <bruce.richardson@intel.com>
> > Subject: [dpdk-dev] [PATCH 0/6] enable easier app compilation testing with
> > meson
> >
> > Summary:
> > With this set you can test building all applicable examples by
> > calling meson with "-Dexamples=all"
> >
> > When building DPDK with meson, it's possible to specify a list of sample
> > apps to have built along with the main code. However, specifying a full
> > list of all apps can be unwieldy, so this set adds support for passing
> > "all" as the examples to be built.
> >
> > With "all", meson just adds all subdirectories of "examples" to the build,
> > so the first few patches are ensuring that we don't get an error by
> > attempting to build an unsupported application. On linux, only 7 apps were
> > unsupported, in that they had not been given a meson.build file. On
> > FreeBSD, a few others had to have their meson.build files updated to report
> > them as unsupported.
> >
> > In terms of behaviour, the meson.build file for each app will report if the
> > app can be built or not. If "all" is requested, then a message is printed
> > and the meson run can continue. If, however, the app is requested by name,
> > then an error is reported and the meson run halts.
> >
> > The final two patches in the series are more cleanup, the former improves
> > error reporting, while the last patch is a performance improvement. Meson
> > runs quickly enough in the normal case, but with a full set of examples,
> > the dependency chain resolution can slow things down. Reducing the lists of
> > dependencies makes a noticable difference in this case. [NOTE: this
> > slowness and speedup only applies to the meson run; the actual build using
> > ninja is as fast as ever!]
> >
> > Bruce Richardson (6):
> > examples: add empty meson files for unsupported examples
> > examples/l2fwd-cat: make build dependent on pqos library
> > examples: disable unsupported examples on BSD
> > examples: allow building all examples as part of meson build
> > examples: improve error report for missing meson deps
> > drivers/dpaa*: reduce meson dependency lists
>
> Working fine for me here!
>
> Series-Tested-by: Harry van Haaren <harry.van.haaren@intel.com>
>
Series applied to dpdk-next-build.
>From testing, there appears to be an issue with building ip_pipeline sample
app for a generic armv8 platform, but not for the thunderx one. Ideally, if
someone from the arm community can help fix this in the C code , it would
be great, otherwise I'll try and do up a patch to selectively disable
ip_pipeline for platforms where it can't compile.
/Bruce
prev parent reply other threads:[~2018-04-09 13:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-29 13:54 Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 1/6] examples: add empty meson files for unsupported examples Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 2/6] examples/l2fwd-cat: make build dependent on pqos library Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 3/6] examples: disable unsupported examples on BSD Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 4/6] examples: allow building all examples as part of meson build Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 5/6] examples: improve error report for missing meson deps Bruce Richardson
2018-03-29 13:54 ` [dpdk-dev] [PATCH 6/6] drivers/dpaa*: reduce meson dependency lists Bruce Richardson
2018-04-02 10:02 ` Hemant Agrawal
2018-04-06 12:10 ` [dpdk-dev] [PATCH 0/6] enable easier app compilation testing with meson Van Haaren, Harry
2018-04-09 13:50 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180409135039.GA136012@bricha3-MOBL.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).