From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id AA3C71B81E for ; Mon, 9 Apr 2018 15:50:57 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Apr 2018 06:50:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,427,1517904000"; d="scan'208";a="190000511" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga004.jf.intel.com with SMTP; 09 Apr 2018 06:50:43 -0700 Received: by (sSMTP sendmail emulation); Mon, 09 Apr 2018 14:50:40 +0100 Date: Mon, 9 Apr 2018 14:50:39 +0100 From: Bruce Richardson To: "Van Haaren, Harry" Cc: "dev@dpdk.org" , "hemant.agrawal@nxp.com" , "shreyansh.jain@nxp.com" Message-ID: <20180409135039.GA136012@bricha3-MOBL.ger.corp.intel.com> References: <20180329135436.92878-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH 0/6] enable easier app compilation testing with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 13:50:58 -0000 On Fri, Apr 06, 2018 at 01:10:54PM +0100, Van Haaren, Harry wrote: > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Bruce Richardson > > Sent: Thursday, March 29, 2018 2:55 PM > > To: dev@dpdk.org > > Cc: hemant.agrawal@nxp.com; shreyansh.jain@nxp.com; Richardson, Bruce > > > > Subject: [dpdk-dev] [PATCH 0/6] enable easier app compilation testing with > > meson > > > > Summary: > > With this set you can test building all applicable examples by > > calling meson with "-Dexamples=all" > > > > When building DPDK with meson, it's possible to specify a list of sample > > apps to have built along with the main code. However, specifying a full > > list of all apps can be unwieldy, so this set adds support for passing > > "all" as the examples to be built. > > > > With "all", meson just adds all subdirectories of "examples" to the build, > > so the first few patches are ensuring that we don't get an error by > > attempting to build an unsupported application. On linux, only 7 apps were > > unsupported, in that they had not been given a meson.build file. On > > FreeBSD, a few others had to have their meson.build files updated to report > > them as unsupported. > > > > In terms of behaviour, the meson.build file for each app will report if the > > app can be built or not. If "all" is requested, then a message is printed > > and the meson run can continue. If, however, the app is requested by name, > > then an error is reported and the meson run halts. > > > > The final two patches in the series are more cleanup, the former improves > > error reporting, while the last patch is a performance improvement. Meson > > runs quickly enough in the normal case, but with a full set of examples, > > the dependency chain resolution can slow things down. Reducing the lists of > > dependencies makes a noticable difference in this case. [NOTE: this > > slowness and speedup only applies to the meson run; the actual build using > > ninja is as fast as ever!] > > > > Bruce Richardson (6): > > examples: add empty meson files for unsupported examples > > examples/l2fwd-cat: make build dependent on pqos library > > examples: disable unsupported examples on BSD > > examples: allow building all examples as part of meson build > > examples: improve error report for missing meson deps > > drivers/dpaa*: reduce meson dependency lists > > Working fine for me here! > > Series-Tested-by: Harry van Haaren > Series applied to dpdk-next-build. >>From testing, there appears to be an issue with building ip_pipeline sample app for a generic armv8 platform, but not for the thunderx one. Ideally, if someone from the arm community can help fix this in the C code , it would be great, otherwise I'll try and do up a patch to selectively disable ip_pipeline for platforms where it can't compile. /Bruce