From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f173.google.com (mail-qt0-f173.google.com [209.85.216.173]) by dpdk.org (Postfix) with ESMTP id 0E1491B7E6 for ; Mon, 9 Apr 2018 19:08:34 +0200 (CEST) Received: by mail-qt0-f173.google.com with SMTP id d50so10004473qtc.0 for ; Mon, 09 Apr 2018 10:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=f4+q9E8YqpmztgxSF4/65EnZtoIc+UWTuBBjWefZyfc=; b=mxGF/+kERHN2lfqmhRZOat/2RJ+iwobWlKdpGRvuGCCr49g1kARyxSJ89gFuJkhIXw dj6NuTQOqSELylYul/8TKF10ZxtOm7uAKMwguMRKVBehmfB18dEi0rufWuZujGO/h7Bq wuChwYvIY0owkZPtHUypkzfEwJKyrLVDWDRhvN2+DlbLlWEHakVrZbv5b1cffUq78oGP mu52CpqFv3i2O3Pj6Z+C//Qjk7mzDEjtzFcsYAkxPlUNz4vb9hBYE1tGxeyghJwYF+L9 7YRhSPbcFFRymHyYA5jsqaNXvjZiOlLvyk2GxG2AeeLvdMkd7H7o/1yQSw/xpAuaHECk rxJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=f4+q9E8YqpmztgxSF4/65EnZtoIc+UWTuBBjWefZyfc=; b=Dt238ZZkVPF9me4liZee7uLw3Uw6vVZkRcPbQjx3KCOjKuKEKH9PCfpGOpreIkPzyk NBtZvMQ7q4JZF8sBhhqxA5zJlf3JwPIZnh66hvVQlQPuEzqpp+55QG72xt3/MBScQ50N u36EvW/pQbcEH0eGBtPLas2+b/hx6JRrtAvVq4aIlSF0B2LOcyrPbN7Px8b6MnQZbDJG 0BEsB4J1WXLLdBYKxqmKqK2WB+wrkIxqNuHrUK3x+zopvWafyC+5SGs//qEsl03zReEW EJk++dxFbSGjthk3AIpjkrFo0IHqCkLCcLfRbDU52IG7v7Wen/7HUhSdWD3liBZdmoit quBQ== X-Gm-Message-State: ALQs6tDmZFvS/1lfjw6U0KqbuHv2soqWXrfG74k9hEUa00rrK65UJOUX NsWh4H4ZvR+UIoTaCHdzIGE= X-Google-Smtp-Source: AIpwx4/h0+a0uW7CUzzY8tEOQDZhpvD47TsC6pa2J+VI94fXNnFbHK0dSi2B908HwA56oakuQgOxnw== X-Received: by 10.200.57.39 with SMTP id s36mr53561907qtb.328.1523293713330; Mon, 09 Apr 2018 10:08:33 -0700 (PDT) Received: from localhost.localdomain ([177.10.56.96]) by smtp.gmail.com with ESMTPSA id l23sm576113qtj.80.2018.04.09.10.08.32 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 09 Apr 2018 10:08:32 -0700 (PDT) Received: by localhost.localdomain (Postfix, from userid 1000) id A7275180F02; Mon, 9 Apr 2018 14:08:24 -0300 (-03) Date: Mon, 9 Apr 2018 14:08:24 -0300 From: Marcelo Ricardo Leitner To: Adrien Mazarguil Cc: dev@dpdk.org, Timothy Redaelli Message-ID: <20180409170824.GB27045@localhost.localdomain> References: <20180403175938.GA23889@localhost.localdomain> <20180405092621.GI4957@6wind.com> <20180408212750.GA27045@localhost.localdomain> <20180409150751.GC4957@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180409150751.GC4957@6wind.com> User-Agent: Mutt/1.9.2 (2017-12-15) Subject: Re: [dpdk-dev] Question on documentation / Mellanox ConnectX-3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 09 Apr 2018 17:08:34 -0000 On Mon, Apr 09, 2018 at 05:07:51PM +0200, Adrien Mazarguil wrote: > On Sun, Apr 08, 2018 at 06:27:50PM -0300, Marcelo Ricardo Leitner wrote: > > On Thu, Apr 05, 2018 at 11:26:21AM +0200, Adrien Mazarguil wrote: > > > On Tue, Apr 03, 2018 at 02:59:38PM -0300, Marcelo Ricardo Leitner wrote: > > > > Hi, > > > > > > > > http://docs.openvswitch.org/en/latest/howto/dpdk/ says: > > > > > > > > Some NICs (i.e. Mellanox ConnectX-3) have only one PCI address > > > > associated with multiple ports. Using a PCI device like above won’t > > > > work. Instead, below usage is suggested: > > > > > > > > $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > > > > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:01" > > > > $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ > > > > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55:02" > > > > > > > > But these MACs are 7 bytes long. Seems the idea was to mention the two > > > > incremental MAC addresses that the ports have, and thus the ':55' > > > > should have been removed from there, right? > > > > > > > > Reading the code, it doesn't seem prepared to handle the extra byte in > > > > any (special) way. > > > > > > After a quick glance at the original patch [1], I confirm it looks like a > > > mistake in the OVS documentation. MAC addresses should be 6 bytes long, the > > > 7th byte is not a workaround to identify a physical port like I initially > > > thought. > > > > > > As you pointed out, since default MAC addresses on mlx4 ports are normally > > > incremental, documentation should read something like: > > > > > > $ ovs-vsctl add-port br0 dpdk-p0 -- set Interface dpdk-p0 type=dpdk \ > > > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:55" > > > $ ovs-vsctl add-port br0 dpdk-p1 -- set Interface dpdk-p1 type=dpdk \ > > > options:dpdk-devargs="class=eth,mac=00:11:22:33:44:56" > > > > > > [1] https://github.com/openvswitch/ovs/commit/5e7588186839 > > > > Thanks Adrien. Question now is, who can fix the doc? > > Someone should submit a request or patch pointing to this thread to the > documentation maintainer of OVS. Since it's a different project there's not > much I can do from the DPDK side. Makes sense. Thanks. Marcelo