From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 3DE1F1BAAA for ; Tue, 10 Apr 2018 18:34:22 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id u11so13439724wri.12 for ; Tue, 10 Apr 2018 09:34:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ukSHPNnxQsqh4dbS7MFYQkL+QlTHUJn+Tz/Bv4Ygrn4=; b=bzqW8BER+Yuj+h5Zhx1AGji6bEiO/BgImuHS/E2iuNyxy8PPNU9clV9VsNIxZmqinv UmbMsLuMVx3zFPbDlGqzORfzL+Yegi5bzXx6wb/k0NIgjbFYH4iMYhoGUfJOESfVzGlt Q9Ow6ElX3rhd7CBTGO8QhxNIdk75az03a3Y5KAScf5yJCo68AXnWqJIXgZjNqhKRL6b+ 2yustRcN2rb1AFBiLBRlwZbKBIFeMmfdkYj3WHFt3Lb6oSNTBZGkcQUSPnN9pB0prKx0 ASQOgoP7ragUo9YCov0iwj54Z1jJ14CoQlTJLJnvQTRmgcpsrRdUDEXCkyucAP9klbLH 3hnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ukSHPNnxQsqh4dbS7MFYQkL+QlTHUJn+Tz/Bv4Ygrn4=; b=bI+tp82LYPggFUbuRhIuBLBa7aNsgc5gxcjh0DJUznXX9wJVrxhuH8Wp86dB85+w/T BGZMVhRSW+MqFlEHkVJorTFY2EurttU60K1QBC1TlgEQ2rV+7bILCJBQyJcj1uXDBsrN LvVR5hIFekV6omEnRwWrz+hbBlGIVvNY5eS5R9NrIp+q8UNqJ+AK1l9Ty/b2IRDFCCG/ +e8Qli7umX5gs8+NdCon2xbSnakyJeuRvJyEFUWgaaYs3+jbEL4G2iYYoswZyz+wUW77 huRUoprkZJPl5k1MelXBySIRbYmd48AOEHwamb3hBtHcfbpgS18VNDxooYkKoThv/Y2r MBNQ== X-Gm-Message-State: ALQs6tASN//t5ToWLnQSREBV9IWT1NmOeZYGsVFDzRgiIvNUlBqc10Ug KVWpg96mZNSR0u5NuIfZhuBcYXav X-Google-Smtp-Source: AIpwx4+BxD/OOXKKZ2KYtD4evzJ5IY5AxG8RyLGUP2KJuLotf2JKupl9d8jiQvzDOQ2FGzKwn/7djA== X-Received: by 10.223.176.119 with SMTP id g52mr922388wra.21.1523378061992; Tue, 10 Apr 2018 09:34:21 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id p5sm3534418wmf.37.2018.04.10.09.34.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Apr 2018 09:34:21 -0700 (PDT) Date: Tue, 10 Apr 2018 18:34:08 +0200 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Nelio Laranjeiro Message-ID: <20180410161132.8776-4-adrien.mazarguil@6wind.com> References: <20180406131243.19037-1-adrien.mazarguil@6wind.com> <20180410161132.8776-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410161132.8776-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v4 03/11] net/mlx5: fix RSS flow action bounds check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 16:34:22 -0000 The number of queues provided by the application is not checked against parser's supported maximum. Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule") Cc: stable@dpdk.org Cc: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index e6af3243d..f051fbef5 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -16,6 +16,7 @@ #pragma GCC diagnostic error "-Wpedantic" #endif +#include #include #include #include @@ -713,6 +714,14 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } } + if (rss->num > RTE_DIM(parser->queues)) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "too many queues for RSS" + " context"); + return -rte_errno; + } for (n = 0; n < rss->num; ++n) { if (rss->queue[n] >= priv->rxqs_n) { rte_flow_error_set(error, EINVAL, -- 2.11.0