From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id CF57A1BAB2 for ; Tue, 10 Apr 2018 18:34:25 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id n2so13446707wrj.7 for ; Tue, 10 Apr 2018 09:34:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=8W76KGOBWe8spOSweraVtm8sWiN9hW8+NZqeLvkuTPE=; b=nUPEIBPzcqaOCpRRJqPFprZIiJaxIyLjuWz5Y1gtdoA+N7ISY6FqJkxqejs+YDgPt6 N3EPB5tFpK/6T9V+4HOLMNoa0+P4y+Ndd3CfoBJKlmxlZKJ1pxRfryhVySnpi26IBzyj ypdVA2DfSmSW1zPjXVqdYUI2KofTmdNYrS07kBlUhTtTDUAI4Zb5j53iaDhIeIp52rG6 o0oq8J/UDbomOpzw3vA+1MBSW6LQ535pjJt3b+pQc0KU0ZBQnrWR+hlB1rNE8WCeb9kW HdRXzXLCU8WKk9mOtRLn8RCDROkmdAwWXTICbk6hoZZbBC/T8gSt9MnsbqJJMB3clcAR snWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=8W76KGOBWe8spOSweraVtm8sWiN9hW8+NZqeLvkuTPE=; b=ECStrIIsvouj8okjRDe1O2tzOpq2pwiwtaVlD5QJO8UcX4ulRo1nGb0MMEODqpRIAn tqH7kfcMOrXhEfXaromHFS3+PO4IfVzmGWRO5JDzGuIX6cEVf0TJ6mZSJnY4k5oCTuB1 9UVCMAL3vm64+Qee6P+rSqRJDjrMP3XG6QqGUxUbnKpsju4h6XDAn6BCfGQsXFNZQEfr HeASF48MYeXEcsqqtZE41V35wqB4tr9czQztULcmIQd4StHO8JS5TPwgBhWLfLyjwkZZ tHU/DhAsNcMjfJohv33lFoz6L/pnL5rnD5Q1LkwJ7HUTQzp4lPtkGMxPFwAleuQGzO3j o+Ig== X-Gm-Message-State: ALQs6tBFzdJ1SXQu/3m4/iuP98RSJF/YiIq+TkP3GRKE/Xcm3OGC+XV/ rcn1bMyNVBvjnigk3AK2uu7Jh6Yi X-Google-Smtp-Source: AIpwx495Nsxlg5OrZksTmFwR7qSUqEVHAEFXITXzQO9onqOoPFtloVrVTQJVEB/GyIByfht2/JLS+g== X-Received: by 10.223.196.141 with SMTP id m13mr860307wrf.173.1523378065554; Tue, 10 Apr 2018 09:34:25 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 6sm2571985wmf.31.2018.04.10.09.34.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 10 Apr 2018 09:34:25 -0700 (PDT) Date: Tue, 10 Apr 2018 18:34:11 +0200 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Wenzhuo Lu , Jingjing Wu Message-ID: <20180410161132.8776-6-adrien.mazarguil@6wind.com> References: <20180406131243.19037-1-adrien.mazarguil@6wind.com> <20180410161132.8776-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180410161132.8776-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v4 05/11] app/testpmd: fix flow completion for RSS queues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Apr 2018 16:34:26 -0000 The lack of a working completion for RSS queues was overlooked during development; until now only "end" was displayed as a valid token. Fixes: 05d34c6e9d2c ("app/testpmd: add queue actions to flow command") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil Cc: Wenzhuo Lu Cc: Jingjing Wu --- app/test-pmd/cmdline_flow.c | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index a5cf84f79..9cac8e9bf 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -2663,17 +2663,15 @@ static int comp_vc_action_rss_queue(struct context *ctx, const struct token *token, unsigned int ent, char *buf, unsigned int size) { - static const char *const str[] = { "", "end", NULL }; - unsigned int i; - (void)ctx; (void)token; - for (i = 0; str[i] != NULL; ++i) - if (buf && i == ent) - return snprintf(buf, size, "%s", str[i]); - if (buf) - return -1; - return i; + if (!buf) + return nb_rxq + 1; + if (ent < nb_rxq) + return snprintf(buf, size, "%u", ent); + if (ent == nb_rxq) + return snprintf(buf, size, "end"); + return -1; } /** Internal context. */ -- 2.11.0