From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-DM3-obe.outbound.protection.outlook.com (mail-dm3nam03on0070.outbound.protection.outlook.com [104.47.41.70]) by dpdk.org (Postfix) with ESMTP id 8E4371BAAC; Wed, 11 Apr 2018 11:00:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=SRWWab5sasjLPdCVZTBjCB/RbAv/v38eKZXmYoaCpTo=; b=TF1z3BrPyrmwf3aKzdUELiKruGGsesED8QslczQQKRE5wcGQH86aGoxHJZ+fPS+m05jLVQPZYlW/ZDozMu4n9Dut7by8vL9kAzBuJEKPypvBtxz8utpuy9SBfAqb3dA/gWPnGO5DDpT4oKJpqAYQZXC9FklKg8xSyQh4B5JZ+gc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Pavan.Bhagavatula@cavium.com; Received: from ltp-pvn (111.93.218.67) by BN6PR07MB3457.namprd07.prod.outlook.com (2603:10b6:405:64::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.675.10; Wed, 11 Apr 2018 09:00:21 +0000 Date: Wed, 11 Apr 2018 14:30:09 +0530 From: Pavan Nikhilesh To: Thomas Monjalon , techboard@dpdk.org Cc: dev@dpdk.org Message-ID: <20180411090008.GA28079@ltp-pvn> References: <20180406110103.29163-1-pbhagavatula@caviumnetworks.com> <3084545.g1xfDtWPys@xps> <20180411083819.GA27100@ltp-pvn> <2267766.OAdEpiXt1a@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2267766.OAdEpiXt1a@xps> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [111.93.218.67] X-ClientProxiedBy: BN6PR1001CA0006.namprd10.prod.outlook.com (2603:10b6:405:28::19) To BN6PR07MB3457.namprd07.prod.outlook.com (2603:10b6:405:64::20) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:BN6PR07MB3457; X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 3:6vu2Y2N5rpwyx6YdZ7sMo2gGmPD0VWybh3tu49mDxg9SdTgCGguUKQl6K+j+JF5BCUpACfKSj1l0QzBekNS9t3SIVKlv26TJ3JpkFAJpsc0KfA+u4tGUi+aOYW41Th2qOqpYiajRGiLmA1ABEV24raccuFhSLh6G+FsUw/K/5SRldJpAT7SRFUC0kRZnBzK67W6Lp3JdDCaO2Q9QuuigVXcrLamXHeJ/ICrRjDaE1IYutsbpXp0Zfy18AoE6wmBR; 25:00z+vLdAN0JnVM3a2U8HInrDOwKw+iUg67nAk5Kl3ptzkcD1Ve6DcFBMQsT1DEY+PMNdpfRw7EfdKnyMiE64x0nsQ/tZrR3fKXOOJ9qnwh9yWyv4hzrTUSPhrlZbC7ZI/mGeLmKWHHoQVh+7oLAsk+RWsTgZ1H6DruDQWI0Yscs9kdkkHCL5jkj60l0uPU852alzj2HrEo5yZqTBaIuk6AriUdMXzDlUqSz7+m0XGe61ZRX3xqL7I61vHYAgcr+BbkaP4hV+S/M4edFG8XurkgWRweTRhcIgCcwSVOarmZzsoD720XlbQ+JEXlaAy0tevE3eu2uswTOjcZN49MyFXA==; 31:UYFo9A/WDQwPqPMYEb+5xN3mhbwOBgOoDG1Fa4u1vIe8em5SQrs80Car08sfSKlWnjWxSRghuL+4NLgKCVteGssfzJ+WhL2hr41GTHwDz8GsR1xw1XY9UzrZmb+KkPM6iHW32BzVfGZndf4s75/xPzKx3OKLox8+ThqMaWOPcM9sr67oOs6xf6PYTpD9Me4J6L1XMgqwjIDT0f0XYKVS7MvIskmo823f0GUjK39ZbCY= X-MS-TrafficTypeDiagnostic: BN6PR07MB3457: X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 20:5qWHS0tEgF+SlAVGZYzG8IG1H7B6qfoebkZIh0t1dsBvdrpzQDrZR1XqNcfA5ppb/qBaFsvXGNVVP+CVJWhyshhcuhbcsvAzUhtkGddHLDGh7d1X5j83GsdufSm1XR3WbDhDOfC64/URbiF7gc4fUNEHcfZLSwLiBIWCDQ18IpFopPDIBkqBnr9gGXWEXTXSlvo1Y9spOmnsjuH0jDbGPYrDxQxgeDvzWo0c1x9JiMcDUYLbDZB3FbM1z9ltddu+o6LNhyHhi1bTgVVWBjIBqE8hUsqrIzVPirSg1BExsLNbktH0iOke/yM4ihsfB8wdveo06eX5hapVbTheiPWgm5Ax/IgETV/kKjzR2Qwx7XLITuiYKhMGxf0E1rd4le64XFGFQnxkRFN1hwVYqzVrDRAFHVOCUBM8ONS73tI1dmmVMrXxO6Dx++aeD380WRQ6jIhG3rJ8AqMdMCP8Fa9ayTC22kWscifujd42QlorzcrXz6OQc7dhAZFtZH5EZLVcFy2S5r2RkMcc8l6oU4/9s0nIkU1NGFKpgEEGNb7FfjPRqaWGZyh+5Z+PP4ScDkqQb+7xhSSir47yvVDqwIjj2FVHft2kiIHYBJ2h9wZBqZs=; 4:brv9yxlIPXIDKamz8h7/tDzR1k50FTVKJxcIPltjRZU6TY0AB53Y+UtZyHl++2pXz5ktL6IekUH9cmOXJAZj5SQRWeATaDumGOjWGL8IkhJ7tiRoR2UAHaXwTLK8PI06EhP2OL1gJlA/bwlj9EP2T3E2JBLsgAFNdFzEK3n0gEvF+/4wjGcnZ0WDjrtWckrStiuDkt/y5pLxujnVTIyIBxOBwpUGO6EKasJodybxN6g5oXS4y87UjU7+Sk5PSL9HutcV/3dUFTRgClfymOnG2Q== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3231221)(944501327)(52105095)(10201501046)(93006095)(3002001)(6041310)(20161123558120)(20161123560045)(20161123564045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(6072148)(201708071742011); SRVR:BN6PR07MB3457; BCL:0; PCL:0; RULEID:; SRVR:BN6PR07MB3457; X-Forefront-PRVS: 0639027A9E X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(39840400004)(396003)(39380400002)(346002)(376002)(366004)(199004)(189003)(93886005)(5009440100003)(81166006)(81156014)(8676002)(8936002)(42882007)(476003)(11346002)(2906002)(446003)(7736002)(33716001)(186003)(16526019)(305945005)(26005)(956004)(4326008)(6246003)(25786009)(47776003)(229853002)(66066001)(6666003)(1076002)(53936002)(55016002)(9686003)(72206003)(59450400001)(386003)(33656002)(486006)(106356001)(76176011)(105586002)(52116002)(33896004)(6496006)(6116002)(478600001)(3846002)(50466002)(16586007)(68736007)(58126008)(316002)(5660300001)(97736004)(23726003)(18370500001)(107986001)(42262002); DIR:OUT; SFP:1101; SCL:1; SRVR:BN6PR07MB3457; H:ltp-pvn; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; BN6PR07MB3457; 23:5BkgR6qFle4zKgjgMaYjXwPrbnC95HTpjZ2QciAho?= =?us-ascii?Q?zcH/233yf0C9jY71vMt8yNPv1lcsvTj0cr86rb/hgxcOqONTqfQy9vrN74n3?= =?us-ascii?Q?Bv6CylpDH+92GyYLjQY/XcjsFQl+vX3NcBeZaFA/w75wzHcbYGNhO1Z1U7hr?= =?us-ascii?Q?/ZqyRbxMwiSDKNboTBdddan6Ce+UE0fZxusHa1Z03eNJIpKCDeeMxt+++4Ea?= =?us-ascii?Q?1IgHXga8hoEvlXHQIM4iM/qBE6kTracwnIapPzgiNdD0jSvZAZcT5nS0jKqM?= =?us-ascii?Q?ZbdW5MAY3uzselU842Un8ZsTPOwZp1LnBI3MNMArnjWg0Lqy0J8tX0HHhczy?= =?us-ascii?Q?cpBoAaMmpvi4h9h5cb0UsMjGCQjK2to6Z5f5SMLGbKvFyLQnVDJ2KqZKTgKm?= =?us-ascii?Q?yJMKMIcPr4ah1CeHr0xIO05dNx2ZN5A6GQWLGYQAb6zJ71MTMhnfpEoWQm7n?= =?us-ascii?Q?nkBrPAJ3/AobgJyWf2LuD+ZtGR4Sofz40Okqxd4jvykQku5SbC5+6JhBjeQb?= =?us-ascii?Q?vl+xWJaEis74znnKkuMFYQZE3JqSc2A/Voy/7YDqhZM8D0Yg2DIgbykkT2ui?= =?us-ascii?Q?8KgnGZ3ySmz/shGu9s2YdQC6/Rmj2ptsGvF9Df0a9THXP/EEbdmFBM93zPlz?= =?us-ascii?Q?lvAshN3cev6gJ3W9tqnDIz9rxpoRnPIh8NTj9GF2jnF2yGNW551LbT8ldmaj?= =?us-ascii?Q?4p4nGsAig//sRoLWv35ezQBRIOldxKeBs/fHrKdMwCEno4WSyU2/FoGijJBA?= =?us-ascii?Q?zRvyhCJE8yRYcitMXrptEfbDR9aMazYP+hwM/+M6Ix7eizfYws0/BsjMEhA5?= =?us-ascii?Q?B38GALX3DMOeuJBehXAfIUardgqEckaimQ+MV2sl45joJhk1GQNQkoLLaiTK?= =?us-ascii?Q?QnWciI9uQ6hX1FXcrnWZYd01oS5Lpd74187edbCOw4VPAe8bqJgWWTEKbkDY?= =?us-ascii?Q?2NTPRGnbD2EFmcp7bMFOPqAvaAh5LbT3CMAvFTGgDsYPcPgcaEzbUWG3CnEs?= =?us-ascii?Q?aIjrzjoi+SPCb65M0O5AoH3ztdqmpykEJ0VtHfYu+DKK/KYFWG2BXpQOkEUO?= =?us-ascii?Q?Uk+o1MI+RvlCAJdcB2+C8yIWogWPVRePjeba/hnqcoZalmLxraF74+hVVgEj?= =?us-ascii?Q?lyX9jr7j1KoI/sfQmolSW09tR5ppf4ipmiRbd2+wrFf5pXVFUhz7cDzN/DG2?= =?us-ascii?Q?HottshGFi+2kRaosQBKcwqUMu4jeo2KA4e8ozN7uArCZsuqQji/6AdQuGN7b?= =?us-ascii?Q?VJbTEkbCl8GkwzYOMugv7uItUGpUAkHHxSEuCKjmdL3HLkuMG3LR+CSOovZ+?= =?us-ascii?Q?CkAs1pph6zu8PgDe/OegZK1dO9+SAQ2BSdh2krG79C+kDr39JGbn+NUHPLqh?= =?us-ascii?Q?tYeCgzhtAs1Qgh9v+CqBXXWAzwTABhpMgh0zEDL2uB583m0?= X-Microsoft-Antispam-Message-Info: TXJ11x3xFb68RaNu1PSlCGpdN6dFjnReTIo8QQSnp9MZWgtbB1vGnTk+OvuCOh/vLPvmBKG3U0unIHFWf/3pWppJVuWSc53Yi/YeBjflwCm330AuqhQ2I9l9qZARqgNdnLgBYZ0s37CHQz2NQoi1sd19BX4wyvzhqBaaCL8GQg7uAi+TLE0QnqrWKzGgkI4F X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 6:bC5L/MayYkho9eJYBu/YzacUB7bXBP10jQN4Tb/FTwuQ4JC3HLV8v6lA7lyHm3hUMJ0VSa9Ua5hmQqZBcOuEWXYHjYI8aD0X9elP+yEqZcwdnuBACRmmT0TtqIhO5MCQFPLkhjG/JIGUtwzqDD9MnMKsbIhgthFZvA4z+JILD3sLk1D6CbKMLKsQLi7tuuFzF7pxbJv9R1wrkGjOwWdSWVOp3BGNt6u5WMG5WjTcfphy8KM9iYVEGyrQaELyBvrYOOtZuRti9j2SBCPfQQSM3wPwzSRM/9WXrRqJQV0q82ndx5ZClSj9SK5wAo90NblmRE+zTdBBWEtVvL2wkaxXutuHY6tD6UdahD4yQwShEUoOmPRQ6/HHh8fwDlNz5UYUyqO86bsw3UWsKjNPFsnFYcoiNYuxl5Qut990e1B3NDuZ+Z+UbjQdohE7gp0T/Y1fDJdEasjRob7e9kfYEu53iA==; 5:Gxtz6LqfJl1XjVJy0GpTcsCb+cz63GbeJKYQGnQpScijCONCyViRj7hz+QXkUmJinL/mFy3QUxSGfhcaq+u8eGhCbGZgAQP1OZyLkqYz98tGf0azS9ZGy7ifVW/7WfxTMJDIFFumsrBPCkpTCxCQGf0+5Um9ElYsx82R1r3ztW4=; 24:5Rz6lsfDUmeHjw9ss9gckFyRjoDNyZh+SSYVQtKBmxOhaW7wzQddjscjDkGnO1NIwHIcYpzmDhk4F8ijgfYa7wcuQOApLj9QIMjc407maiA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BN6PR07MB3457; 7:s3fQM9g/M984GiceTOdLJU9mXaZJg1eqSO4JMwt3iETYwMKzdtWKCvbdKCQDfAKJfWaH0mKl8i5OleWRME6OWz9TmdY/rVehPn+Fb1XLlndqvA+BJhVveOywQ0M7oDA/rp5wIdl+6URGnInQubckcpvDJf7PhMyn2f0PyCLPpb7N+MnpailSO0vGA8uyscXrqnop4cFtoR7mEmfc4hy2jitnRP+sPOMSwmEkCiyRpLz413UQ9fo/u2VsGvdkUq9e X-MS-Office365-Filtering-Correlation-Id: 0699093f-47f1-450e-1f32-08d59f8aa89b X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Apr 2018 09:00:21.0784 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0699093f-47f1-450e-1f32-08d59f8aa89b X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR07MB3457 Subject: Re: [dpdk-dev] [PATCH] eal: fix clang compilation error on ARM64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 09:00:24 -0000 On Wed, Apr 11, 2018 at 10:46:47AM +0200, Thomas Monjalon wrote: > 11/04/2018 10:38, Pavan Nikhilesh: > > On Tue, Apr 10, 2018 at 11:35:15PM +0200, Thomas Monjalon wrote: > > > Hi, big issue here. > > > This patch does not compile on Linux with ICC or GCC < 4.9 > > > because of a missing C11 header: > > > #include > > > > > > GCC 4.9 is recommended in doc/guides/linux_gsg/sys_reqs.rst. > > > But GCC 4.8 is used by SLES 12, RHEL 7, etc... > > > > > > Note: Intel compilation tests are running with a backlog of one week, > > > so cannot catch such fail. > > > > > > Exceptionnaly, I have decided to remove this patch pushed few hours ago > > > (not reverting), in order to avoid a serious "git bisect" breakage > > > in the middle of the git history. > > > > > > We'll need to find a better way of fixing the compilation error > > > seen on ARM with clang. > > > To make it clear: I believe it is more important to preserve GCC 4.8 > > > than clang compilation. > > > By the way, what is the version of clang which was causing the error? > > > > I have tried with clang 4/5/6 and all have the same issue. > > Do you know why the issue is not seen on x86? Nope but I tried including the header as well as using -std=c11 in cflags but still observing the same issue with clang. > > > > > The error was: > > > include/generic/rte_atomic.h:215:9: error: > > > implicit declaration of function '__atomic_exchange_2' > > > is invalid in C99 > > > include/generic/rte_atomic.h:494:9: error: > > > implicit declaration of function '__atomic_exchange_4' > > > is invalid in C99 > > > include/generic/rte_atomic.h:772:9: error: > > > implicit declaration of function '__atomic_exchange_8' > > > is invalid in C99 > > > > > > The proposed solution was: > > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8), > > > and include stdatomic.h. > > > > > > > > > > > > 10/04/2018 17:07, Thomas Monjalon: > > > > 06/04/2018 20:25, Pavan Nikhilesh: > > > > > On Fri, Apr 06, 2018 at 06:24:34PM +0200, Thomas Monjalon wrote: > > > > > > 06/04/2018 13:01, Pavan Nikhilesh: > > > > > > > Use __atomic_exchange_n instead of __atomic_exchange_(2/4/8). > > > > > > > > > > > > > > Fixes: ff2863570fcc ("eal: introduce atomic exchange operation") > > > [...] > > > > Applied (with error log), thanks > > >