From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f179.google.com (mail-wr0-f179.google.com [209.85.128.179]) by dpdk.org (Postfix) with ESMTP id 6CBAC1BB7A for ; Wed, 11 Apr 2018 14:25:39 +0200 (CEST) Received: by mail-wr0-f179.google.com with SMTP id u46so1585087wrc.11 for ; Wed, 11 Apr 2018 05:25:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=gjE5xn0OgRdw2pgmx3tLRKRvgop/v3QpcZtxuAM94nQ=; b=UvQkgUu8xUPC1ZvURHQeRhZuKSRQEVI1jwXWyLWkWHyUwRG+bBoIT4N1NW3weWmIQV dGhGRM40FZ+XvvCTnx8BUZKQvmxXlLTH1d8sq+ZZy5NWcakwrfc1fKnrglcJ1P1DiE72 P6dgW89Z0GpxLFYa+r77am09CGcAKDgqg0utKePXROFwQ7BFP69jQ8nlIl0jjkqLN/ut yZzuFZ8usZB2BvYG8A8tbFpQqTO0ppyIieF3MO71SyPOftNsxJ7s5/p5eEvfprQdAiYW bge8VMAlpTkP4ZAZrdEsfWmOuTpYAhlonNcy4G+/Wd7GXFp1vpybvz75LDF8ao/42F2G 7/QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=gjE5xn0OgRdw2pgmx3tLRKRvgop/v3QpcZtxuAM94nQ=; b=Poc4eYwJJQ8Fc2AqrZMySmuPf8HhxdT545PaB9OueowALVcoPtDNUdYsWhT0RW32k9 ntdFfLJSAT8JGj205r6LPSyM1PsN2eM9WrePUhGfaLq6mJvTG6GZdkVkxjZSf8xKdMNS I+L3qtQLx2tNgqwcgpoRbAWg5EIkvsqD1m1awkVIa71qi/BPIyLVSL/c1jZ2mqAqTrGf F2cT9hoAYrmfJZ3hLTgdnZL7jOCkwM5z51HMaP7ft/dO3wKRL7iwun/fGISkha07+h+P XGtYRifCouYPm4bCBzIlETKo5g3zCs5TRjLMD4uhB6tH4ukxRPtVt0C/5D0qHlBo+Bxt 4sZg== X-Gm-Message-State: ALQs6tBQSCTL5nI/LJhcleUMUg3PKeW//dMpCAqYsuRdlZv+TBSbopPG /IRRs03Yz+/mALk4oY1a5ar2Qs7YCw== X-Google-Smtp-Source: AIpwx49yU/bMmBYiKTr+1puBnOTSeYU5TvrdQLqYr6xrpVlBzsP6Glbt7HKGsUboLVN+OTC0SCNB+Q== X-Received: by 10.223.135.76 with SMTP id 12mr3138703wrz.275.1523449539124; Wed, 11 Apr 2018 05:25:39 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g24sm60618wrg.4.2018.04.11.05.25.38 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 11 Apr 2018 05:25:38 -0700 (PDT) Date: Wed, 11 Apr 2018 14:25:58 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Xueming Li Cc: Shahaf Shuler , dev@dpdk.org Message-ID: <20180411122558.wex5wju2nohybdyk@laranjeiro-vm.dev.6wind.com> References: <20180410133415.189905-1-xuemingl@mellanox.com> <20180410133415.189905-11-xuemingl@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180410133415.189905-11-xuemingl@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 10/15] net/mlx5: allow flow tunnel ID 0 with outer pattern X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 12:25:39 -0000 On Tue, Apr 10, 2018 at 09:34:10PM +0800, Xueming Li wrote: > Tunnel w/o tunnel id pattern could match any non-tunneled packet, > this patch allowed tunnel w/o tunnel id pattern after proper outer spec. > > Signed-off-by: Xueming Li Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_flow.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index 857b8b716..58d437308 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1803,7 +1803,8 @@ mlx5_flow_create_vxlan(const struct rte_flow_item *item, > * before will also match this rule. > * To avoid such situation, VNI 0 is currently refused. > */ > - if (!vxlan.val.tunnel_id) > + /* Only allow tunnel w/o tunnel id pattern after proper outer spec. */ > + if (parser->out_layer == HASH_RXQ_ETH && !vxlan.val.tunnel_id) > return rte_flow_error_set(data->error, EINVAL, > RTE_FLOW_ERROR_TYPE_ITEM, > item, > -- > 2.13.3 > -- Nélio Laranjeiro 6WIND