From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 7B6FB1BB1C for ; Wed, 11 Apr 2018 16:42:50 +0200 (CEST) Received: from lfbn-lil-1-700-92.w81-254.abo.wanadoo.fr ([81.254.37.92] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1f6GxS-0003aZ-CN; Wed, 11 Apr 2018 16:42:47 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Wed, 11 Apr 2018 16:42:42 +0200 Date: Wed, 11 Apr 2018 16:42:42 +0200 From: Olivier Matz To: Thomas Monjalon Cc: dev@dpdk.org, Ajit Khaparde , Jerin Jacob , Shijith Thotton , Santosh Shukla , Rahul Lakkireddy , John Daley , Wenzhuo Lu , Konstantin Ananyev , Beilei Xing , Qi Zhang , Jingjing Wu , Adrien Mazarguil , Nelio Laranjeiro , Yongseok Koh , Shahaf Shuler , Tomasz Duszynski , Jianbo Liu , Alejandro Lucero , Hemant Agrawal , Shreyansh Jain , Harish Patil , Rasesh Mody , Andrew Rybchenko , Shrikrishna Khare , Maxime Coquelin , Allain Legacy , Bruce Richardson , Gaetan Rivet Message-ID: <20180411144242.rkiavbycil3drwc2@platinum> References: <2759953.P7QpFFSjiU@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2759953.P7QpFFSjiU@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] Survey for final decision about per-port offload API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Apr 2018 14:42:50 -0000 On Fri, Mar 30, 2018 at 03:47:55PM +0200, Thomas Monjalon wrote: > There are some discussions about a specific part of the offload API: > "To enable per-port offload, the offload should be set on both > device configuration and queue setup." > > It means the application must repeat the port offload flags > in rte_eth_conf.[rt]xmode.offloads and rte_eth_[rt]xconf.offloads, > when calling respectively rte_eth_dev_configure() and > rte_eth_[rt]x_queue_setup for each queue. > > The PMD must check if there is mismatch, i.e. a port offload not > repeated in queue setup. > There is a proposal to do this check at ethdev level: > http://dpdk.org/ml/archives/dev/2018-March/094023.html > > It was also proposed to relax the API and allow "forgetting" port > offloads in queue offloads: > http://dpdk.org/ml/archives/dev/2018-March/092978.html > > It would mean the offloads applied to a queue result of OR operation: > rte_eth_conf.[rt]xmode.offloads | rte_eth_[rt]xconf.offloads > > 1/ Do you agree with above API change? yes > If we agree with this change, we need to update the documentation > and remove the checks in PMDs. > Note: no matter what is decided here, 18.05-rc1 should have all PMDs > switched to the API which was defined in 17.11. > Given that API is new and not yet adopted by the applications, > the sonner it is fixed, the better. > > 2/ Should we do this change in 18.05-rc2? yes > At the same time, we want to make clear that an offload enabled at > port level, cannot be disabled at queue level. > > 3/ Do you agree with above statement (to be added in the doc)? yes > There is the same kind of confusion in the offload capabilities: > rte_eth_dev_info.[rt]x_offload_capa > rte_eth_dev_info.[rt]x_queue_offload_capa > The queue capabilities must be a subset of port capabilities, > i.e. every queue capabilities must be reported as port capabilities. > But the port capabilities should be reported at queue level > only if it can be applied to a specific queue. > > 4/ Do you agree with above statement (to be added in the doc)? yes