From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0078.outbound.protection.outlook.com [104.47.37.78]) by dpdk.org (Postfix) with ESMTP id C68D01C0A5 for ; Thu, 12 Apr 2018 16:21:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HvWKqVcEDLpA29/vDVVzwjOrSn9TOYYIav/bUlRu9EE=; b=oCSlToS662YDLxq53jGvj3iMY82ZZz2p/DMcweH6Y3jcHiG1iAZpvqZy16t4qnAlu+HgTKW9hZfbwceljTFywE7EH4tfHktV3ETuKffuCoHnwGdME94LwWvfhokFBzKrUn8GN/JmYizTIPnhmZqxlNOLL2FWLABgHEH92tt0GqU= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Jerin.JacobKollanukkaran@cavium.com; Received: from jerin (106.208.131.34) by CO2PR07MB2519.namprd07.prod.outlook.com (2603:10b6:102:13::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.653.12; Thu, 12 Apr 2018 14:21:06 +0000 Date: Thu, 12 Apr 2018 19:50:48 +0530 From: Jerin Jacob To: Bruce Richardson Cc: Sunil Kumar Kori , "dev@dpdk.org" , Hemant Agrawal Message-ID: <20180412142047.GA18670@jerin> References: <20180319134520.28155-1-sunil.kori@nxp.com> <20180412140322.GA59668@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180412140322.GA59668@bricha3-MOBL.ger.corp.intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) X-Originating-IP: [106.208.131.34] X-ClientProxiedBy: BM1PR0101CA0003.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:18::13) To CO2PR07MB2519.namprd07.prod.outlook.com (2603:10b6:102:13::6) X-MS-PublicTrafficType: Email X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(4534165)(4627221)(201703031133081)(201702281549075)(5600026)(2017052603328)(7153060)(7193020); SRVR:CO2PR07MB2519; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 3:plQZf26R86uVHmmn45fgrZ69ONbpl/G88fzLQKkB7OYdyBC5NMiuTxhQ6WZsArI279JqGy21ya7H8rn+hWseVmbvOWKB2+wNIfZgEKb5WSZUjU/j2JlBUPVgTZG+UJdkbZd8r9zHHN6pVy+zXvNem7SYPVoUTfAMa3QPBSI+M66UoC67wTNqfZnRLF2eV7v2zn5fBRvF7KmtWGK2qK4XB9cnMDVcdaLfTJT3Uq5RejIUHl/VHeH0SlbE5htYN/pm; 25:V8IGrg60K5rIARUMKssLgXjiI5uhApwSoGkEw+FLOAbWK1T8zhh5jPcDdwWxHMxOkuXllVqFPKBfunGWtWZ7fyVG2QPiq7ZqwLSFSqc37pQ48YO2tYbI+vF2CTOoS4N7PVoEwib91g7vFCYWNRfYcGoWpgG53JOXFW4zj+ezctS72MuFqYqGojy7wDdNkTO+xvaifDllrhVuNPGOCtHH2AdLM8S39DWDivkycCClCrwRcUzT7jwz6dW27pOlJe/HnEtiXJFRLdOecx1vBVOkFKWAhnDuGabd/TW3t73FRN+LMsFxZiBehK4eX+sNupoeU3W+0cIAagxDQRNlbV0+tA==; 31:KfaErTussv9/R/l8CFewLSGFb4HeQ7Bmtu616GWvpSNQ3Rl5QivEneeX7rvOYBgyqw8vkWF7yv7jXiF1mywIlK7JEW0TcXrtOpUq0Yxe6JXSzSyU2OI9RxP9stvjLMi8xnAakhf9SdR2yDbhdJ7YciZPX2fsz58xNLtSPcK+hXl6Md/Y144o5maVt69pzHoef59uEML5aW1KCLYqb195RoSX+1pxEiPo4XovvapT+u0= X-MS-TrafficTypeDiagnostic: CO2PR07MB2519: X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 20:wWL30oyhhLgHa/5EUIU/U0C4J/6V2PZyn1k8sRWfD0yIWS5cpSDUcQSWAnZXjbq1vacQ37/vuwzMSsBgNXar7l06OI4nuFYBvj3CmK8xi0tpzxHp4UmtSvP0EhtI/+AZ/+HfxzahXLMWBMsp2ppSWgRfBw9eazdjDI6JNWIg+fvsreINLKI3uPvgM3pLWHyZ0DdVZlv6tBvSnRdhbKEeoB3Ap1i2ed+n6j4W9nrZ/Q7Nn0pXisXjSwxA8HdWAT/a+/A0lfaOD9VHmE8g4L0aHOXNl/vm0vNQUoXSOZPO/rkZss7pHpGIK26O1ArusVcmvW912v6qDXT/VFjionwFBtlzimTKS5HE9JtUwr6B3jdH5Ym2cVA1hA1qHBRhcpmqZoIq3a4IpAeovQw+crc36vTsYmfBS4wlGGD/ox98Ly7eKKECiekAOWD4AO5qj7Lo5EjzQWtMp5mLnZGX70f1Ad2bVnGMkQ5dI6Bg9cZJagC5f10ivU85I4slOS+dEvsAIxQRxn/GpEyqToJb4O1+G46o3MrLYe/7dBnstuQmLYAXac+laiWqsmCh/zhjyGYmYo/jIOHn2PAksfQgAVnZr+2ncUAdd35FFWsYYi3UTBo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(228905959029699); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(8121501046)(5005006)(3002001)(3231221)(944501327)(52105095)(10201501046)(93006095)(6041310)(20161123558120)(20161123560045)(20161123562045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123564045)(6072148)(201708071742011); SRVR:CO2PR07MB2519; BCL:0; PCL:0; RULEID:; SRVR:CO2PR07MB2519; X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 4:jiUTwfmRF4Zrg8i7yUVaEplHuFJbEGhN/YL19JrhgMoqEMCYax/xUwD/e/NVzQdiClrkZi/5Wc/B5lnZ2G5Tz3EE94FwUO9KGufTKBnG8J8HVLxy6xS1qjNsZ5AxMjcRJdLRue25QnHTGr9+ZibTVFP257dAhbuLVC3unKbv/Iz6T+IL4dWf9OERUBAFrFJi/kUg4tQrlNkZtZ9x5B19uU3CW9+r0MXBR4FIo1eVmFsKocHOW6Is2Wb8LBK9BzMJuHgds7HuOOnHbYFZVmuW7A8OJzsnhPaZ1EnCd9Sw4HTEXviK3RSQF14DImtZi22fxbnDo/dNYixwjG0MBTqbtALwL2C9Grme5Dsp/A6iAak= X-Forefront-PRVS: 06400060E1 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(346002)(396003)(366004)(39380400002)(39860400002)(376002)(199004)(189003)(377424004)(13464003)(5009440100003)(52116002)(2906002)(8676002)(59450400001)(7736002)(26005)(386003)(186003)(68736007)(33896004)(81166006)(53936002)(486006)(33716001)(8656006)(55016002)(16526019)(305945005)(53546011)(44832011)(3846002)(50466002)(25786009)(76176011)(229853002)(4326008)(6116002)(97736004)(106356001)(956004)(16586007)(6496006)(316002)(11346002)(58126008)(1076002)(446003)(476003)(478600001)(54906003)(6246003)(72206003)(105586002)(6916009)(23726003)(66066001)(6666003)(81156014)(33656002)(8936002)(47776003)(42882007)(9686003)(5660300001)(18370500001); DIR:OUT; SFP:1101; SCL:1; SRVR:CO2PR07MB2519; H:jerin; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; CO2PR07MB2519; 23:m+UtXoa4JiabVHrhr+Inr8n3BtKwbBD42OLD8s4kh?= =?us-ascii?Q?tLiBAMdoWnfKutvMZMqFb+s4qc8pLqwEWUpv6Ry75LJmSHq1AMPCsu2bsj7T?= =?us-ascii?Q?h6qzhn9gGHAPoJBRCIYhaYa631MYFnZthzoaNTKRMZEvOQ76NwqT06jskK0S?= =?us-ascii?Q?fvNaXiU9g7YKIMlFvfmBQfVLCM484BZCQ7dmMD03SHWV2OP1ST6BvjOJYaTW?= =?us-ascii?Q?JVPpfCEHlRs3vyafpTydUSV7dSeZ5rm4arRl4X/0Wf8ee9MezVQseQA5L0qJ?= =?us-ascii?Q?KLLCoTfZGOdHq1bFSGu3+At8a9xBuzslhssU54cvZYpFX+d7uH8fP2iC9dAd?= =?us-ascii?Q?z9E58Vlc2TVml6lqYx/imCIrmyfHjq2yftIhFUxePQ0dLcm3i9P/cbVXun6Y?= =?us-ascii?Q?xwqTwdBEW3MtL/reycCfquwnQVn7Hbu65PGTbg9Mec1m9FYLD6AQ5sPYUKTD?= =?us-ascii?Q?UW1b8wBqFNt1exmdra/1hlWbcp+p1ars/J0O9x008bufutIE6tEHpvDzTGRj?= =?us-ascii?Q?r7KyLZIArZO5NReIUAgBZjD8cUk1Fa1NLPQ8GkcjBfh0UQ4502zJHNZw+80B?= =?us-ascii?Q?ia+uv2i4oHApqILRbc/nubTIqRCFmY2ey1PLMLtrc+04ILAogeQA11shcqKt?= =?us-ascii?Q?5wUbMOMm3U+8FG/8yvSM+GujNFsjOaphYl6+t7xQ2VQYhU8UGSDHwbixjzZS?= =?us-ascii?Q?YaKOSlBtme7uBcmNto6mmVrQCQfNBgJxGP8aBT1Pqx4u6PaSwRm+D2KyP0y0?= =?us-ascii?Q?kgLZLkvF6hCflpSz57Gdf7GhIMqn7UzmdhiwmKJ+TH2zKiC6/ZbMUUKeqbfW?= =?us-ascii?Q?LTIT+lEVr6B/LkBxzYPnJsH2OBIyAfn1v/8TN4EiK6k1MnLIy2Mahd3Ftdvw?= =?us-ascii?Q?sFWAZgkYFZxnwD4Vh942jbC15uQ0/3SqYr6eSEgnBDmL8mVQQHyzK+aswY65?= =?us-ascii?Q?WSVt7t6I4S/GPRzxzgMvz+4tHugBIJPW9iR3IHov4e9z6+QRjpKkK+WP122k?= =?us-ascii?Q?3Q8JQQbMgXu66Tgy6Tv5eRKhBJ2HgSi1ApM0Ghhq40BNpOR5uj2SIc/jpDW7?= =?us-ascii?Q?PJPVTSK7EGXwS8mTDmSf4w90NUnctgZIM10erkBuxeSEbWy4JweWmJ6xMe95?= =?us-ascii?Q?15ydhZM/aKmRTuBh3T2OZisYWmMqd/ynXTwyvJ/4X9iMPzQaHrw7e8XqjKxO?= =?us-ascii?Q?h9oEXQsGsMtxAcxK/PBuBVeFuyPM/5Z68i3DPK8Yv6Bn1kyA73BpPTOI0vjd?= =?us-ascii?Q?8SUXSGzrrkFGzRhOtn0DFfTqlsPO5D0ddeES2/PbUhE8rdmeKetw+QnLU9Cg?= =?us-ascii?Q?/N4Zf3yihGCxBGq8SOpPILUO1cobmjAtvOd357WLUSXKCU2Gmb40n7dFMi+M?= =?us-ascii?Q?F1b8zHlNmdrKYQYQenS/+7hknKgY2lf40Xl5ZMr2Ac7DrziVlZ3YOhnRBLtb?= =?us-ascii?Q?cqVmGTVugQ32bUqq6dxhFYW00OnmRK+vGk1yiX4I2izGbAFhMFBm5DGwI/2f?= =?us-ascii?Q?RRwCPHh3XyzRA=3D=3D?= X-Microsoft-Antispam-Message-Info: aXE0mo8VpDp2xUmcPIsRzMk+SMAWzfwpn2rAdma/rV3GKYvtnzWkBIzZxqVLUFjRXar9qT1pDNkPbiMDX8GCuSNLbu89NPdg3dba2YfG9UKjTmfuImD/Vh3iGMpPRfoluhxMpAdGWmehHy/qULpMdj16lot64+cYdchnjunIZ8aDymbftUp1geGlATex7X6v X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 6:bsp19LJlRR1YodwsA2/rkHbxYS6YSVb/C7IpotA0Pt/xq1cjLq8gkTO3r4Ad0oa6fgtRVL8b3ctifs/YSA0Zv1hVkAVsClYdghManESwDRIf9gFMqRDvn8BOO4Cam6GoRQmrFigL1ziz0blA6ECGkTkPSCMC9RrS/M4ADVXUaq3QcvpD/qJyHbRJAPBrecSRp9dLwqtrEazV3shBi/fWCFdTGlNWPch3Zh3DpomJOobY9vfiyKm37RpZnKgz3Wd8gDXXOkDb/mVzWXG8t6YLVtho0QeY60YQub0kH6J8Je3EKiXXi64MxM9+2y4tgLj8C5jer6jKeRXt3DWkbj4A5af/E4lTzb4fdYKOwtoX3pAUOTHgJS6i75t6QaRrD6nKRvdaFFkUD73ahCMN4JqBwswhtYiEu39ZEGY/AFLeDDZUNM1KSFET/i6AwVT8TvpMeiTGjYx2kYkkaP4ox9KY6g==; 5:o4KVylOyISJkqy4zATxqyY9r8ggRQtmA6cqSdmKK71zadowCSONnDCdjDshBXdGbPTxkS3Y8hLAKgANPfEmQZjbQUQaREJLV7vhJ5Zpi9J8W76jKKzvBcUohBhh523kgAf//SrI8/nhsQCQ93l9CYDLTBb81zycbNdhEVS45Z5w=; 24:0qLkJc9hUJguG71HDQd+9AEaTax76w6QTYW7UacKuRsMw/HKNSNjY/4cJQcEXS5z7kk5+ndI3EOIaVCx6anlRiphijoxbdt4fC48SEmnbD0= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; CO2PR07MB2519; 7:rsKNGNYr7ISLgA1JpyCFtIKCkUDRuEsrRlpOkiaSCt47AzjhdlVNBLmHJL/0bnGLBSby6wEfilfbWFwZxMUx4LXiDMeKK7tgiaARlq23fbdM8MOlUZdiMunPkcdv8TZDYB66xCKpBHOVkUwEv6VyDyxKg4whOTbpnhVKSf4JmSbuftx5vC/0yzntSAe5uaMZJ5HrlGUlEn0LpuDVZ/3TXQfJq0xm/lFqjT06ciceqPkk6zdtOH6DuT7MIKSDRt1A X-MS-Office365-Filtering-Correlation-Id: 21b9a6fd-63a0-4c09-489d-08d5a080a2a4 X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2018 14:21:06.8351 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 21b9a6fd-63a0-4c09-489d-08d5a080a2a4 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO2PR07MB2519 Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: adding event queue support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 12 Apr 2018 14:21:11 -0000 -----Original Message----- > Date: Thu, 12 Apr 2018 15:03:22 +0100 > From: Bruce Richardson > To: Sunil Kumar Kori > CC: "dev@dpdk.org" , Hemant Agrawal > Subject: Re: [dpdk-dev] [PATCH] examples/l3fwd: adding event queue support > User-Agent: Mutt/1.9.4 (2018-02-28) > > On Thu, Apr 12, 2018 at 06:09:04AM +0000, Sunil Kumar Kori wrote: > > Gentle reminder to review the RFC. > > > > Regards > > Sunil Kumar > > > > Hi, > > sorry for the delay in review. > > /Bruce > > > -----Original Message----- > > From: Sunil Kumar Kori [mailto:sunil.kori@nxp.com] > > Sent: Monday, March 19, 2018 7:15 PM > > To: dev@dpdk.org > > Cc: Sunil Kumar Kori ; Hemant Agrawal > > Subject: [PATCH] examples/l3fwd: adding event queue support > > > > This patch set to add the support for eventdev based queue mode support to the l3fwd application. > > 1. Eventdev support with parallel queue > > 2. Eventdev support with atomic queue > > > > This patch adds > > - New command line parameter is added named as "dequeue-mode" which > > identifies dequeue method i.e. dequeue via eventdev or polling > > (default is polling) > > . If dequeue mode is via: > > a. eventdev: New parameters are added -e, -a, -l to cater > > eventdev config, adapter config and link configuration > > respectively. "--config" option will be invalid in this case. > > b. poll mode: It will work as of existing way and option for > > eventdev parameters(-e, -a, -l) will be invalid. > > > > - Functions are added in l3fwd_em.c and l3fwd_lpm.c for packet I/O > > operation > > > > The main purpose of this RFC is get comments on the approach. > > This is a *not tested* code. > > > > Signed-off-by: Sunil Kumar Kori > > --- > > examples/l3fwd/Makefile | 2 +- > > examples/l3fwd/l3fwd.h | 21 ++ > > examples/l3fwd/l3fwd_em.c | 100 ++++++++ > > examples/l3fwd/l3fwd_eventdev.c | 541 ++++++++++++++++++++++++++++++++++++++++ > > examples/l3fwd/l3fwd_eventdev.h | 85 +++++++ > > examples/l3fwd/l3fwd_lpm.c | 100 ++++++++ > > examples/l3fwd/main.c | 318 +++++++++++++++++++---- > > examples/l3fwd/meson.build | 2 +- > > 8 files changed, 1120 insertions(+), 49 deletions(-) create mode 100644 examples/l3fwd/l3fwd_eventdev.c create mode 100644 examples/l3fwd/l3fwd_eventdev.h > > > > My initial impression is that this seems like an awful lot of new code just > to support reading from an eventdev rather than from an ethdev. Looking at > the datapath main function loop, is the only difference there that > rte_eth_rx_burst has been changed to rte_eventdev_dequeue_burst or are > there more significant changes than that? > > If this is the case, is this scale of changes really needed to this app? > What about the other examples, how many of them will need to be similarly > updated? > > I'm also wondering if it would help, or be useful, to have a vdev type > which wraps an eventdev queue as an ethdev. That would eliminate the need > for the datapath code, and may help abstract away some parts of the setup. > It would also help with re-use if you anticipate wanting to make a similar > change to other apps. Exposing as an ethdev-vdev device will introduce cyclic build dependency(now eventdev is depended on ethdev). I think, maybe a helper function in eventdev area to setup Rx adapter and similar slow path logic may work. > > /Bruce >