From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 409EB1C676; Fri, 13 Apr 2018 17:43:02 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Apr 2018 08:43:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,446,1517904000"; d="scan'208";a="33165103" Received: from dekblom-mobl.ger.corp.intel.com ([10.252.21.150]) by orsmga007.jf.intel.com with SMTP; 13 Apr 2018 08:42:58 -0700 Received: by (sSMTP sendmail emulation); Fri, 13 Apr 2018 16:42:54 +0100 Date: Fri, 13 Apr 2018 16:42:54 +0100 From: Bruce Richardson To: Hemant Agrawal Cc: "herbert.guan@arm.com" , Shreyansh Jain , "dev@dpdk.org" , "pbhagavatula@caviumnetworks.com" , "stable@dpdk.org" , "jerin.jacob@caviumnetworks.com" Message-ID: <20180413154253.GA37024@bricha3-MOBL.ger.corp.intel.com> References: <20180409143946.21607-1-jerin.jacob@caviumnetworks.com> <20180410141648.GA164988@bricha3-MOBL.ger.corp.intel.com> <59AF69C657FD0841A61C55336867B5B072275DC5@IRSMSX103.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] build: fix default arm64 build instruction level support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 15:43:03 -0000 On Wed, Apr 11, 2018 at 12:30:07PM +0530, Hemant Agrawal wrote: > > > On 4/10/2018 7:49 PM, Richardson, Bruce wrote: > > Resend, fixing "To" recipients. > > > > > -----Original Message----- > > > From: Bruce Richardson [mailto:bruce.richardson@intel.com] > > > Sent: Tuesday, April 10, 2018 3:17 PM > > > To: Jerin Jacob > > > Cc: dev@dpdk.org; herbert.guan@arm.com; pbhagavatula@caviumnetworks.com; > > > hemant.agrawal@nxp.com; stable@dpdk.org; jerin.jacob@caviumnetworks.com > > > Subject: Re: [dpdk-dev] [PATCH] build: fix default arm64 build instruction > > > level support > > > > > > On Mon, Apr 09, 2018 at 08:09:46PM +0530, Jerin Jacob wrote: > > > > The make based build system has crc+crypto instruction support for the > > > > default arm64 build. > > > > http://dpdk.org/browse/dpdk/tree/mk/machine/armv8a/rte.vars.mk#n31 > > > > > > > > This patch fixes the disparity with meson build flags for armv8. > > > > As a bonus, This patch fixes the following errors with ip_pipeline > > > > example application. > > > > > > > > Assembler messages: > > > > Error: selected processor does not support `crc32cx w3,w3,x0' > > > > > > > > Fixes: c6e536e38437 ("build: add more implementers IDs and PNs for > > > > ARM") > > > > > > > > Cc: herbert.guan@arm.com > > > > Cc: pbhagavatula@caviumnetworks.com > > > > Cc: bruce.richardson@intel.com > > > > Cc: hemant.agrawal@nxp.com > > > > Cc: stable@dpdk.org > > > > > > > > Signed-off-by: Jerin Jacob > > > > --- > > > > > > Hemant, Shreyansh, Herbert, > > > > > > any issues with this patch on your side? Can one of you please ack it. It > > > allows use of "-Dexamples=all" when doing cross-builds for all the > > > different arm targets in the config dir. Without it, ip_pipeline fails to > > > build for many of the targets. > > > > > > /Bruce > > > Acked-by: Hemant Agrawal Applied to dpdk-next-build. Thanks, /Bruce