From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f182.google.com (mail-wr0-f182.google.com [209.85.128.182]) by dpdk.org (Postfix) with ESMTP id 756031B1CB for ; Mon, 16 Apr 2018 10:08:52 +0200 (CEST) Received: by mail-wr0-f182.google.com with SMTP id v24so6194171wra.8 for ; Mon, 16 Apr 2018 01:08:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=AZ7wuL6/ouVFYz5+q4DsnTUxsyAj3lRiRJct+TCzJDk=; b=bkY/Sf+k7BWX/J/22qDzEi/mw0DMy/GRcwMUv143kquUf0urZLOgBwcfBwx14ZJLTl 8qkmcthmxQIZJPDIa19LZNmVwBvfjNI2eDfUoQ9jVv8oLj7g6LXm2fnHFqETfFqlbaiV dXYzrsv/jS2Z+/SnDiAJgOsnY1ULF2Iasa9C56kMdPVWr7KzmWnqYMFe84BMW9np5q6U 6MIDRqP8Q3lslMyqwPS5JzS2fSHu1SYZg0Fwbv0MwrAYGz3yZQx0OyKuEH6Ms1qn3AjM cv8nsSeSPwZOdJRUYj1y7LJITKlBEGam5Mex2T0Qs0zWPTcEzxbR4q7e2COAKO5jS1Cn 4I/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=AZ7wuL6/ouVFYz5+q4DsnTUxsyAj3lRiRJct+TCzJDk=; b=JVGxiyp9JqNzK5//XYwswMUsxYFeQTrz51x/MKjrAGDtqgtD3JZHeuuLeFEjhx6YwE jdpo+cT+PUz1jNDFIhBsArFDV+GkmQvuWki9dWGN+Fv/JUdaOsjIJzj3CxqIOAF8N5ka rTNoJyL6+DklwDN8nchRC2Ig+Q8agV/EfzE3cEPzBZ8LsHIWKI3Ea30bzIw7Nv7XuXju oZnR6uZJqaTUE0iWbZvxlLRkSEQkGvMt9WwWYcu2DHpIQRjmYXCn7CBueENYECwkFUCp TiJMMy+Fd3yb4y1wNXa6z1URPTS+50WaCQO0gRwEb9M3fSHy2ubdXwIWBsaRc7cq1Wy2 PNuQ== X-Gm-Message-State: ALQs6tDpQpCchcxj9KE3rYfwWafzaHCrF4+FtF0qQSo0MS6wjhOEMdBZ K3MVnZr+BjrCAwdUITItBvn7 X-Google-Smtp-Source: AIpwx4/feB55KDECv9lQbWI3ou5ZtRvVER6xlQ6WkLCnnrZzQNNwL+4kh3d/IPTynFOa3nx75Gpkxg== X-Received: by 10.223.149.68 with SMTP id 62mr9026443wrs.201.1523866132234; Mon, 16 Apr 2018 01:08:52 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id q81sm9557789wmg.8.2018.04.16.01.08.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 16 Apr 2018 01:08:51 -0700 (PDT) Date: Mon, 16 Apr 2018 10:09:22 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: "Xueming(Steven) Li" Cc: Shahaf Shuler , "dev@dpdk.org" Message-ID: <20180416080922.g7os2gjwod7h2ecp@laranjeiro-vm.dev.6wind.com> References: <20180410133415.189905-1-xuemingl@mellanox.com> <20180410133415.189905-8-xuemingl@mellanox.com> <20180411085529.ecxuku77hg3mkybl@laranjeiro-vm.dev.6wind.com> <20180416071409.oee2ttblbrg46yc6@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v2 07/15] net/mlx5: support tunnel RSS level X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 08:08:52 -0000 On Mon, Apr 16, 2018 at 07:46:08AM +0000, Xueming(Steven) Li wrote: >[...] > > > > > @@ -1386,6 +1386,8 @@ mlx5_ind_table_ibv_verify(struct rte_eth_dev > > *dev) > > > > > * Number of queues. > > > > > * @param tunnel > > > > > * Tunnel type. > > > > > + * @param rss_level > > > > > + * RSS hash on tunnel level. > > > > > * > > > > > * @return > > > > > * The Verbs object initialised, NULL otherwise and rte_errno is > > set. > > > > > @@ -1394,13 +1396,17 @@ struct mlx5_hrxq * mlx5_hrxq_new(struct > > > > > rte_eth_dev *dev, > > > > > const uint8_t *rss_key, uint32_t rss_key_len, > > > > > uint64_t hash_fields, > > > > > - const uint16_t *queues, uint32_t queues_n, uint32_t > > tunnel) > > > > > + const uint16_t *queues, uint32_t queues_n, > > > > > + uint32_t tunnel, uint32_t rss_level) > > > > > > > > tunnel and rss_level seems to be redundant here. > > > > > > > > rss_level > 1 is equivalent to tunnel, there is no need to have both. > > > > > > There is a case of tunnel and outer rss(1). > > > > Why cannot it be handled by a regular Hash Rx queue, i.e. what is the > > benefit of creating a tunnel hash Rx queue to make the same job as a > > legacy one? > > Tunnel checksum, ptype and rss offloading demand a QP to be created by DV api with > tunnel offload flags. I was expecting such answer, such information should be present in the function documentation, can you add it? Thanks, -- Nélio Laranjeiro 6WIND