From: Fan Zhang <roy.fan.zhang@intel.com>
To: dev@dpdk.org
Cc: cristian.dumitrescu@intel.com, jasvinder.singh@intel.com
Subject: [dpdk-dev] [PATCH] examples/ip_pipeline: fix uninitialized scalar variable
Date: Mon, 16 Apr 2018 11:47:51 +0100 [thread overview]
Message-ID: <20180416104751.65646-1-roy.fan.zhang@intel.com> (raw)
Coverity issue: 272575
Fixes: 133c2c6565d6 ("examples/ip_pipeline: add link object")
Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
---
examples/ip_pipeline/cli.c | 2 +-
examples/ip_pipeline/link.c | 8 +++++---
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/examples/ip_pipeline/cli.c b/examples/ip_pipeline/cli.c
index 199a31ff8..ec43a2308 100644
--- a/examples/ip_pipeline/cli.c
+++ b/examples/ip_pipeline/cli.c
@@ -133,7 +133,7 @@ cmd_link(char **tokens,
char *out,
size_t out_size)
{
- struct link_params p;
+ struct link_params p = {0};
struct link_params_rss rss;
struct link *link;
char *name;
diff --git a/examples/ip_pipeline/link.c b/examples/ip_pipeline/link.c
index 26ff41ba9..25717808c 100644
--- a/examples/ip_pipeline/link.c
+++ b/examples/ip_pipeline/link.c
@@ -121,17 +121,19 @@ link_create(const char *name, struct link_params *params)
(params->tx.queue_size == 0))
return NULL;
- port_id = params->port_id;
if (params->dev_name) {
status = rte_eth_dev_get_port_by_name(params->dev_name,
&port_id);
if (status)
return NULL;
- } else
- if (!rte_eth_dev_is_valid_port(port_id))
+ } else {
+ if (!rte_eth_dev_is_valid_port(params->port_id))
return NULL;
+ port_id = params->port_id;
+ }
+
rte_eth_dev_info_get(port_id, &port_info);
mempool = mempool_find(params->rx.mempool_name);
--
2.13.6
next reply other threads:[~2018-04-16 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-16 10:47 Fan Zhang [this message]
2018-04-20 14:39 ` [dpdk-dev] [PATCH v2] " Fan Zhang
2018-04-23 9:04 ` Singh, Jasvinder
2018-05-08 14:28 ` [dpdk-dev] [PATCH] " Dumitrescu, Cristian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180416104751.65646-1-roy.fan.zhang@intel.com \
--to=roy.fan.zhang@intel.com \
--cc=cristian.dumitrescu@intel.com \
--cc=dev@dpdk.org \
--cc=jasvinder.singh@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).