From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 113856D81 for ; Mon, 16 Apr 2018 15:17:46 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Apr 2018 06:17:45 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,459,1517904000"; d="scan'208";a="220783516" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga005.fm.intel.com with SMTP; 16 Apr 2018 06:17:43 -0700 Received: by (sSMTP sendmail emulation); Mon, 16 Apr 2018 14:17:42 +0100 Date: Mon, 16 Apr 2018 14:17:42 +0100 From: Bruce Richardson To: Fan Zhang Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, jasvinder.singh@intel.com Message-ID: <20180416131741.GA61692@bricha3-MOBL.ger.corp.intel.com> References: <20180416110233.66450-1-roy.fan.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180416110233.66450-1-roy.fan.zhang@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix buffer not null terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 13:17:47 -0000 On Mon, Apr 16, 2018 at 12:02:33PM +0100, Fan Zhang wrote: > Coverity issue: 272572 > Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") > > Signed-off-by: Fan Zhang > --- > examples/ip_pipeline/action.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c > index 77a04fe19..91011ebe8 100644 > --- a/examples/ip_pipeline/action.c > +++ b/examples/ip_pipeline/action.c > @@ -133,7 +133,7 @@ port_in_action_profile_create(const char *name, > } > > /* Node fill in */ > - strncpy(profile->name, name, sizeof(profile->name)); > + strncpy(profile->name, name, sizeof(profile->name) - 1); > memcpy(&profile->params, params, sizeof(*params)); > profile->ap = ap; No, this still doesn't null terminate, and is a perfect example of why we should never use strncpy! Use strlcpy instead.