From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 7B13CAADE for ; Mon, 16 Apr 2018 18:22:03 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id s18so27684715wrg.9 for ; Mon, 16 Apr 2018 09:22:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=gzmTCkkDm0b56zvu0zwD6WSAeMriY3WaDIv8uSXdFBQ=; b=gSnHyxW3yxcUYx8i43sJ5uxpWK1EwiDR1VvCKpPSv7WsCT7HY9z6AhgJfW5dMrjZUg Pmb7RmHP7tjbCXoupHMlC8rhUPVDhszCRw3t/SoGodTn46B6OQ1ikRTe6vp4vldzoyTg kisGW2t46QI7+5Qimz0mP5Te/N8/Ya0XoYLZrFjCRcDhyYCuMH+YbAkgmtFnEFonbq2g 725FNw1BGeD6oPNbWELCHXWe3HAIrQT6iluqLhKPCy5kcxeUXu5Yj7eP12jboaO443f9 ZihI704n8T4xraUt2Yycw6Uge9GCJ0EZ76BTsgChh2+oLbUlx0dp4fTYoVRBuEu4QFDH VgJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=gzmTCkkDm0b56zvu0zwD6WSAeMriY3WaDIv8uSXdFBQ=; b=gTjCd9BEt3lr+K5jutQnXrthkpO9rNSPusx+3k+rctqAdlEHy5nQoKFIJIBokh+ZKJ BlHSWtCuj/uaiS1h/mxcYHRkU1tmUFbSjwegZfdwJKtHhTGvdpn6Tr2LZPwq1UDiu8AC LUdgpEaj31dkl7Oy+hCOHbW19JNo+kdrEqqRN2pvzrZ1/LCN6UWJIvYm6uLhRsIk+ZVE 3gGCwM336hSdce9Q9s28BKsP29fOx1JgYMBJKHHflNUzmsTt21QvQgI9JMW2qo1hDz2Z LcjSElxgRo5TKupLqiKGz+ynWQ8dgJaqUzK4dxO6i6/RDIUkjAuRdyVDFcK+xmbU9hug cDAA== X-Gm-Message-State: ALQs6tANBshNtqQAMirT7vpH120WkfkZy8Cn0kdBC6YAIpuJcRZWjfKB lqcqEuyRfn+6uV07y6gqa/CF2TzI X-Google-Smtp-Source: AIpwx4+p+DUKqLXsOeTRxTA5sDHsdjq5E5RSz88Wm27kYM/GnMHLPV3VL0GjE/kGbJmYVKPBBZg6gg== X-Received: by 10.223.195.98 with SMTP id e31mr3251402wrg.257.1523895722450; Mon, 16 Apr 2018 09:22:02 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id e11sm10293976wma.4.2018.04.16.09.22.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Apr 2018 09:22:01 -0700 (PDT) Date: Mon, 16 Apr 2018 18:21:48 +0200 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Shahaf Shuler Message-ID: <20180416150058.2620-2-adrien.mazarguil@6wind.com> References: <20180410161132.8776-1-adrien.mazarguil@6wind.com> <20180416150058.2620-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180416150058.2620-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v5 01/11] net/mlx4: fix RSS resource leak in case of error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Apr 2018 16:22:03 -0000 When memory cannot be allocated for a flow rule, its RSS context reference is not dropped. Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") Cc: stable@dpdk.org Signed-off-by: Adrien Mazarguil Cc: Shahaf Shuler --- drivers/net/mlx4/mlx4_flow.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c index f3063ee8a..2b4bf7094 100644 --- a/drivers/net/mlx4/mlx4_flow.c +++ b/drivers/net/mlx4/mlx4_flow.c @@ -820,11 +820,14 @@ mlx4_flow_prepare(struct priv *priv, }, }; - if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) + if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) { + if (temp.rss) + mlx4_rss_put(temp.rss); return rte_flow_error_set (error, -rte_errno, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, "flow rule handle allocation failure"); + } /* Most fields will be updated by second pass. */ *flow = (struct rte_flow){ .ibv_attr = temp.ibv_attr, -- 2.11.0