From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 68EB8A490 for ; Tue, 17 Apr 2018 11:17:52 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id l49so33396501wrl.4 for ; Tue, 17 Apr 2018 02:17:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=vr0n4KakZSuFuLdN2Z32awO1pBQAexcenWiW9qUg1ls=; b=ZY+TKx5zg3hKYCbpxCEAY4ZQiyg75ac+kYYs8+j6t8BBd0GRL/H+Q5gRukd30nuEZz 3Ltpjd92I0YUOyJZ4z7+WDVdtyAOQE5pwTr1xNZcU4CgbAYtf3WzgEfWqQyR2yMgMpzL ujvOXDio3rlPdLy8nWkjT7X/KLRAFkTHf/zhCyANtA9klopKy5fg1qZhzfFXokM1W00q W7gVBr+5rVg3FZZiyn9H4mzTmQKf7iOuYASJIu3w5XjFTbW7+vwuPBsPDRKiKyA9uPrU 900LZ6k4BZr82Djqs/KM+8GXQygLuf9qtLaoTNxZmUIwyuZPDQTNYa29oFeQqi9aLP0g 6Q5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=vr0n4KakZSuFuLdN2Z32awO1pBQAexcenWiW9qUg1ls=; b=a609gLbmo/ztgpHqaus+DWVyCHVBy4f125XJtkLBBCsQsyWZVNXpEEBLAbVLge/aYe MROP0kU8R+T+K/9hmkfShmHEiFQnHLLKTmYmzXvP3gW0Z1VvgC0ZdwEFvbYVeLW59zvm nQ47OBdR99lNLM+n64uQSDK6ziJXK1VkLAVTPjZNWbKs8rSEHz2Iem+HJ6z+VCGSTK3d rgHf2flovXMIizVRoELigbnupeJhrzhnsqcNi2QiY9uRdmuNHS7jy7CGS0YsTnpV7Ag5 B81R/lpL/63oZLUSasK6+prUqXWm7wvYSjUTadOqIefMoX/+50Dk4GTvEWPsAfaha/IJ Va7g== X-Gm-Message-State: ALQs6tDkEIsCjNHyicZb8OsS2gPtroAZxgbtHlndzKkpAid69SquyGdu 5BXCBG555fIOYowh2xoqGtAC X-Google-Smtp-Source: AIpwx4+155aZ80sl9dB0UHAWSnEcTFdk5rTMxRpjnmnHw6EHFR3CV3+y9Du07IKqNsoQQcdRRGZoFg== X-Received: by 10.223.153.37 with SMTP id x34mr1029945wrb.29.1523956672241; Tue, 17 Apr 2018 02:17:52 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id g75sm14161208wmc.47.2018.04.17.02.17.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 02:17:51 -0700 (PDT) Date: Tue, 17 Apr 2018 11:18:24 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org, Gaetan Rivet , Thomas Monjalon Message-ID: <20180417091824.tj4rpoin4otusrvq@laranjeiro-vm.dev.6wind.com> References: <20180410161132.8776-1-adrien.mazarguil@6wind.com> <20180416150058.2620-1-adrien.mazarguil@6wind.com> <20180416150058.2620-10-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180416150058.2620-10-adrien.mazarguil@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v5 09/11] ethdev: fix shallow copy of flow API RSS action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 09:17:52 -0000 On Mon, Apr 16, 2018 at 06:22:03PM +0200, Adrien Mazarguil wrote: > The rss_conf field is defined as a pointer to struct rte_eth_rss_conf. > > Even assuming it is permanently allocated and a pointer copy is safe, > pointed data may change and not reflect an applied flow rule anymore. > > This patch aligns with testpmd by making a deep copy instead. > > Fixes: 18da437b5f63 ("ethdev: add flow rule copy function") > Cc: stable@dpdk.org > Cc: Gaetan Rivet > > Signed-off-by: Adrien Mazarguil > Cc: Thomas Monjalon Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND