From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 16C01A491 for ; Tue, 17 Apr 2018 11:19:08 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id q6so21326509wrd.6 for ; Tue, 17 Apr 2018 02:19:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=LNYFlpg2LuuVwGMnrMQc3fG90RLTRhaGHwsHujfqWD4=; b=KwBKUGTWC9idQOlf2//1lwy45uRh7f1vdJSYxKEW9LLNaSSDHt4NWQMopk0lQGjCw0 DbzD1vhy/qlwlRRF/YZtX9zQaHK0nCkaZKp2Bkj4+pip/plHqc+PK+jrj7Jm4N5xhzWk bjx0QzeDuX09Tsjjtpm6HW/393JcawXkc09DYnBjnGgr6Ug3MkuTmkqR2HS1Ifuljy/h BuFOa6bjLDldZprgmT1lpc74IHPvtoYOlNse+/dB9EXwdg5CV9JiQL/KmHlYTbhTHxhV oUawt5chPhdgTthV/SJWsh3uFdNVwrR7zr4EQgyKG5xREU8CVkChyewkz42t5XXBg7ly HW+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=LNYFlpg2LuuVwGMnrMQc3fG90RLTRhaGHwsHujfqWD4=; b=ZQqyCnDSP7Fk44wQy17lFHK9f/fgd4IiRVhzIkpOmhYMzE25XaX7dl+8Jjmg4TEI8J R692TJZUhbIezgx79isQFA1hZ2tHne5oS6Sfil++n8z8nxZi6xi4/0Mo/hUygTOMcj8T 9ud7f1SEfw/lsHgzvl690t7Tt3r0PV78wvdfXOVp/S9fesEdrtv0nIGAs2gepSIrA0uO 4Qt55r+zWUl2khRsel0OIfWM7ABjtIvNh9TgKLyrFGgowqMupv9H8HKKcHdiGI0LodsX weJWjXZZuKq4LXI6fh/NdHa9f99LVJ+KvaUXO57MeFo3CJgh4ItHgj3YzolK9YPaPUca M6Eg== X-Gm-Message-State: ALQs6tDWszKHEtO2La8GAwp/mIcvxSS18P0CNV9SeKnu9SujrBl44qhf 8b/T6LtQTNMwz+2UMdp/NWwJ X-Google-Smtp-Source: AIpwx48cCsM7hz5qvPzaqLmd/ybJjhR46H7v8Ntp9tYlpH7ZwF3TTHyTihWC8wC7om4URDSBWlm9KQ== X-Received: by 10.223.184.56 with SMTP id h53mr1024048wrf.87.1523956747896; Tue, 17 Apr 2018 02:19:07 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id k184sm10717436wmk.21.2018.04.17.02.19.07 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 02:19:07 -0700 (PDT) Date: Tue, 17 Apr 2018 11:19:40 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org, Shahaf Shuler Message-ID: <20180417091940.fe5k5arwzwsgenr7@laranjeiro-vm.dev.6wind.com> References: <20180410161132.8776-1-adrien.mazarguil@6wind.com> <20180416150058.2620-1-adrien.mazarguil@6wind.com> <20180416150058.2620-2-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180416150058.2620-2-adrien.mazarguil@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v5 01/11] net/mlx4: fix RSS resource leak in case of error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 09:19:08 -0000 On Mon, Apr 16, 2018 at 06:21:48PM +0200, Adrien Mazarguil wrote: > When memory cannot be allocated for a flow rule, its RSS context reference > is not dropped. > > Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") > Cc: stable@dpdk.org > > Signed-off-by: Adrien Mazarguil > Cc: Shahaf Shuler Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx4/mlx4_flow.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c > index f3063ee8a..2b4bf7094 100644 > --- a/drivers/net/mlx4/mlx4_flow.c > +++ b/drivers/net/mlx4/mlx4_flow.c > @@ -820,11 +820,14 @@ mlx4_flow_prepare(struct priv *priv, > }, > }; > > - if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) > + if (!mlx4_zmallocv(__func__, vec, RTE_DIM(vec))) { > + if (temp.rss) > + mlx4_rss_put(temp.rss); > return rte_flow_error_set > (error, -rte_errno, > RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, > "flow rule handle allocation failure"); > + } > /* Most fields will be updated by second pass. */ > *flow = (struct rte_flow){ > .ibv_attr = temp.ibv_attr, > -- > 2.11.0 -- Nélio Laranjeiro 6WIND