From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 221F4A495 for ; Tue, 17 Apr 2018 11:19:43 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id q6so21331616wrd.6 for ; Tue, 17 Apr 2018 02:19:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=JoV5CkP+iJ3GWj1DX01OiVMFb3JmXrmqnOKcMy0SME0=; b=MVLrx6dzOnajNGey43v0hVISFstnsMePlgon+mSkyWOllpCEZOwrJo1lSelsGGnPeT wbA1ncxI5jfTnSCuUfY+1iWjWlhxSfwJQeuEzsbC8jwzJBxCi7233hZ1tl/WOgID19vF 6nxXPVXVUX03G3aI7zwjExqZrBpeuQIyt8cq6Dbv+okrlH7md+YiwTWnGZDvkSJ+2xw6 0LQjq4X4mAOOIsA/n/Cwaali6JHrfDu85BDNIzlXp1nrk+IvwQOmaqf7Jzv3fLH1SuqA vGJ6kRGGhqB91SEy6fpWVHvnVR108v7LQGcnobo9KnIU3/bQ4CF1BJo2La1WwHYt1l4i rPNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=JoV5CkP+iJ3GWj1DX01OiVMFb3JmXrmqnOKcMy0SME0=; b=Z5JSa4hvX8DcEt/NDS4FtAmAoNMbQwixjMnKiZDULCod9go0u6bJVaoORbkvwPWAmu Cg/1MAHJ6Ym8Ya8jircjzEtWKBH2UhAsEZpUf6yIOVSDTktTv/+Ts8P+rERXpaOrxjnp 7tIRhjTV15jujOphHwhOFg5ObZb2LIgqH7+/0eNeoGLTU7rGSki/JcBDp6rmAMwZRs0u fC4AiON+9rrajSwFt8PdMPGNImmF0UVEPHuK904JG6M/0k/IklTIaE8ZgnTy3sgrnWMb sS6RRjhQE1s4dBfv8FLdbSStzNdnPtZGIL/uRo6AmgBYyv+Ckcg9ZrEq858LuRsp62sC BXlw== X-Gm-Message-State: ALQs6tD4jiP5XyVmxYCRCkYOPwN89hrFHB0Db+kN1C06u120lHNxpEXK W/vacW32kcewfljasaEBfxe5dhNhUg== X-Google-Smtp-Source: AIpwx49mNqQjRCkDc4OMFt6pA68/kHaDfXvYU5Pb9ItVVrqI0HNC2CBhFLdEvpFTz4K2XI/kRzaqrw== X-Received: by 10.28.58.147 with SMTP id h141mr384181wma.67.1523956782883; Tue, 17 Apr 2018 02:19:42 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y191sm14939203wme.14.2018.04.17.02.19.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 02:19:42 -0700 (PDT) Date: Tue, 17 Apr 2018 11:20:15 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Adrien Mazarguil Cc: dev@dpdk.org, stable@dpdk.org, Shahaf Shuler Message-ID: <20180417092015.bbrox7yp32rn7m2w@laranjeiro-vm.dev.6wind.com> References: <20180410161132.8776-1-adrien.mazarguil@6wind.com> <20180416150058.2620-1-adrien.mazarguil@6wind.com> <20180416150058.2620-3-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180416150058.2620-3-adrien.mazarguil@6wind.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v5 02/11] net/mlx4: fix ignored RSS hash types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 09:19:43 -0000 On Mon, Apr 16, 2018 at 06:21:50PM +0200, Adrien Mazarguil wrote: > When an unsupported hash type is part of a RSS configuration structure, it > is silently ignored instead of triggering an error. This may lead > applications to assume that such types are accepted, while they are in fact > not part of the resulting flow rules. > > Fixes: 078b8b452e6b ("net/mlx4: add RSS flow rule action support") > Cc: stable@dpdk.org > > Signed-off-by: Adrien Mazarguil > Cc: Shahaf Shuler Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx4/mlx4_flow.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/mlx4/mlx4_flow.c b/drivers/net/mlx4/mlx4_flow.c > index 2b4bf7094..67fd568bc 100644 > --- a/drivers/net/mlx4/mlx4_flow.c > +++ b/drivers/net/mlx4/mlx4_flow.c > @@ -706,6 +706,7 @@ mlx4_flow_prepare(struct priv *priv, > const struct rte_flow_action_queue *queue; > const struct rte_flow_action_rss *rss; > const struct rte_eth_rss_conf *rss_conf; > + uint64_t fields; > unsigned int i; > > case RTE_FLOW_ACTION_TYPE_VOID: > @@ -780,10 +781,15 @@ mlx4_flow_prepare(struct priv *priv, > " of the context size"; > goto exit_action_not_supported; > } > + rte_errno = 0; > + fields = mlx4_conv_rss_hf(priv, rss_conf->rss_hf); > + if (fields == (uint64_t)-1 && rte_errno) { > + msg = "unsupported RSS hash type requested"; > + goto exit_action_not_supported; > + } > flow->rss = mlx4_rss_get > - (priv, > - mlx4_conv_rss_hf(priv, rss_conf->rss_hf), > - rss_conf->rss_key, rss->num, rss->queue); > + (priv, fields, rss_conf->rss_key, rss->num, > + rss->queue); > if (!flow->rss) { > msg = "either invalid parameters or not enough" > " resources for additional multi-queue" > -- > 2.11.0 -- Nélio Laranjeiro 6WIND