From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id C156BAAA2 for ; Tue, 17 Apr 2018 12:00:25 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 03:00:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="33215234" Received: from silpixa00398673.ir.intel.com (HELO silpixa00398673.ger.corp.intel.com) ([10.237.223.54]) by fmsmga008.fm.intel.com with ESMTP; 17 Apr 2018 03:00:23 -0700 From: Fan Zhang To: dev@dpdk.org Cc: cristian.dumitrescu@intel.com, jasvinder.singh@intel.com Date: Tue, 17 Apr 2018 10:52:52 +0100 Message-Id: <20180417095252.81275-1-roy.fan.zhang@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180416110233.66450-1-roy.fan.zhang@intel.com> References: <20180416110233.66450-1-roy.fan.zhang@intel.com> Subject: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 10:00:27 -0000 Coverity issue: 272572 Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") Signed-off-by: Fan Zhang --- v2: - use more generic strlcpy approach examples/ip_pipeline/action.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c index 77a04fe19..1203bb892 100644 --- a/examples/ip_pipeline/action.c +++ b/examples/ip_pipeline/action.c @@ -6,6 +6,8 @@ #include #include +#include + #include "action.h" #include "hash_func.h" @@ -133,7 +135,7 @@ port_in_action_profile_create(const char *name, } /* Node fill in */ - strncpy(profile->name, name, sizeof(profile->name)); + strlcpy(profile->name, name, sizeof(profile->name)); memcpy(&profile->params, params, sizeof(*params)); profile->ap = ap; -- 2.13.6