From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 083868E73 for ; Tue, 17 Apr 2018 13:18:53 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 04:18:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="32593128" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by fmsmga007.fm.intel.com with SMTP; 17 Apr 2018 04:18:50 -0700 Received: by (sSMTP sendmail emulation); Tue, 17 Apr 2018 12:18:49 +0100 Date: Tue, 17 Apr 2018 12:18:49 +0100 From: Bruce Richardson To: Fan Zhang Cc: dev@dpdk.org, cristian.dumitrescu@intel.com, jasvinder.singh@intel.com Message-ID: <20180417111849.GA82784@bricha3-MOBL.ger.corp.intel.com> References: <20180416110233.66450-1-roy.fan.zhang@intel.com> <20180417095252.81275-1-roy.fan.zhang@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180417095252.81275-1-roy.fan.zhang@intel.com> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] examples/ip_pipeline: fix buffer not null terminated X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 11:18:54 -0000 On Tue, Apr 17, 2018 at 10:52:52AM +0100, Fan Zhang wrote: > Coverity issue: 272572 > Fixes: 719374345cee ("examples/ip_pipeline: add action profile objects") > > Signed-off-by: Fan Zhang > --- > v2: > - use more generic strlcpy approach > > examples/ip_pipeline/action.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/examples/ip_pipeline/action.c b/examples/ip_pipeline/action.c > index 77a04fe19..1203bb892 100644 > --- a/examples/ip_pipeline/action.c > +++ b/examples/ip_pipeline/action.c > @@ -6,6 +6,8 @@ > #include > #include > > +#include > + > #include "action.h" > #include "hash_func.h" > > @@ -133,7 +135,7 @@ port_in_action_profile_create(const char *name, > } > > /* Node fill in */ > - strncpy(profile->name, name, sizeof(profile->name)); > + strlcpy(profile->name, name, sizeof(profile->name)); > memcpy(&profile->params, params, sizeof(*params)); > profile->ap = ap; > > Acked-by: Bruce Richardson