From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 5E70F7F1C for ; Wed, 18 Apr 2018 08:42:47 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id v60-v6so1544936wrc.7 for ; Tue, 17 Apr 2018 23:42:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Cqdse0JH6ubGC426jBwrMUX+TQY9sSrLyp/zyfgsTFU=; b=hWDPmZYv7u9j/l0ZBx5XUVtjyxXS38m1/oEc0sCP3OtcJY+31c4+z1KPM25vspYdNH I0/a65FSnkEiII5r1hMvLrO7010S68axnLIGsyGYbzqIpRaYpyq81mHux1vGndNAQl2l 2qmm04WkWiKgJYAXRkPIAuSTL2/0s0kazoJFG4OlywQ3Y90pesujD7J0oKVCVJZYUgNe +puS1B97eWTqXImdOSIQhC5GaGmzgFD+d7YlW74IjqBoFTMK1fKQBExN207knjO6IrdF ExJdegtBueOIl1bp/YCHcoxbXUUheZ5//TPr76/sr0aRDEEz7mOzvIRrfWmF2YL1Xxqi 8JIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Cqdse0JH6ubGC426jBwrMUX+TQY9sSrLyp/zyfgsTFU=; b=gyGrOXp9I+4FVqeiMpP0tFI1gcBoenQmTSGfCyw/trVyTarqSGrlVK57yQJbZtopLo 052se2U9N4FdHZQz5k+BGLwlkE+ogGMGQsA6/9xCYcoi9mb1SoKvnY7GE4vAZIjgmTXj bXRPVF5JVZQhU1I8WSjsWST6CWSWbwviHoOKmltrcs1CpGnXXH5OM1Gfd3ENTZzWHg1Q 0RJ6g3JaxN5Sxhuwqn49Ggj2QcnzczFF7Cp4sSE66DpZhuCdPEbGKXR1GohfxCKeyV/y mX5gL17oz8QcgWkzJYu15Ti+5ao+6TvjJRYbWKvHvQpEo/vk9p3pemmVNJreHwfgvvjn fqqg== X-Gm-Message-State: ALQs6tDXEd7ocNVaQ8z931uhgKUZl++0Vu7liPPGz4kraTPKoVyvjsoZ oS9eUSmuSR4Hmd5qVNYK7BqE X-Google-Smtp-Source: AIpwx491kAQ1afRJ01V7dF3xWSd10AUxPj5h+Ad+LvPpM5vkRNkJ9+Qdi06eoXIC8MVx3Yd5+8cnew== X-Received: by 10.80.184.194 with SMTP id l60mr1568430ede.5.1524033767158; Tue, 17 Apr 2018 23:42:47 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id r23sm467528edm.58.2018.04.17.23.42.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 23:42:46 -0700 (PDT) Date: Wed, 18 Apr 2018 08:43:20 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Yongseok Koh Cc: adrien.mazarguil@6wind.com, dev@dpdk.org, Anatoly Burakov Message-ID: <20180418064320.sbxv4gmuu6gwextp@laranjeiro-vm.dev.6wind.com> References: <20180417183914.10175-1-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180417183914.10175-1-yskoh@mellanox.com> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 1/2] net/mlx5: fix alignment of Memory Region X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 06:42:47 -0000 On Tue, Apr 17, 2018 at 11:39:13AM -0700, Yongseok Koh wrote: > The memory region is [start, end), so if the memseg of 'end' isn't > allocated yet, the returned memseg will have zero entries and this will > make 'end' zero (nil). > > Fixes: 718e35999c96 ("net/mlx5: use virt2memseg instead of iteration") > Cc: Anatoly Burakov > > Signed-off-by: Yongseok Koh Acked-by: Nelio Laranjeiro > --- > drivers/net/mlx5/mlx5_mr.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/mlx5/mlx5_mr.c b/drivers/net/mlx5/mlx5_mr.c > index fdf7b3e88..39bbe2481 100644 > --- a/drivers/net/mlx5/mlx5_mr.c > +++ b/drivers/net/mlx5/mlx5_mr.c > @@ -265,9 +265,7 @@ mlx5_mr_new(struct rte_eth_dev *dev, struct rte_mempool *mp) > ms = rte_mem_virt2memseg((void *)start, NULL); > if (ms != NULL) > start = RTE_ALIGN_FLOOR(start, ms->hugepage_sz); > - ms = rte_mem_virt2memseg((void *)end, NULL); > - if (ms != NULL) > - end = RTE_ALIGN_CEIL(end, ms->hugepage_sz); > + end = RTE_ALIGN_CEIL(end, ms->hugepage_sz); > > DRV_LOG(DEBUG, > "port %u mempool %p using start=%p end=%p size=%zu for memory" > -- > 2.11.0 > -- Nélio Laranjeiro 6WIND