From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 611147ED0 for ; Wed, 18 Apr 2018 08:44:45 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id d1-v6so1536580wrj.13 for ; Tue, 17 Apr 2018 23:44:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=l2vLNhZSZZP3v8WZ4yz9GOQ2Rh9WOkDyEt6g7V+z1LY=; b=n+tsg2NSNV7bYySUfS3qw8Ggn7vFdJyotxbDCmo92I0ry9wuZB9JnYnGtKPEdjEg3q BRaupZmbo0X8sXgsDjUvhNdmy245Vt3hu315rIOH9VzA3rPxEHtbzznmp7QI8XEmOvwD 1YE4/mYbGcF3eswkdYOYhlTtB8Ky//a1wQdSXh21zx4CwsFPEr2uXynzwNrG2vI6nvJP pW2K0ZpBHWm9ZS/NkmbfbQhUa+E1V7x0nnw3n9NTIkhsYOdbqaChfYRUgYr/Jpty+uT7 YigYlAirVK2fRUva6Nb9vKSooqv2ZetWRGGfs8TUfumikzLA0ybSo776rnWxeDKVeQNG ctrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=l2vLNhZSZZP3v8WZ4yz9GOQ2Rh9WOkDyEt6g7V+z1LY=; b=L/4JXgjCByccw0ni4TjhaQGzQbQFQenhJEPp0fOQGWoBBH/7kG/WyEt/LFTL62Rcxg bmk8f1wfG4Tq8y3lo6Az5GQuZ+4fESX2JnW1KdJqRqF6vivFbyBDdlRmD5zCfh6JdvdO Y+76n3mMJbjwgfmXGVcFWtvJ3zWsH3CO/57cMmIw67aOw9iGcsYNbrLxZ4ZTg043Bhqq wGVWEfLU9OC/UY4FQxJSOz9Kiwy/itVsrs0u2OiHvriC+N/5TdenbDkan+ZP6KtJ01ZD pDDf+pmGiRuk2CXuu9BHAmWM7LhF/9TvVvfSxU57TeJtEKBjPkyuYYwMb3WjdxizwTvc BAGA== X-Gm-Message-State: ALQs6tAYM+Pnh9JPUsrz/dDLW3NCQD1m1g9IbL92GEmIWLigchzl8Rfc ByUw/DvdxJteXk+2uwCcJ3Z3 X-Google-Smtp-Source: AIpwx49zXCnKBvHnA9pjl3w0C+KyXMbf1H9hssqDczdY7mF48r64g2yllUFSt756KRu+psz7sTk0Ug== X-Received: by 2002:adf:b594:: with SMTP id c20-v6mr613182wre.65.1524033885094; Tue, 17 Apr 2018 23:44:45 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 58-v6sm1613421wrv.41.2018.04.17.23.44.44 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 17 Apr 2018 23:44:44 -0700 (PDT) Date: Wed, 18 Apr 2018 08:45:19 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: Thomas Monjalon Cc: Adrien Mazarguil , dev@dpdk.org, Ferruh Yigit Message-ID: <20180418064519.ynsgr5i3xmrzulxq@laranjeiro-vm.dev.6wind.com> References: <20180410162022.9101-1-adrien.mazarguil@6wind.com> <20180416150525.2817-1-adrien.mazarguil@6wind.com> <20180416150525.2817-7-adrien.mazarguil@6wind.com> <6000733.QRpK3ykViv@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <6000733.QRpK3ykViv@xps> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 06/16] ethdev: remove C99 flexible arrays from flow API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 06:44:45 -0000 On Tue, Apr 17, 2018 at 10:18:22PM +0200, Thomas Monjalon wrote: > 16/04/2018 18:22, Adrien Mazarguil: > > This patch replaces C99-style flexible arrays in struct rte_flow_action_rss > > and struct rte_flow_item_raw with standard pointers to the same data. > > > > They proved difficult to use in the field (e.g. no possibility of static > > initialization) and unsuitable for C++ applications. > > > > Affected PMDs and examples are updated accordingly. > > > > This breaks ABI compatibility for the following public functions: > > > > - rte_flow_copy() > > - rte_flow_create() > > - rte_flow_query() > > - rte_flow_validate() > > > > Signed-off-by: Adrien Mazarguil > > --- > > app/test-pmd/cmdline_flow.c | 117 +++++++++++++++++--------------- > > app/test-pmd/config.c | 25 ++++--- > > doc/guides/prog_guide/rte_flow.rst | 18 ++--- > > drivers/net/mlx4/mlx4_flow.c | 22 +++--- > > drivers/net/mlx5/mlx5_flow.c | 20 +++--- > > examples/ipsec-secgw/ipsec.c | 17 ++--- > > lib/librte_ether/rte_flow.c | 25 ++++--- > > lib/librte_ether/rte_flow.h | 8 ++- > > 8 files changed, 135 insertions(+), 117 deletions(-) > > There are almost as much insertions as deletions. > So it's probably not a bad move. > > Acked-by: Thomas Monjalon For mlx5: Acked-by: Nelio Laranjeiro -- Nélio Laranjeiro 6WIND