From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f193.google.com (mail-wr0-f193.google.com [209.85.128.193]) by dpdk.org (Postfix) with ESMTP id 1DEBF8D3A for ; Wed, 18 Apr 2018 10:06:12 +0200 (CEST) Received: by mail-wr0-f193.google.com with SMTP id d1-v6so2151838wrj.13 for ; Wed, 18 Apr 2018 01:06:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ouMTinj3/AxzV/NQqJDEu0y49V/Ruip8TQ8kFZCxuPw=; b=Uy92Aj/oGiG+N+Zna5q6UMrqmCMcQ229jb7ITmvzTv/duMnDsRrrhlz+pGFCdg4kGf UhaJ2e+vRFN/qtWWDhqdevkztOQ8CnEgEtQCw+uUqHC/x9Q3syuFQNlPrxhvA7Kkbukd adNChy+GmzgwTQ7mup+/T5yIMVNak7oP/oO4LGxcXLsSNQb/DWMke9M0LORh5Z8F/tvz 2WtJfPM2TumkxHJru6kMe044oDOVlf84nPDqGcDIvRWJ98Qzpx0RI6LZQNtFO4rds2s0 Mxi1zOJj90+VkR6rO9SRRv2+mrRCRDjJufpbhblxM8jg7m+OhSeL/qJ7cX1EQ/Yr28UR xljw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ouMTinj3/AxzV/NQqJDEu0y49V/Ruip8TQ8kFZCxuPw=; b=j3M/2q17n7h88aU5Egrvm5Nl1fBm724mrS/j8YQZJxJjrGfEr941sAsMuXxbo4twEC si2xYM+pgK/FI3EtMoVgWbSRNOh+DW8eumwIX6zwg6yQdqlfivITBs4vn5/aFmS1mERp TDekmenwoHcWQPHX7MdQQFsjfJnnbdIXTm2v0oMjmjwhpmxTJVizmFYy1xCb7CQJHOnm dYbTi7/QDtI8u72iKYB8uBVy/Yv/dav3C+e/WhTTtWvZl6NtX3ZxKYTYVCkcm+w3xX3U dMD2lQVLjN6fbhUuRXmrpVcwG8JM0+S8584wCqj2bzDw/mBEzMZ2HmZtqJM+gNs6DmaZ bqeA== X-Gm-Message-State: ALQs6tDx1ZhF1IDTRiPGygxaZc5h5yNKGVfKltKBgKEdf3gHX76uq8w3 kZsw/T8Neuvpk+bRn7Rx69kGOA== X-Google-Smtp-Source: AIpwx48YWpNfrF7hV67SG7Jv86rP/QtOjl0JDCxi/O1nDqe6phVSwvl6etAMmpaoem8epq8P+Yb5jQ== X-Received: by 2002:adf:ab0a:: with SMTP id q10-v6mr822871wrc.239.1524038771914; Wed, 18 Apr 2018 01:06:11 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id l73sm2000970wma.10.2018.04.18.01.06.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Apr 2018 01:06:11 -0700 (PDT) Date: Wed, 18 Apr 2018 10:05:57 +0200 From: Adrien Mazarguil To: Yongseok Koh Cc: nelio.laranjeiro@6wind.com, dev@dpdk.org, Anatoly Burakov Message-ID: <20180418080557.GK4957@6wind.com> References: <20180417183914.10175-1-yskoh@mellanox.com> <20180417183914.10175-2-yskoh@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180417183914.10175-2-yskoh@mellanox.com> Subject: Re: [dpdk-dev] [PATCH 2/2] net/mlx4: fix alignment of Memory Region X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 08:06:12 -0000 On Tue, Apr 17, 2018 at 11:39:14AM -0700, Yongseok Koh wrote: > The memory region is [start, end), so if the memseg of 'end' isn't > allocated yet, the returned memseg will have zero entries and this will > make 'end' zero (nil). > > Fixes: c2fe5823224a ("net/mlx4: use virt2memseg instead of iteration") > Cc: Anatoly Burakov > > Signed-off-by: Yongseok Koh Acked-by: Adrien Mazarguil One nit in case another version is sent, please remove the unnecessary empty line in both patches, thanks. > --- > drivers/net/mlx4/mlx4_mr.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/net/mlx4/mlx4_mr.c b/drivers/net/mlx4/mlx4_mr.c > index e69b43322..f2dcbcb76 100644 > --- a/drivers/net/mlx4/mlx4_mr.c > +++ b/drivers/net/mlx4/mlx4_mr.c > @@ -144,9 +144,7 @@ mlx4_mr_get(struct priv *priv, struct rte_mempool *mp) > ms = rte_mem_virt2memseg((void *)start, NULL); > if (ms != NULL) > start = RTE_ALIGN_FLOOR(start, ms->hugepage_sz); > - ms = rte_mem_virt2memseg((void *)end, NULL); > - if (ms != NULL) > - end = RTE_ALIGN_CEIL(end, ms->hugepage_sz); > + end = RTE_ALIGN_CEIL(end, ms->hugepage_sz); > > DEBUG("mempool %p using start=%p end=%p size=%zu for MR", > (void *)mp, (void *)start, (void *)end, > -- > 2.11.0 > -- Adrien Mazarguil 6WIND