From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f170.google.com (mail-wr0-f170.google.com [209.85.128.170]) by dpdk.org (Postfix) with ESMTP id 6CD586CBB for ; Wed, 18 Apr 2018 10:51:54 +0200 (CEST) Received: by mail-wr0-f170.google.com with SMTP id d19-v6so2578839wre.1 for ; Wed, 18 Apr 2018 01:51:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=LZBPowc79WHbap2rW/3wT/2+tqrYGgB5NtkRu0Jwgzo=; b=mlmH5/JeyC2XqfA63svDDh2/hvc+R1VbL4v8UhWLx+mDsXlFOiYH/vWR+vJAKpe154 QMOPOLvMqG06u0XVRNRWLXchb55Ta6DuTnP8C7Sr4f+Cw8SxpDxbuuZXdNQSmQqauttx 2k0XinX4TgxiqDea/a5d+OlJaPSyyS6GSCMN6N16ahl9dp9qwyJEYwqtX+kZ012/GdGQ vGcrckABcNgTrgn19V1qPPxq27XrgEjFI7Ti9vnr4SD3PQ07FcEXRjAOCPe4n0oDlQ2f qjjW2qEkUpTqUnIEynAsszx7ekCKSbXnPW4ZTOOR11RupIB46OA+BxQOjm0JAkzK4Pio +50g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=LZBPowc79WHbap2rW/3wT/2+tqrYGgB5NtkRu0Jwgzo=; b=IXovd1rhmN/99OqGrO/r0PgvMhpcyo+KPH3zRrH+EdT+C/L7wRIPktUVUHknK1XhkE I4x/Wb+2X2EqlvuJoPn1PcJDEA1FFmnuxdYUT6qu73tgqkTOR7chVGn69KCTjnUXKjGu m0XQW3SLZy2FPGoku+HdOqPvKhPhqp2l7ek581m0EzxTQbycPCJ2bdU672wUEgU5cJVO DlB0hC7EhCTVfn8aP9HH5S9Sp08wI//6p2UDma3z25ILTBRgh1OQksqGuloV/5XrIgga bn8nWOQBgBZpMtPDEld77xXe2fm3BLakNkk7rDwUFQ5m6PL6NK9r0OS8XfdoeSs55Vkc sW7Q== X-Gm-Message-State: ALQs6tDneUv4No5VIVghUOA9EmsexWC5gOkc+FIYt2Ue2F8nWoAqKYQ+ Q5R0PHjsoG++857dhzHLoSVUXQ== X-Google-Smtp-Source: AIpwx4/CNMChUEIPKhK4+a3MncTOTfXslpcVjGXqnrdaV8jjjbyNAs8t++ZPYlGFS9GYUdgdw7JQ4Q== X-Received: by 2002:adf:aa04:: with SMTP id p4-v6mr869166wrd.226.1524041514162; Wed, 18 Apr 2018 01:51:54 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id 44-v6sm605609wrk.48.2018.04.18.01.51.53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 18 Apr 2018 01:51:53 -0700 (PDT) Date: Wed, 18 Apr 2018 10:51:39 +0200 From: Adrien Mazarguil To: Anatoly Burakov Cc: dev@dpdk.org, thomas@monjalon.net Message-ID: <20180418085139.GN4957@6wind.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH 0/4] Fixes for coverity issues in fbarray X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 08:51:54 -0000 On Tue, Apr 17, 2018 at 04:44:04PM +0100, Anatoly Burakov wrote: > This patchset fixes a number of Coverity issues introduced > in recent DPDK memory hotplug patchset. > > Coverity issues fixed: > - 272564 - error condition not checked > - 272579 - dereference before null check > - 272586 - error condition not checked > > There are two additional issues reported by coverity: > - 272598 - error condition not checked > - 272599 - error condition not checked > > However, they are fixed by a separate patch [1]. > > [1] http://dpdk.org/dev/patchwork/patch/38091/ > > Anatoly Burakov (4): > fbarray: use strlcpy instead of snprintf > fbarray: add check for failed file descriptor open > fbarray: fix potential null-dereference > fbarray: handle negative return Given that I recently addressed a similar issue in fbarray as well: Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND