From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 0A3DB5F0D for ; Wed, 18 Apr 2018 23:13:24 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2018 14:13:23 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,466,1517904000"; d="scan'208";a="47271249" Received: from dwdohert-ws.ir.intel.com ([163.33.210.60]) by fmsmga004.fm.intel.com with ESMTP; 18 Apr 2018 14:13:20 -0700 From: Declan Doherty To: dev@dpdk.org Cc: Alex Rosenbaum , Ferruh Yigit , Thomas Monjalon , Shahaf Shuler , Qi Zhang , Alejandro Lucero , Andrew Rybchenko , Mohammad Abdul Awal , Remy Horton , John McNamara , Rony Efraim , Jingjing Wu , Wenzhuo Lu , Vincent Jardin , Yuanhan Liu , Bruce Richardson , Konstantin Ananyev , Zhihong Wang , Declan Doherty Date: Wed, 18 Apr 2018 22:04:17 +0100 Message-Id: <20180418210423.13847-1-declan.doherty@intel.com> X-Mailer: git-send-email 2.14.3 In-Reply-To: <1523017443-12414-1-git-send-email-declan.doherty@intel.com> References: <1523017443-12414-1-git-send-email-declan.doherty@intel.com> Subject: [dpdk-dev] [PATCH v4 0/6] additions to support tunnel encap/decap X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Apr 2018 21:13:25 -0000 This patchset contains the revised proposal to manage virtual tunnel endpoints hardware accleration based on community feedback on RFC (http://dpdk.org/ml/archives/dev/2017-December/084676.html). This proposal is purely enabled through rte_flow APIs with the additions of some new features which were previously implemented by the proposed rte_tep APIs which were proposed in the original RFC. This patchset ultimately aims to enable the configuration of inline data path encapsulation and decapsulation of tunnel endpoint network overlays on accelerated IO devices. V2: Split new functions into separate patches, and add additional documentaiton. V3: Extended the description of group counter in documentation. Renamed VTEP to TUNNEL. Fixed C99 syntax. V4: - Modify encap/decap actions to be protocol specific - rename group action type to jump - add mark flow item type in place of metadata flow/action types - add count action data structure - modify query API to accept rte_flow_action structure in place of rte_flow_actio_type enumeration to support specification and querying of multiple actions of the same type The summary of the additions to the rte_flow are as follows: - Add new flow actions RTE_RTE_FLOW_ACTION_TYPE_TUNNEL_ENCAP and RTE_FLOW_ACTION_TYPE_TUNNEL_DECAP to rte_flow to support specfication of encapsulation and decapsulation of virtual Tunnel Endpoint on hardware. - Updates the matching pattern item definition description to specify that all actions which modify a packet must be specified in the explicit order they are to be excuted. - Introduces support for the use of pipeline metadata in the flow pattern definition and the population of metadata fields from flow actions. - Adds group counters to enable statistics to be kept on groups of flows such as all ingress/egress flows of a tunnel - Adds group_action to allow a flow termination to be a group/table within the device. A high level summary of the proposed usage model is as follows: 1. Decapsulation 1.1. Decapsulation of tunnel outer headers and forward all traffic to the same queue/s or port, would have the follow flows paramteters, sudo code used here. struct rte_flow_attr attr = { .ingress = 1 }; struct rte_flow_item pattern[] = { { .type = RTE_FLOW_ITEM_TYPE_ETH, .spec = ð_item }, { .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &ipv4_item }, { .type = RTE_FLOW_ITEM_TYPE_UDP, .spec = &udp_item }, { .type = RTE_FLOW_ITEM_TYPE_VxLAN, .spec = &vxlan_item }, { .type = RTE_FLOW_ITEM_TYPE_END } }; struct rte_flow_action actions[] = { { .type = RTE_FLOW_ACTION_TYPE_TUNNEL_DECAP, .type = VxLAN }, { .type = RTE_FLOW_ACTION_TYPE_VF, .conf = &vf_action }, { .type = RTE_FLOW_ACTION_TYPE_END } } 1.2. Decapsulation of tunnel outer headers and matching on inner headers, and forwarding to the same queue/s or port. 1.2.1. The same scenario as above but either the application or hardware requires configuration as 2 logically independent operations (viewing it as 2 logical tables). The first stage being the flow rule to define the pattern to match the tunnel and the action to decapsulate the packet, and the second stage stage table matches the inner header and defines the actions, forward to port etc. flow rule for outer header on table 0 struct rte_flow_attr attr = { .ingress = 1, .table = 0 }; struct rte_flow_item pattern[] = { { .type = RTE_FLOW_ITEM_TYPE_ETH, .spec = ð_item }, { .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &ipv4_item }, { .type = RTE_FLOW_ITEM_TYPE_UDP, .spec = &udp_item }, { .type = RTE_FLOW_ITEM_TYPE_VxLAN, .spec = &vxlan_item }, { .type = RTE_FLOW_ITEM_TYPE_END } }; struct rte_flow_item_count shared_couter = { .shared = 1, .id = {} } struct rte_flow_action actions[] = { { .type = RTE_FLOW_ACTION_TYPE_COUNT, .conf = &shared_counter }, { .type = RTE_FLOW_ACTION_TYPE_MARK, .conf = &mark_action }, { .type = RTE_FLOW_ACTION_TYPE_VXLAN_DECAP }, { .type = RTE_FLOW_ACTION_TYPE_JUMP, .conf = { .group = 1 } }, { .type = RTE_FLOW_ACTION_TYPE_END } } flow rule for inner header on table 1 struct rte_flow_attr attr = { .ingress = 1, .table = 1 }; struct rte_flow_item_mark mark_item = { id = X }; struct rte_flow_item pattern[] = { { .type = RTE_FLOW_ITEM_TYPE_MARK, .spec = &mark_item }, { .type = RTE_FLOW_ITEM_TYPE_ETH, .spec = ð_item }, { .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &ipv4_item }, { .type = RTE_FLOW_ITEM_TYPE_TCP, .spec = &tcp_item }, { .type = RTE_FLOW_ITEM_TYPE_END } }; struct rte_flow_action actions[] = { { .type = RTE_FLOW_ACTION_TYPE_PORT_ID, .conf = &port_id_action = { port_id } }, { .type = RTE_FLOW_ACTION_TYPE_END } } Note that the metadata action in the flow rule in table 0 is generating the metadata in the pipeline which is then used in as part as the flow pattern in table 1 to specify the exact flow to match against. In the case where exact match rules are being provided by the application then this metadata could be extracted by the PMD from the flow pattern for the group 0 rule, the matching metadata will then need to be explicitly provided by the application in the flow pattern for the flow rule in group 1. For devices capable of wildcard matching then the hardware must be capable of extracting the data from the packet as specified by the mask in the flow action rule in group 0. 2. Encapsulation Encapsulation of all traffic matching a specific flow pattern to a specified tunnel and egressing to a particular port. struct rte_flow_attr attr = { .egress = 1 }; struct rte_flow_item pattern[] = { { .type = RTE_FLOW_ITEM_TYPE_ETH, .spec = ð_item }, { .type = RTE_FLOW_ITEM_TYPE_IPV4, .spec = &ipv4_item }, { .type = RTE_FLOW_ITEM_TYPE_TCP, .spec = &tcp_item }, { .type = RTE_FLOW_ITEM_TYPE_END } }; struct rte_flow_action_tunnel_encap vxlan_encap_action = { .definition = { { .type=eth, .spec={}, .mask={} }, { .type=ipv4, .spec={}, .mask={} }, { .type=udp, .spec={}, .mask={} }, { .type=vxlan, .spec={}, .mask={} } { .type=end } } }; struct rte_flow_action actions[] = { { .type = RTE_FLOW_ACTION_TYPE_COUNT, .conf = &count } }, { .type = RTE_FLOW_ACTION_TYPE_VXLAN_ENCAP, .conf = &vxlan_encap_action } }, { .type = RTE_FLOW_ACTION_TYPE_PORT_ID, .conf = &port_id_action = { port_id } }, { .type = RTE_FLOW_ACTION_TYPE_END } }; Declan Doherty (6): ethdev: Add tunnel encap/decap actions ethdev: Add group action type to rte_flow testpmd: add jump action ethdev: add mark flow item to rte_flow_item_types testpmd: add support for MARK flow item ethdev: add shared counter support to rte_flow app/test-pmd/cmdline_flow.c | 51 +++++++- app/test-pmd/config.c | 15 ++- app/test-pmd/testpmd.h | 2 +- doc/guides/prog_guide/rte_flow.rst | 191 +++++++++++++++++++++++++--- doc/guides/testpmd_app_ug/testpmd_funcs.rst | 8 ++ drivers/net/failsafe/failsafe_flow.c | 4 +- lib/librte_ether/rte_flow.c | 2 +- lib/librte_ether/rte_flow.h | 148 ++++++++++++++++++++- lib/librte_ether/rte_flow_driver.h | 2 +- 9 files changed, 384 insertions(+), 39 deletions(-) -- 2.14.3