DPDK patches and discussions
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [dpdk-dev] [PATCH 1/2] build: fix kernel compile on cross-build
Date: Wed, 18 Apr 2018 22:05:20 +0100	[thread overview]
Message-ID: <20180418210521.277384-2-bruce.richardson@intel.com> (raw)
In-Reply-To: <20180418210521.277384-1-bruce.richardson@intel.com>

When cross-compiling, if no kernel_dir was specified, then the kernel
modules were still being compiled for the build machine. Fix this by
only building modules on cross-compile when we have a kernel_dir value
set.

Fixes: a52f4574f798 ("igb_uio: build with meson")

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 meson.build | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/meson.build b/meson.build
index cc16595cb..9e3b44931 100644
--- a/meson.build
+++ b/meson.build
@@ -26,10 +26,14 @@ subdir('config')
 
 # build libs and drivers
 subdir('lib')
-subdir('kernel')
 subdir('buildtools')
 subdir('drivers')
 
+# build kernel modules if we have a kernel path, or we are not cross compiling
+if get_option('kernel_dir') != '' or not meson.is_cross_build()
+	subdir('kernel')
+endif
+
 # build binaries and installable tools
 subdir('usertools')
 subdir('app')
-- 
2.14.3

  reply	other threads:[~2018-04-18 21:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-18 21:05 [dpdk-dev] [PATCH 0/2] small fixes for meson build Bruce Richardson
2018-04-18 21:05 ` Bruce Richardson [this message]
2018-04-19 15:46   ` [dpdk-dev] [PATCH 1/2] build: fix kernel compile on cross-build Hemant Agrawal
2018-04-19 16:12     ` Bruce Richardson
2018-04-19 17:06       ` Hemant Agrawal
2018-04-18 21:05 ` [dpdk-dev] [PATCH 2/2] build: fix check for libbsd in meson Bruce Richardson
2018-04-27 13:49 ` [dpdk-dev] [PATCH v2 0/3] small improvements to meson build Bruce Richardson
2018-04-27 13:49   ` [dpdk-dev] [PATCH v2 1/3] build: fix kernel compile on cross-build Bruce Richardson
2018-04-27 13:49   ` [dpdk-dev] [PATCH v2 2/3] build: fix check for libbsd in meson Bruce Richardson
2018-04-27 13:51     ` Bruce Richardson
2018-04-27 17:51       ` Vladimir Medvedkin
2018-04-27 13:49   ` [dpdk-dev] [PATCH v2 3/3] build: ensure compatibility with future meson versions Bruce Richardson
2018-04-27 14:37   ` [dpdk-dev] [PATCH v2 0/3] small improvements to meson build Luca Boccassi
2018-05-08 20:22     ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180418210521.277384-2-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).