From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f169.google.com (mail-wr0-f169.google.com [209.85.128.169]) by dpdk.org (Postfix) with ESMTP id 488225F36 for ; Thu, 19 Apr 2018 08:55:05 +0200 (CEST) Received: by mail-wr0-f169.google.com with SMTP id q13-v6so10904871wre.3 for ; Wed, 18 Apr 2018 23:55:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=bkyMr3FAjf4fqt0iBnju5e/Co1AJx7YQznVDSVkYBOM=; b=Q7K3YorR70nGpGW9zUcSxD3g7dHv1AZfv+JY3B9GIJP2VsXccYMWxYJZiTrKzYHAzO dFgWiXsb4Uvju+TSzNZIFZomjICLE3BjNifQhxlHdFXR/uxGau5TAAqqohdzP0KjP+FR 0SVargrH4rvw0znDqX5YZA36Bq0fKesb/GuzE5xk2Whb/Toqqlylqtx6zOSmMisJu35t zcrdeP8wBBGA5A2mVo4M5wpPoJOvw2Tqf/82Qr6Jx9xxbQa5s570GXHwT4wgK/k1enQA m37UQoe4usUn46uSmfdqlQvjxcKz0ztVEYgM+24btr3Qa4VSVbvXS9exyNTRWSRA65q8 tLWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=bkyMr3FAjf4fqt0iBnju5e/Co1AJx7YQznVDSVkYBOM=; b=Sgglb4Xzb4p+Ff98QIewnnJk8mOL4IbDbd/laavSOj0jS3R2onfPJYoBpSK5AZ/UWu IJofjOd+Huo1aKAEg3+rbV+wNUjyoXv/weicDL6YXxTEonHMuzB2ln7sxFIiWMagRTtL 8LflnRfAbpNp3LKXmVCCiBEwOWjr7EFbX4Tgu16BzALQVp+YeUAf/AeocT81sozm8Y/C yGNJKR5z+t+JpMGWF4JdQRzaeQ5O8W324ASSFdMIE1k3YmtYMuAptEKH9AsXzVnHC/sg 6PA3yV8bWfKGF8Bi18D+KRWcHcz5i1nKIzaJNsyvAAXtc+CIwd9QvttBb5h/j5eTr8g4 8Z2w== X-Gm-Message-State: ALQs6tCO0r1yVASC5kC66p0gFdItBJmXD+5CMl5B5bbDjO6OwjNq+cII gnv4tmyWbyvTssa7fTVRLNhC X-Google-Smtp-Source: AIpwx4+VEvnhG7QViqVYUosC7o3NMLm6YfB3lZ7elg01xHVu7c/3g9CRvnfFyXuGI4UZw++/k1ocxA== X-Received: by 2002:adf:a970:: with SMTP id u103-v6mr3523668wrc.71.1524120904885; Wed, 18 Apr 2018 23:55:04 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id y4-v6sm2366877wrh.39.2018.04.18.23.55.04 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 18 Apr 2018 23:55:04 -0700 (PDT) Date: Thu, 19 Apr 2018 08:55:41 +0200 From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro To: "Xueming(Steven) Li" Cc: Shahaf Shuler , "dev@dpdk.org" Message-ID: <20180419065541.s4iy36c6amaavvm7@laranjeiro-vm.dev.6wind.com> References: <20180413112023.106420-1-xuemingl@mellanox.com> <20180417151436.161374-4-xuemingl@mellanox.com> <20180418064856.hk5bst2wuzxxwv6r@laranjeiro-vm.dev.6wind.com> <20180418150858.tlfmca2y3fhv2xcp@laranjeiro-vm.dev.6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 06:55:05 -0000 On Thu, Apr 19, 2018 at 06:20:50AM +0000, Xueming(Steven) Li wrote: > > > > -----Original Message----- > > From: Nélio Laranjeiro > > Sent: Wednesday, April 18, 2018 11:09 PM > > To: Xueming(Steven) Li > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow > > > > On Wed, Apr 18, 2018 at 02:43:30PM +0000, Xueming(Steven) Li wrote: > > > > > > > > > > -----Original Message----- > > > > From: Nélio Laranjeiro > > > > Sent: Wednesday, April 18, 2018 2:49 PM > > > > To: Xueming(Steven) Li > > > > Cc: Shahaf Shuler ; dev@dpdk.org > > > > Subject: Re: [PATCH v4 03/11] net/mlx5: support L3 VXLAN flow > > > > > > > > On Tue, Apr 17, 2018 at 11:14:28PM +0800, Xueming Li wrote: > > > > > This patch support L3 VXLAN, no inner L2 header comparing to > > > > > standard VXLAN protocol. L3 VXLAN using specific overlay UDP > > > > > destination port to discriminate against standard VXLAN, FW has to > > > > > be configured to support > > > > > it: > > > > > sudo mlxconfig -d -y s IP_OVER_VXLAN_EN=1 > > > > > sudo mlxconfig -d -y s IP_OVER_VXLAN_PORT= > > > > > > > > > > Signed-off-by: Xueming Li > > > > > --- > > > > > drivers/net/mlx5/mlx5_flow.c | 4 +++- > > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > > > > b/drivers/net/mlx5/mlx5_flow.c index 771d5f14d..d7a921dff 100644 > > > > > --- a/drivers/net/mlx5/mlx5_flow.c > > > > > +++ b/drivers/net/mlx5/mlx5_flow.c > > > > > @@ -413,7 +413,9 @@ static const struct mlx5_flow_items mlx5_flow_items[] = { > > > > > .dst_sz = sizeof(struct ibv_flow_spec_tunnel), > > > > > }, > > > > > [RTE_FLOW_ITEM_TYPE_VXLAN] = { > > > > > - .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH), > > > > > + .items = ITEMS(RTE_FLOW_ITEM_TYPE_ETH, > > > > > + RTE_FLOW_ITEM_TYPE_IPV4, /* For L3 VXLAN. */ > > > > > + RTE_FLOW_ITEM_TYPE_IPV6), /* For L3 VXLAN. */ > > > > > .actions = valid_actions, > > > > > .mask = &(const struct rte_flow_item_vxlan){ > > > > > .vni = "\xff\xff\xff", > > > > > -- > > > > > 2.13.3 > > > > > > > > Such support must be under device parameter has it depends on the > > > > configuration of the firmware. If the firmware is not correctly configured the PMD must refuse > > such rule. > > > > > > > > Thanks, > > > > > > > > -- > > > > Nélio Laranjeiro > > > > 6WIND > > > > > > Are you suggesting Verbs parameter? I'm afraid we can't have it in > > > short time, need new patch in later release when Verbs ready. > > > > Take a look at [1], this is what I mean. > > Enabling a new device parameter can't make L3 VXLAN packet get > received if fw configuration not set. So you expect than the user will enable a feature without reading the PMD documentation? If it is the case, the answer it pretty simple, it is the same as above, read the PMD documentation. > On the other hand, if fw continuation enabled and device parameter not > set, packet could be received but failed to create rule. Again a user using a NIC should read the documentation. > I'm afraid that a device parameter will introduce complexity of using > this feature w/o real benefits. Add this missing device parameter and update accordingly the documentation, or wait for Verbs to add the missing query feature. If the firmware it not configured this rule must be refused, as there is no way in the PMD to know if the firmware is configured, it must rely on a device parameter. Regards, -- Nélio Laranjeiro 6WIND