From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f194.google.com (mail-wr0-f194.google.com [209.85.128.194]) by dpdk.org (Postfix) with ESMTP id 5AE197CEA for ; Thu, 19 Apr 2018 12:07:44 +0200 (CEST) Received: by mail-wr0-f194.google.com with SMTP id h3-v6so12438492wrh.5 for ; Thu, 19 Apr 2018 03:07:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Jei4q+Jo5Y2Lg7jHtKyKuT3CMUFIZM81mA4jbn1jzcM=; b=FkMgDbG4GPBcwgSk/zC0JLbrW0jI+kWPzF/FLOcFWjGWUEVwUa2O9lVdSDUnYEuc3Z 3ODn7TolYL0ITNtuSulExh+TM6zTWV3SWSwxriHDX6H3b1KiZu837GU/NwNroG6FKMBJ SIneRopgiPMluphyZgV3rcwI9hpEWmLmGfuqdEx4/VBBE0ftGhx8hbmHvF63Pag6uXjK BUZP9O3GZVe3gXEaqCQMPrev8nnmDH8pbRTHR3vfVzRz9Jr9blXt8wsKOPN+TI4O4Sep 2Ms9E65Ks9koVlsBC6K5ja2+7mmNORuQoPJb+/kQbIGNy2JhrSQ13PL29aSvAtGQQssQ mosQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Jei4q+Jo5Y2Lg7jHtKyKuT3CMUFIZM81mA4jbn1jzcM=; b=CP7wItbziJbf8YT8SsfrtoPu2ZzKBRpUBi6odKdruq/FT8ks/vKzvZb69PlBz6BbER Y52uhe9wyAmdRVva9GxZ2hgpXCi671oU27ITnPXKAO14tFHP983QLWgwsBpSm5ENgVpE mVxoyJ6C115i6MLE7o6QbD6JVfl6v6Mdvs6d3RJxLbxKrJy7CHP+QAWQu62s3wRtaRsE 0YYQ3rw5qo2sjcr1l4Qpdh/ENIFB3jj3PzCZDUh+H24OF9vUDAKmXX9e8K+HfJS+Z2Qe xbTdCiqFTNWFHPO5T52qGea3DWoCiAhMmPHtrn/xBUztXoAdpM10cTIvirOeKTfjo2dY a8WA== X-Gm-Message-State: ALQs6tDdqVVdLaGEpk1A/LmB8inU8Qby/ctnhmFk0BNj2Y2Xsi/WVYKF zZcuQxnqegCwAYy+QqDe7ifFLmnk X-Google-Smtp-Source: AIpwx48DmjmJ/Aadjetl4SRqcr6A0ARA/uwMVSdaCG+a5NsE+HUJM9AUVRWQFCykS0G2sHhgzFLWdQ== X-Received: by 2002:adf:dc4b:: with SMTP id m11-v6mr4439008wrj.174.1524132463971; Thu, 19 Apr 2018 03:07:43 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id j89-v6sm3331582wrj.86.2018.04.19.03.07.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 19 Apr 2018 03:07:43 -0700 (PDT) Date: Thu, 19 Apr 2018 12:07:29 +0200 From: Adrien Mazarguil To: dev@dpdk.org Cc: stable@dpdk.org, Nelio Laranjeiro Message-ID: <20180419100204.5728-4-adrien.mazarguil@6wind.com> References: <20180416150058.2620-1-adrien.mazarguil@6wind.com> <20180419100204.5728-1-adrien.mazarguil@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180419100204.5728-1-adrien.mazarguil@6wind.com> X-Mailer: git-send-email 2.11.0 Subject: [dpdk-dev] [PATCH v6 03/11] net/mlx5: fix RSS flow action bounds check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Apr 2018 10:07:44 -0000 The number of queues provided by the application is not checked against parser's supported maximum. Fixes: 3d821d6fea40 ("net/mlx5: support RSS action flow rule") Cc: stable@dpdk.org Cc: Nelio Laranjeiro Signed-off-by: Adrien Mazarguil Acked-by: Nelio Laranjeiro --- drivers/net/mlx5/mlx5_flow.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index 7ef68de49..1ca413e32 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -16,6 +16,7 @@ #pragma GCC diagnostic error "-Wpedantic" #endif +#include #include #include #include @@ -713,6 +714,14 @@ mlx5_flow_convert_actions(struct rte_eth_dev *dev, return -rte_errno; } } + if (rss->num > RTE_DIM(parser->queues)) { + rte_flow_error_set(error, EINVAL, + RTE_FLOW_ERROR_TYPE_ACTION, + actions, + "too many queues for RSS" + " context"); + return -rte_errno; + } for (n = 0; n < rss->num; ++n) { if (rss->queue[n] >= priv->rxqs_n) { rte_flow_error_set(error, EINVAL, -- 2.11.0