* [dpdk-dev] [PATCH] examples/ip_pipeline: fix resource leak
@ 2018-04-19 11:04 Kevin Laatz
2018-04-19 15:32 ` Singh, Jasvinder
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Laatz @ 2018-04-19 11:04 UTC (permalink / raw)
To: dev; +Cc: cristian.dumitrescu, Kevin Laatz, jasvinder.singh
Closing the fd_server file descriptor on error to fix the resource leak.
Coverity issue: 272587
Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface")
Cc: jasvinder.singh@intel.com
Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
---
examples/ip_pipeline/conn.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/examples/ip_pipeline/conn.c b/examples/ip_pipeline/conn.c
index 9338942..6b08e9e 100644
--- a/examples/ip_pipeline/conn.c
+++ b/examples/ip_pipeline/conn.c
@@ -96,12 +96,14 @@ conn_init(struct conn_params *p)
sizeof(server_address));
if (status == -1) {
conn_free(conn);
+ close(fd_server);
return NULL;
}
status = listen(fd_server, 16);
if (status == -1) {
conn_free(conn);
+ close(fd_server);
return NULL;
}
@@ -109,6 +111,7 @@ conn_init(struct conn_params *p)
fd_client_group = epoll_create(1);
if (fd_client_group == -1) {
conn_free(conn);
+ close(fd_server);
return NULL;
}
--
2.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] examples/ip_pipeline: fix resource leak
2018-04-19 11:04 [dpdk-dev] [PATCH] examples/ip_pipeline: fix resource leak Kevin Laatz
@ 2018-04-19 15:32 ` Singh, Jasvinder
0 siblings, 0 replies; 2+ messages in thread
From: Singh, Jasvinder @ 2018-04-19 15:32 UTC (permalink / raw)
To: Laatz, Kevin, dev; +Cc: Dumitrescu, Cristian
> -----Original Message-----
> From: Laatz, Kevin
> Sent: Thursday, April 19, 2018 12:04 PM
> To: dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>; Laatz, Kevin
> <kevin.laatz@intel.com>; Singh, Jasvinder <jasvinder.singh@intel.com>
> Subject: [PATCH] examples/ip_pipeline: fix resource leak
>
> Closing the fd_server file descriptor on error to fix the resource leak.
>
> Coverity issue: 272587
> Fixes: 4bbf8e30aa5e ("examples/ip_pipeline: add CLI interface")
> Cc: jasvinder.singh@intel.com
>
> Signed-off-by: Kevin Laatz <kevin.laatz@intel.com>
> ---
> examples/ip_pipeline/conn.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/examples/ip_pipeline/conn.c b/examples/ip_pipeline/conn.c index
> 9338942..6b08e9e 100644
> --- a/examples/ip_pipeline/conn.c
> +++ b/examples/ip_pipeline/conn.c
> @@ -96,12 +96,14 @@ conn_init(struct conn_params *p)
> sizeof(server_address));
> if (status == -1) {
> conn_free(conn);
> + close(fd_server);
> return NULL;
> }
>
> status = listen(fd_server, 16);
> if (status == -1) {
> conn_free(conn);
> + close(fd_server);
> return NULL;
> }
>
> @@ -109,6 +111,7 @@ conn_init(struct conn_params *p)
> fd_client_group = epoll_create(1);
> if (fd_client_group == -1) {
> conn_free(conn);
> + close(fd_server);
> return NULL;
> }
>
> --
> 2.9.5
Reviewed-by: Jasvinder Singh <jasvinder.singh@intel.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-19 15:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19 11:04 [dpdk-dev] [PATCH] examples/ip_pipeline: fix resource leak Kevin Laatz
2018-04-19 15:32 ` Singh, Jasvinder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).