DPDK patches and discussions
 help / color / mirror / Atom feed
From: Pablo de Lara <pablo.de.lara.guarch@intel.com>
To: dev@dpdk.org
Cc: fiona.trahe@intel.com,
	Pablo de Lara <pablo.de.lara.guarch@intel.com>,
	stable@dpdk.org
Subject: [dpdk-dev] [PATCH v2 2/3] crypto/zuc: remove unnecessary check
Date: Thu, 19 Apr 2018 15:55:40 +0100	[thread overview]
Message-ID: <20180419145541.28836-3-pablo.de.lara.guarch@intel.com> (raw)
In-Reply-To: <20180419145541.28836-1-pablo.de.lara.guarch@intel.com>

When processing operations, the operation type was being
checked to avoid if it was set to NOT SUPPORTED.
In data path, doing so is not required since that is already
checked when creating the crypto session,
so that case will not ever happen.

Fixes: cf7685d68f00 ("crypto/zuc: add driver for ZUC library")
Cc: stable@dpdk.org

Signed-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>
Acked-by: Fiona Trahe <fiona.trahe@intel.com>
---
 drivers/crypto/zuc/rte_zuc_pmd.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/crypto/zuc/rte_zuc_pmd.c b/drivers/crypto/zuc/rte_zuc_pmd.c
index 6d3834bcc..568c593ae 100644
--- a/drivers/crypto/zuc/rte_zuc_pmd.c
+++ b/drivers/crypto/zuc/rte_zuc_pmd.c
@@ -353,8 +353,7 @@ zuc_pmd_enqueue_burst(void *queue_pair, struct rte_crypto_op **ops,
 		curr_c_op = ops[i];
 
 		curr_sess = zuc_get_session(qp, curr_c_op);
-		if (unlikely(curr_sess == NULL ||
-				curr_sess->op == ZUC_OP_NOT_SUPPORTED)) {
+		if (unlikely(curr_sess == NULL)) {
 			curr_c_op->status =
 					RTE_CRYPTO_OP_STATUS_INVALID_SESSION;
 			break;
-- 
2.14.3

  parent reply	other threads:[~2018-04-19 14:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-29 15:56 [dpdk-dev] [PATCH 0/3] ZUC PMD fixes Pablo de Lara
2018-03-29 15:56 ` [dpdk-dev] [PATCH 1/3] crypto/zuc: do not set default op status Pablo de Lara
2018-04-19 14:24   ` Trahe, Fiona
2018-03-29 15:56 ` [dpdk-dev] [PATCH 2/3] crypto/zuc: remove unnecessary check Pablo de Lara
2018-04-19 14:23   ` Trahe, Fiona
2018-03-29 15:56 ` [dpdk-dev] [PATCH 3/3] crypto/zuc: batch ops with same transform Pablo de Lara
2018-04-19 14:22   ` Trahe, Fiona
2018-04-19 14:26     ` De Lara Guarch, Pablo
2018-04-19 14:55 ` [dpdk-dev] [PATCH v2 0/3] ZUC PMD fixes Pablo de Lara
2018-04-19 14:55   ` [dpdk-dev] [PATCH v2 1/3] crypto/zuc: do not set default op status Pablo de Lara
2018-04-19 14:55   ` Pablo de Lara [this message]
2018-04-19 14:55   ` [dpdk-dev] [PATCH v2 3/3] crypto/zuc: batch ops with same transform Pablo de Lara
2018-04-19 16:39   ` [dpdk-dev] [PATCH v2 0/3] ZUC PMD fixes De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180419145541.28836-3-pablo.de.lara.guarch@intel.com \
    --to=pablo.de.lara.guarch@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).