* [dpdk-dev] [PATCH] net/mvpp2: fix build
@ 2018-04-19 16:09 Thomas Monjalon
2018-04-19 20:52 ` Ferruh Yigit
2018-04-20 5:26 ` Tomasz Duszynski
0 siblings, 2 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-04-19 16:09 UTC (permalink / raw)
To: dev; +Cc: nsamsono, ferruh.yigit
The iterator RTE_ETH_FOREACH_DEV (added in below commit)
requires to enable experimental APIs.
Fixing also the config option rename in the build test.
Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
Fixes: fe93968722af ("net/mrvl: rename PMD as mvpp2")
Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
devtools/test-build.sh | 2 +-
drivers/net/mvpp2/Makefile | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/devtools/test-build.sh b/devtools/test-build.sh
index 3362edcc5..28e032417 100755
--- a/devtools/test-build.sh
+++ b/devtools/test-build.sh
@@ -202,7 +202,7 @@ config () # <directory> <target> <options>
test -z "$LIBMUSDK_PATH" || \
sed -ri 's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
test -z "$LIBMUSDK_PATH" || \
- sed -ri 's,(MRVL_PMD=)n,\1y,' $1/.config
+ sed -ri 's,(MVPP2_PMD=)n,\1y,' $1/.config
build_config_hook $1 $2 $3
# Explicit enabler/disabler (uppercase)
diff --git a/drivers/net/mvpp2/Makefile b/drivers/net/mvpp2/Makefile
index 2383ec18c..db4576f9c 100644
--- a/drivers/net/mvpp2/Makefile
+++ b/drivers/net/mvpp2/Makefile
@@ -27,6 +27,7 @@ CFLAGS += -I$(LIBMUSDK_PATH)/include
CFLAGS += -DMVCONF_TYPES_PUBLIC
CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
CFLAGS += $(WERROR_FLAGS)
+CFLAGS += -DALLOW_EXPERIMENTAL_API
CFLAGS += -O3
LDLIBS += -L$(LIBMUSDK_PATH)/lib
LDLIBS += -lmusdk
--
2.16.2
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mvpp2: fix build
2018-04-19 16:09 [dpdk-dev] [PATCH] net/mvpp2: fix build Thomas Monjalon
@ 2018-04-19 20:52 ` Ferruh Yigit
2018-04-20 9:10 ` Thomas Monjalon
2018-04-20 5:26 ` Tomasz Duszynski
1 sibling, 1 reply; 4+ messages in thread
From: Ferruh Yigit @ 2018-04-19 20:52 UTC (permalink / raw)
To: Thomas Monjalon, dev; +Cc: nsamsono
On 4/19/2018 5:09 PM, Thomas Monjalon wrote:
> The iterator RTE_ETH_FOREACH_DEV (added in below commit)
> requires to enable experimental APIs.
>
> Fixing also the config option rename in the build test.
>
> Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> Fixes: fe93968722af ("net/mrvl: rename PMD as mvpp2")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [dpdk-dev] [PATCH] net/mvpp2: fix build
2018-04-19 20:52 ` Ferruh Yigit
@ 2018-04-20 9:10 ` Thomas Monjalon
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Monjalon @ 2018-04-20 9:10 UTC (permalink / raw)
To: Ferruh Yigit; +Cc: dev, nsamsono
19/04/2018 22:52, Ferruh Yigit:
> On 4/19/2018 5:09 PM, Thomas Monjalon wrote:
> > The iterator RTE_ETH_FOREACH_DEV (added in below commit)
> > requires to enable experimental APIs.
> >
> > Fixing also the config option rename in the build test.
> >
> > Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> > Fixes: fe93968722af ("net/mrvl: rename PMD as mvpp2")
> >
> > Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>
> Tested-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied, thanks
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [dpdk-dev] [PATCH] net/mvpp2: fix build
2018-04-19 16:09 [dpdk-dev] [PATCH] net/mvpp2: fix build Thomas Monjalon
2018-04-19 20:52 ` Ferruh Yigit
@ 2018-04-20 5:26 ` Tomasz Duszynski
1 sibling, 0 replies; 4+ messages in thread
From: Tomasz Duszynski @ 2018-04-20 5:26 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: dev, nsamsono, ferruh.yigit
On Thu, Apr 19, 2018 at 06:09:34PM +0200, Thomas Monjalon wrote:
> The iterator RTE_ETH_FOREACH_DEV (added in below commit)
> requires to enable experimental APIs.
>
> Fixing also the config option rename in the build test.
>
> Fixes: 8728ccf37615 ("fix ethdev ports enumeration")
> Fixes: fe93968722af ("net/mrvl: rename PMD as mvpp2")
>
> Reported-by: Ferruh Yigit <ferruh.yigit@intel.com>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> devtools/test-build.sh | 2 +-
> drivers/net/mvpp2/Makefile | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/devtools/test-build.sh b/devtools/test-build.sh
> index 3362edcc5..28e032417 100755
> --- a/devtools/test-build.sh
> +++ b/devtools/test-build.sh
> @@ -202,7 +202,7 @@ config () # <directory> <target> <options>
> test -z "$LIBMUSDK_PATH" || \
> sed -ri 's,(PMD_MRVL_CRYPTO=)n,\1y,' $1/.config
> test -z "$LIBMUSDK_PATH" || \
> - sed -ri 's,(MRVL_PMD=)n,\1y,' $1/.config
> + sed -ri 's,(MVPP2_PMD=)n,\1y,' $1/.config
> build_config_hook $1 $2 $3
>
> # Explicit enabler/disabler (uppercase)
> diff --git a/drivers/net/mvpp2/Makefile b/drivers/net/mvpp2/Makefile
> index 2383ec18c..db4576f9c 100644
> --- a/drivers/net/mvpp2/Makefile
> +++ b/drivers/net/mvpp2/Makefile
> @@ -27,6 +27,7 @@ CFLAGS += -I$(LIBMUSDK_PATH)/include
> CFLAGS += -DMVCONF_TYPES_PUBLIC
> CFLAGS += -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC
> CFLAGS += $(WERROR_FLAGS)
> +CFLAGS += -DALLOW_EXPERIMENTAL_API
> CFLAGS += -O3
> LDLIBS += -L$(LIBMUSDK_PATH)/lib
> LDLIBS += -lmusdk
> --
> 2.16.2
>
Looks good:
Acked-by: Tomasz Duszynski <tdu@semihalf.com>
--
- Tomasz Duszyński
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-20 9:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-19 16:09 [dpdk-dev] [PATCH] net/mvpp2: fix build Thomas Monjalon
2018-04-19 20:52 ` Ferruh Yigit
2018-04-20 9:10 ` Thomas Monjalon
2018-04-20 5:26 ` Tomasz Duszynski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).