From: Stephen Hemminger <stephen@networkplumber.org>
To: Sunil Kumar Kori <sunil.kori@nxp.com>
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>, <shreyansh.jain@nxp.com>
Subject: Re: [dpdk-dev] [PATCH 1/2] net/dpaa: non supported offloads are ignored with warning
Date: Fri, 20 Apr 2018 08:20:45 -0700 [thread overview]
Message-ID: <20180420082045.065283f1@xeon-e3> (raw)
In-Reply-To: <20180420104541.21987-2-sunil.kori@nxp.com>
On Fri, 20 Apr 2018 16:15:40 +0530
Sunil Kumar Kori <sunil.kori@nxp.com> wrote:
> dpaa_eth_dev_info(dev, &dev_info);
> if (((~(dev_info.rx_offload_capa) & rx_offloads) != 0)) {
> - DPAA_PMD_ERR("Some Rx offloads are not supported "
> + DPAA_PMD_WARN("Some Rx offloads are not supported "
> "requested 0x%" PRIx64 " supported 0x%" PRIx64,
The if statement has more parens than necessary.
Please don't break error messages across lines, it is better to have a long source
line since it allows users to use tools like grep to search for error messages.
next prev parent reply other threads:[~2018-04-20 15:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 10:45 [dpdk-dev] [PATCH 0/2] Non-supported offloads are ignored Sunil Kumar Kori
2018-04-20 10:45 ` [dpdk-dev] [PATCH 1/2] net/dpaa: non supported offloads are ignored with warning Sunil Kumar Kori
2018-04-20 15:20 ` Stephen Hemminger [this message]
2018-04-20 10:45 ` [dpdk-dev] [PATCH 2/2] net/dpaa2: " Sunil Kumar Kori
2018-04-20 12:27 ` [dpdk-dev] [PATCH 0/2] Non-supported offloads are ignored Ferruh Yigit
2018-04-23 12:33 ` [dpdk-dev] [PATCH v2 " Sunil Kumar Kori
2018-04-23 12:33 ` [dpdk-dev] [PATCH v2 1/2] net/dpaa: non supported offloads are ignored with warning Sunil Kumar Kori
2018-04-23 14:57 ` Ferruh Yigit
2018-04-23 12:33 ` [dpdk-dev] [PATCH v2 2/2] net/dpaa2: " Sunil Kumar Kori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180420082045.065283f1@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=shreyansh.jain@nxp.com \
--cc=sunil.kori@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).