From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id E07582B8B for ; Sun, 22 Apr 2018 13:58:12 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Apr 2018 04:58:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,311,1520924400"; d="scan'208";a="222402433" Received: from dpdk51.sh.intel.com ([10.67.110.184]) by fmsmga006.fm.intel.com with ESMTP; 22 Apr 2018 04:58:09 -0700 From: Qi Zhang To: thomas@monjalon.net, ferruh.yigit@intel.com Cc: konstantin.ananyev@intel.com, dev@dpdk.org, beilei.xing@intel.com, jingjing.wu@intel.com, wenzhuo.lu@intel.com, Qi Zhang Date: Sun, 22 Apr 2018 19:58:19 +0800 Message-Id: <20180422115824.105219-1-qi.z.zhang@intel.com> X-Mailer: git-send-email 2.13.6 In-Reply-To: <20180212045314.171616-1-qi.z.zhang@intel.com> References: <20180212045314.171616-1-qi.z.zhang@intel.com> Subject: [dpdk-dev] [PATCH v7 0/5] runtime queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 22 Apr 2018 11:58:13 -0000 From: Qi Zhang v7: - update default.ini and i40e.ini. - rename runtime_queue_setup_capa to dev_capa for generic. - testpmd queue setup command be moved to "ports" command group. - remove ring_size and offload from queue setup command in testpmd. - enable per queue config in testpmd. - enable queue ring size configure command in testpmd. - fix couple typo. TODO: queue offload config commmand is not implemented yet, but per queue configure data structure is already supported in PATCH 3 v6: - fix tx queue state check in rte_eth_rx_queue_setup - fix error message in testpmd. v5: - fix first tx queue check in i40e. v4: - fix i40e rx/tx funciton conflict handle. - no need conflict check for first rx/tx queue at runtime setup. - fix missing offload paramter in testpmd cmdline. v3: - not overload deferred start. - rename deferred setup to runtime setup. - remove unecessary testpmd parameters (patch 2/4 of v2) - add offload support to testpmd queue setup command line - i40e fix: return fail when required rx/tx function conflict with exist setup. v2: - enhance comment in rte_ethdev.h According to exist implementation,rte_eth_[rx|tx]_queue_setup will always return fail if device is already started(rte_eth_dev_start). This can't satisfied the usage when application want to deferred setup part of the queues while keep traffic running on those queues already be setup. example: rte_eth_dev_config(nb_rxq = 2, nb_txq =2) rte_eth_rx_queue_setup(idx = 0 ...) rte_eth_rx_queue_setup(idx = 0 ...) rte_eth_dev_start(...) /* [rx|tx]_burst is ready to start on queue 0 */ rte_eth_rx_queue_setup(idx=1 ...) /* fail*/ Basically this is not a general hardware limitation, because for NIC like i40e, ixgbe, it is not necessary to stop the whole device before configure a fresh queue or reconfigure an exist queue with no traffic on it. The patch let etherdev driver expose the capability flag through rte_eth_dev_info_get when it support deferred queue configuraiton, then base on these flag, rte_eth_[rx|tx]_queue_setup could decide continue to setup the queue or just return fail when device already started. Qi Zhang (1): net/i40e: enable runtime queue setup qi Zhang (4): ethdev: support runtime queue setup app/testpmd: add command for queue setup app/testpmd: enable per queue configure app/testpmd: enable queue ring size configure app/test-pmd/cmdline.c | 217 ++++++++++++++++++++++++++++ app/test-pmd/config.c | 48 +++--- app/test-pmd/testpmd.c | 101 ++++++++----- app/test-pmd/testpmd.h | 6 +- doc/guides/nics/features.rst | 18 +++ doc/guides/nics/features/default.ini | 2 + doc/guides/nics/features/i40e.ini | 2 + doc/guides/testpmd_app_ug/testpmd_funcs.rst | 16 ++ drivers/net/i40e/i40e_ethdev.c | 4 + drivers/net/i40e/i40e_rxtx.c | 183 ++++++++++++++++++++--- lib/librte_ether/rte_ethdev.c | 30 ++-- lib/librte_ether/rte_ethdev.h | 7 + 12 files changed, 540 insertions(+), 94 deletions(-) -- 2.13.6