From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.droids-corp.org (zoll.droids-corp.org [94.23.50.67]) by dpdk.org (Postfix) with ESMTP id 077DA2C0C for ; Mon, 23 Apr 2018 10:14:52 +0200 (CEST) Received: from alille-654-1-134-221.w90-34.abo.wanadoo.fr ([90.34.61.221] helo=droids-corp.org) by mail.droids-corp.org with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1fAWci-0002bS-8j; Mon, 23 Apr 2018 10:14:57 +0200 Received: by droids-corp.org (sSMTP sendmail emulation); Mon, 23 Apr 2018 10:14:49 +0200 Date: Mon, 23 Apr 2018 10:14:49 +0200 From: Olivier Matz To: Thomas Monjalon Cc: dev@dpdk.org, xuemingl@mellanox.com, harish.patil@cavium.com Message-ID: <20180423081449.yxyc2cbuhfavfeor@platinum> References: <20180420001324.11813-1-thomas@monjalon.net> <20180420001324.11813-3-thomas@monjalon.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180420001324.11813-3-thomas@monjalon.net> User-Agent: NeoMutt/20170113 (1.7.2) Subject: Re: [dpdk-dev] [PATCH 2/2] mbuf: improve API doc for tunnel Tx offloads X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 08:14:52 -0000 On Fri, Apr 20, 2018 at 02:13:24AM +0200, Thomas Monjalon wrote: > Add few details to remind TSO flag, checksum flags and header lengths. > > The doxygen syntax for MPLS-in-UDP is fixed. > > Fixes: d95188551fa1 ("mbuf: introduce new Tx offload flag for MPLS-in-UDP") > Cc: harish.patil@cavium.com > > Signed-off-by: Thomas Monjalon > --- > lib/librte_mbuf/rte_mbuf.h | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h > index 7ae3bab14..adf95e3cd 100644 > --- a/lib/librte_mbuf/rte_mbuf.h > +++ b/lib/librte_mbuf/rte_mbuf.h > @@ -201,14 +201,16 @@ extern "C" { > > /** > * Bits 45:48 used for the tunnel type. > - * When doing Tx offload like TSO or checksum, the HW needs to configure the > - * tunnel type into the HW descriptors. > + * The tunnel type must be specified for TSO or checksum on tunnel packets. on tunnel packets -> on the inner part of tunnel packets > + * These flags can be used with PKT_TX_TCP_SEG for TSO, or PKT_TX_xxx_CKSUM. > + * The mbuf fields for inner and outer header lengths may be required: may be -> are > + * outer_l2_len, outer_l3_len, l2_len, l3_len, l4_len. and tso_segsz for TSO. > */ > #define PKT_TX_TUNNEL_VXLAN (0x1ULL << 45) > #define PKT_TX_TUNNEL_GRE (0x2ULL << 45) > #define PKT_TX_TUNNEL_IPIP (0x3ULL << 45) > #define PKT_TX_TUNNEL_GENEVE (0x4ULL << 45) > -/**< TX packet with MPLS-in-UDP RFC 7510 header. */ > +/** TX packet with MPLS-in-UDP RFC 7510 header. */ > #define PKT_TX_TUNNEL_MPLSINUDP (0x5ULL << 45) > /* add new TX TUNNEL type here */ > #define PKT_TX_TUNNEL_MASK (0xFULL << 45) > -- > 2.16.2 >