From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f172.google.com (mail-wr0-f172.google.com [209.85.128.172]) by dpdk.org (Postfix) with ESMTP id 611D12583 for ; Mon, 23 Apr 2018 13:49:22 +0200 (CEST) Received: by mail-wr0-f172.google.com with SMTP id d1-v6so40370927wrj.13 for ; Mon, 23 Apr 2018 04:49:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=oV6fyNjAXyzcWOnb5PalxI8JryLTaFs4B3QzjAx1US4=; b=XxbUCVTLCVecVh4/hNXSy6i57gCCf10A2yzAHN+hqvf4l/F94i7snYkXx8Ir+S2ft+ 7hblbtjInXvb/uWsWmZ3FP9LGj+uN4MYZeiRWQWLAVNK/3+h4PTG1lUo5m97B+0wHRag 8rkEbFgizA/E1N5umR/Bg3iggyylkvz9ytNqbxzerNSlyPhEoROPNrJPgn28xKTpCxzc PTh4WC/bTDUb9l5izndsogpwDoAridntpekWnKf4GDZbNBFbHYFY3NlqBA9zUFYMpcJe wAfptrdhqUk3JGTRW4U1IKkkPnvW3t7EsRzI/RX4v/hlo6g8ekzhiHk0d9w6r6myHmHu qMYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=oV6fyNjAXyzcWOnb5PalxI8JryLTaFs4B3QzjAx1US4=; b=doedNQ/7Zzy3uiCjdxScYA/e0mSh/NX9FxqnrIynsY3tDZYimBrlqxicuL13+Y6W4q SrFZXeWpmtsLLofcvf3TYXaJ6v1/9dWYJXxuIlDceg0TQD5O4IErZ+/yF/whuq2qYtH6 omMAkWz2J0P2PVnB1BpdfDl/3sI3+TO8FmlME+7D/YMlDdf/5IM/GemePE4E3nAGf6Fe wS4vhz1h9hKvQh3+SPrWqQY3vg+Zig4AaAjMgcLDiFqAnGM9S47kOJf+RXP3yzXN1HCf Yp/XBEbX8zRVxyuVWptiJkbu90ppxbrqPveTp6KH+BafNKGiwfWcB6U8YZ5UeE0TmvKb Y2JQ== X-Gm-Message-State: ALQs6tA/8pLDGcOOFDGqMcOa40nUl6R5Gk/1nt6tPbLkd1rnEB6xbp0g 9fjV2ay9CgzGmDQhPoiQ/5ZmTx6e X-Google-Smtp-Source: AB8JxZqCSjbcUB2X/hV2WoyWnVGAqg9LsqyEAWGF8VFcYNUrQhpI6R0o14CjsluLjOAh9zMDoOSTcA== X-Received: by 2002:adf:d245:: with SMTP id o5-v6mr522151wri.134.1524484162355; Mon, 23 Apr 2018 04:49:22 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id z63-v6sm17142082wrb.34.2018.04.23.04.49.21 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Apr 2018 04:49:21 -0700 (PDT) Date: Mon, 23 Apr 2018 13:49:07 +0200 From: Adrien Mazarguil To: "Doherty, Declan" Cc: Shahaf Shuler , "dev@dpdk.org" , Alex Rosenbaum , Ferruh Yigit , Thomas Monjalon , Qi Zhang , Alejandro Lucero , Andrew Rybchenko , Mohammad Abdul Awal , Remy Horton , John McNamara , Rony Efraim , Jingjing Wu , Wenzhuo Lu , Vincent Jardin , Yuanhan Liu , Bruce Richardson , Konstantin Ananyev , Zhihong Wang Message-ID: <20180423114907.GN4957@6wind.com> References: <1523017443-12414-1-git-send-email-declan.doherty@intel.com> <20180418210423.13847-1-declan.doherty@intel.com> <20180418210423.13847-2-declan.doherty@intel.com> <20180419130307.GY4957@6wind.com> <0aff3015-b8f7-2abe-984c-f8f4ff2251d6@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0aff3015-b8f7-2abe-984c-f8f4ff2251d6@intel.com> Subject: Re: [dpdk-dev] [PATCH v4 1/6] ethdev: Add tunnel encap/decap actions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 11:49:23 -0000 On Mon, Apr 23, 2018 at 12:17:09PM +0100, Doherty, Declan wrote: > On 23/04/2018 12:00 PM, Shahaf Shuler wrote: > > Thursday, April 19, 2018 4:03 PM, Adrien Mazarguil: > > > Subject: Re: [dpdk-dev] [PATCH v4 1/6] ethdev: Add tunnel encap/decap > > > actions > > > > > > On Wed, Apr 18, 2018 at 10:04:18PM +0100, Declan Doherty wrote: > > > > [...] > > > > > > > > I'm still unsure about the definition involving a list of items. I imagined > > > these actions even less generic than that. How about tagging them > > > EXPERIMENTAL until sorted out through the first PMD implementation? > > > > I think every new API should be marked as experimental. At least for one release. > > Here in specific, because there is no actual implementation of those APIs in any of the drivers. > > > > On this, since these are just new structures to use with existing APIs is > using the following tag in the doxygen comments sufficient? > > /** > * @warning > * @b EXPERIMENTAL: this structure may change without prior notice > */ Looks good to me. I did not realize we already had such a thing in DPDK (eventdev). > > > (We could even provide forward declarations only to prevent applications > > > from using them in the meantime.) -- Adrien Mazarguil 6WIND