From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com (mail-wr0-f195.google.com [209.85.128.195]) by dpdk.org (Postfix) with ESMTP id 517112B92 for ; Mon, 23 Apr 2018 13:49:38 +0200 (CEST) Received: by mail-wr0-f195.google.com with SMTP id w3-v6so40402750wrg.2 for ; Mon, 23 Apr 2018 04:49:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=fKNVxJTQ8CdXyE4PzcELWHz5oPUdFfDT5FbG7sgM79g=; b=KHAUZjb1jkD7CDO+Dqu04SfAOwtTS7RYamFwnDwX3MAvQnDAf1xqSScBszcyKUHSQH lXqRmunukadqitxgebyl9zO+W2Ut7FVonU+ZzlhqMAyRwegpITr+hfP692RohFAZED2C NrVakpjCfTCzE5kdhnEmK9+0CllywvQAnXMiKU73pb9hP2D43g+Ap2aloDbz8kkHRgly vRPfT3Wfq95iw5uO1EUjB4cWe2GRnymmTB9LBAfaDspp2cpW9qypTcs3Vp1/n7N6AY+M ySup+qKW1FNcFDRjPPOOBy+CB5khIcqlXRtswcrPVD0b2SWuaExOuoGP8hnq5je4GS7o 0RUQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=fKNVxJTQ8CdXyE4PzcELWHz5oPUdFfDT5FbG7sgM79g=; b=Y776R+KDU+oFoYh+lUFCfvU05GctmRj58dA4SmZB0jyrL4wKVNPV5/soefufe7+P2h J0cfbtoUs5lflSEk9XxHw1HPLWqVJIz6PehxVpxMFOkzFMMnxxV2O//emCB9ErFCV+/5 agomkeaBb6WE2Q0OHdDTjjHr5NTl+aylnUL2OIgtTDwliQFtjaAq/7w/xbs23YOJw8bN QhV2kgnsZ46IkmxX+PPtx/fsmr/cSbawOmnCoNSRrHTGVpfTLP6FnKps9VrTKKN89tdZ TJvMpnl3CEaF1MRx4fC37Dwz7rszqYmnCu9h0PMrCx4MQ78jDMzQ+bXcfEBpj3ihqjCV flmg== X-Gm-Message-State: ALQs6tBxIcHaTOxerm+f/42AZyfSa5rDh9LurZQKDfl7ZU2aMoS00zqi xfknXBsZHdsvvrQNpnSN0Hhsbw== X-Google-Smtp-Source: AIpwx4/4tzBoAo4dlLkA4Ni1qb/PfLcI7bPW6AbD8w2vnaMXFuJYiXa4i6dl0add29o2XUu60Rd5eg== X-Received: by 2002:adf:e985:: with SMTP id h5-v6mr13830024wrm.137.1524484178060; Mon, 23 Apr 2018 04:49:38 -0700 (PDT) Received: from 6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id m4-v6sm11086199wrj.47.2018.04.23.04.49.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 23 Apr 2018 04:49:37 -0700 (PDT) Date: Mon, 23 Apr 2018 13:49:23 +0200 From: Adrien Mazarguil To: Shahaf Shuler Cc: Declan Doherty , "dev@dpdk.org" , Alex Rosenbaum , Ferruh Yigit , Thomas Monjalon , Qi Zhang , Alejandro Lucero , Andrew Rybchenko , Mohammad Abdul Awal , Remy Horton , John McNamara , Rony Efraim , Jingjing Wu , Wenzhuo Lu , Vincent Jardin , Yuanhan Liu , Bruce Richardson , Konstantin Ananyev , Zhihong Wang Message-ID: <20180423114923.GO4957@6wind.com> References: <1523017443-12414-1-git-send-email-declan.doherty@intel.com> <20180418210423.13847-1-declan.doherty@intel.com> <20180418210423.13847-5-declan.doherty@intel.com> <20180419130333.GB4957@6wind.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [dpdk-dev] [PATCH v4 4/6] ethdev: add mark flow item to flow item types X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Apr 2018 11:49:38 -0000 On Mon, Apr 23, 2018 at 11:10:11AM +0000, Shahaf Shuler wrote: > Thursday, April 19, 2018 4:04 PM, Adrien Mazarguil: > > > > Subject: Re: [dpdk-dev] [PATCH v4 4/6] ethdev: add mark flow item to flow > > item types > > > > On Wed, Apr 18, 2018 at 10:04:21PM +0100, Declan Doherty wrote: > > > Introduces a new action type RTE_FLOW_ITEM_TYPE_MARK which enables > > > flow patterns to specify arbitrary integer values to match aginst > > > > Typo on "aginst". > > > > > which are set by the RTE_FLOW_ACTION_TYPE_MARK action in a > > previously > > > matched flow from a higher prioriry group. > > > > prioriry => priority, however this last addition is unnecessary, it could be any > > prior flow rule that happens to use PASSTHRU. > > > > > > > > Signed-off-by: Declan Doherty > > > --- > > > doc/guides/prog_guide/rte_flow.rst | 28 > > ++++++++++++++++++++++++++++ > > > lib/librte_ether/rte_flow.h | 24 ++++++++++++++++++++++++ > > > 2 files changed, 52 insertions(+) > > > > > > diff --git a/doc/guides/prog_guide/rte_flow.rst > > > b/doc/guides/prog_guide/rte_flow.rst > > > index 325010544..6f23ad909 100644 > > > --- a/doc/guides/prog_guide/rte_flow.rst > > > +++ b/doc/guides/prog_guide/rte_flow.rst > > > @@ -598,6 +598,34 @@ associated with a port_id should be retrieved by > > other means. > > > | ``mask`` | ``index`` | zeroed to match any port index | > > > +----------+-----------+--------------------------------+ > > > > > > +Item: ``MARK`` > > > +^^^^^^^^^^^^^^ > > > + > > > +Matches packets coming from a previously matched flow in a higher > > > +priority group > > > > See above re "higher priority group". > > > > > +with an arbitrary integer value which was set using the ``MARK`` > > > +action in the previously matched rule. > > > + > > Why we have to bind It with the MARK? It is HW limitation or design consideration? > > My understanding is you want flow action of setting metadata to be used later as a matching item for the flows on other group. > It doesn't have to, but can be, bounded with the specific mark the application wants to receive. Yes, no problem with that, I was only commenting the wording of the description. It reads like it'll only work if a prior MARK action found in a *different* group set a mark to match. My point was that it could also be a prior rule in the same group. It could even be added by the device by some other means. -- Adrien Mazarguil 6WIND