From: Sunil Kumar Kori <sunil.kori@nxp.com>
To: <dev@dpdk.org>
Cc: <sunil.kori@nxp.com>, <hemant.agrawal@nxp.com>, <shreyansh.jain@nxp.com>
Subject: [dpdk-dev] [PATCH v2 1/2] net/dpaa: non supported offloads are ignored with warning
Date: Mon, 23 Apr 2018 18:03:36 +0530 [thread overview]
Message-ID: <20180423123337.5653-2-sunil.kori@nxp.com> (raw)
In-Reply-To: <20180423123337.5653-1-sunil.kori@nxp.com>
Fixes: 16e2c27f4fc7 ("net/dpaa: support new ethdev offload APIs")
Cc: shreyansh.jain@nxp.com
Signed-off-by: Sunil Kumar Kori <sunil.kori@nxp.com>
---
drivers/net/dpaa/dpaa_ethdev.c | 34 +++++++++++++++++++++++++++-------
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c
index b2740b4..81001cb 100644
--- a/drivers/net/dpaa/dpaa_ethdev.c
+++ b/drivers/net/dpaa/dpaa_ethdev.c
@@ -45,6 +45,25 @@
#include <fsl_bman.h>
#include <fsl_fman.h>
+/* Non-Supported Rx offloads */
+static uint64_t dev_rx_offloads_not_supported =
+ DEV_RX_OFFLOAD_TCP_LRO |
+ DEV_RX_OFFLOAD_MACSEC_STRIP |
+ DEV_RX_OFFLOAD_HEADER_SPLIT |
+ DEV_RX_OFFLOAD_VLAN_EXTEND |
+ DEV_RX_OFFLOAD_SECURITY;
+
+/* Non-Supported Tx offloads */
+static uint64_t dev_tx_offloads_not_supported =
+ DEV_TX_OFFLOAD_TCP_TSO |
+ DEV_TX_OFFLOAD_UDP_TSO |
+ DEV_TX_OFFLOAD_VXLAN_TNL_TSO |
+ DEV_TX_OFFLOAD_GRE_TNL_TSO |
+ DEV_TX_OFFLOAD_IPIP_TNL_TSO |
+ DEV_TX_OFFLOAD_GENEVE_TNL_TSO |
+ DEV_TX_OFFLOAD_MACSEC_INSERT |
+ DEV_TX_OFFLOAD_SECURITY;
+
/* Keep track of whether QMAN and BMAN have been globally initialized */
static int is_global_init;
/* At present we only allow up to 4 push mode queues - as each of this queue
@@ -150,16 +169,17 @@ dpaa_eth_dev_configure(struct rte_eth_dev *dev)
PMD_INIT_FUNC_TRACE();
dpaa_eth_dev_info(dev, &dev_info);
- if (((~(dev_info.rx_offload_capa) & rx_offloads) != 0)) {
- DPAA_PMD_ERR("Some Rx offloads are not supported "
- "requested 0x%" PRIx64 " supported 0x%" PRIx64,
+ /* Rx offloads validation */
+ if (dev_rx_offloads_not_supported & rx_offloads) {
+ DPAA_PMD_ERR(
+ "Rx offloads not supported - Requested 0x%" PRIx64 " supported 0x%" PRIx64,
rx_offloads, dev_info.rx_offload_capa);
return -ENOTSUP;
}
-
- if (((~(dev_info.tx_offload_capa) & tx_offloads) != 0)) {
- DPAA_PMD_ERR("Some Tx offloads are not supported "
- "requested 0x%" PRIx64 " supported 0x%" PRIx64,
+ /* Tx offloads validation */
+ if (dev_tx_offloads_not_supported & tx_offloads) {
+ DPAA_PMD_ERR(
+ "Tx offloads not supported - Requested 0x%" PRIx64 " Supported 0x%" PRIx64,
tx_offloads, dev_info.tx_offload_capa);
return -ENOTSUP;
}
--
2.9.3
next prev parent reply other threads:[~2018-04-23 12:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 10:45 [dpdk-dev] [PATCH 0/2] Non-supported offloads are ignored Sunil Kumar Kori
2018-04-20 10:45 ` [dpdk-dev] [PATCH 1/2] net/dpaa: non supported offloads are ignored with warning Sunil Kumar Kori
2018-04-20 15:20 ` Stephen Hemminger
2018-04-20 10:45 ` [dpdk-dev] [PATCH 2/2] net/dpaa2: " Sunil Kumar Kori
2018-04-20 12:27 ` [dpdk-dev] [PATCH 0/2] Non-supported offloads are ignored Ferruh Yigit
2018-04-23 12:33 ` [dpdk-dev] [PATCH v2 " Sunil Kumar Kori
2018-04-23 12:33 ` Sunil Kumar Kori [this message]
2018-04-23 14:57 ` [dpdk-dev] [PATCH v2 1/2] net/dpaa: non supported offloads are ignored with warning Ferruh Yigit
2018-04-23 12:33 ` [dpdk-dev] [PATCH v2 2/2] net/dpaa2: " Sunil Kumar Kori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180423123337.5653-2-sunil.kori@nxp.com \
--to=sunil.kori@nxp.com \
--cc=dev@dpdk.org \
--cc=hemant.agrawal@nxp.com \
--cc=shreyansh.jain@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).