From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f65.google.com (mail-pg0-f65.google.com [74.125.83.65]) by dpdk.org (Postfix) with ESMTP id B631E4F90 for ; Tue, 24 Apr 2018 17:00:36 +0200 (CEST) Received: by mail-pg0-f65.google.com with SMTP id 82so1230181pge.11 for ; Tue, 24 Apr 2018 08:00:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hhYvpbUkcsfWHJgoSsGkAZVmdHMEggKGG/rTwfG99Xc=; b=Ux5u770lSML8zkgjVjrU5r8wn1j1BTa7UODqRtm/WNY1KuwPSasD/kciQcHYsVrtWo JmdNn9AWWaHQjbS+fZEMMc5jsOx10lDr/YTGCriD2MhH7bvFIDszTa+onb/bNz8pjX8A YOXssj4Jv5HQeNt9cpQiMc7c4kvLTMTdxj9l68RgC+dRoOm2l9V/HaUWoAdMq8mWOegq RtQeMKmZB+7jNSK0OFajtAosENemDZaKqaK3O/1hdvhU9/4w23p0wtErgDPCYRgvgRsQ WQ5+Nis+RKNyX9p0pvucz3+12wnwciBHvfVKdMesylVkdcadVxHmqcy6d/GuyVx6eiS0 Qp8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hhYvpbUkcsfWHJgoSsGkAZVmdHMEggKGG/rTwfG99Xc=; b=DC82HH3f4GVmk7LTg7B0wYLNzn+ojtSxEOyXksr8/sGihXX0LLoi6LGHiNrKQxvYpv WIfcdD955VdoemPVf8LirOuvSDmypH4ag+zWuEG80fvjExONHn2I7xpMWXepUWOZ2oKq DJHjpVUL2vXQ3Rz/DVy6pFIPHkKPurZVSRFnzL31rHrnDc50gx9YPAmsPzdar/sW09ke BlkTCbFZG6kjQIStsyhtZ6EZczc3UdSMyUCahkTYGFV1My1CmpT1y+ad9faIEbN851hn aH0WURXnE7z/DurE2ycQFbQ2oG0XU97q1X44RGJ/hjeBoNr3gw/NkTcwF8nsd3dsXGAr Im9Q== X-Gm-Message-State: ALQs6tBQ7peoY/6nVbb7eRzWsq7UGMF5RG7GOSb5JRW/YmuoEJedSzQT FyE7Nw5qMIe1z1ZqWxiWWNUywA== X-Google-Smtp-Source: AIpwx49uiec3WYoeVTEArv3ghUeqVqlu/GQSB84QV6o9imgmM6/MfUVNhKBiOB1tRLfWzy7CDdjZqw== X-Received: by 10.99.117.12 with SMTP id q12mr19945296pgc.395.1524582035459; Tue, 24 Apr 2018 08:00:35 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id s2sm28906940pfb.66.2018.04.24.08.00.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 08:00:35 -0700 (PDT) Date: Tue, 24 Apr 2018 08:00:32 -0700 From: Stephen Hemminger To: Arnon Warshavsky Cc: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180424080032.161d08b9@xeon-e3> In-Reply-To: <1524552123-31378-2-git-send-email-arnon@qwilt.com> References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <1524552123-31378-2-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 15:00:37 -0000 On Tue, 24 Apr 2018 09:41:53 +0300 Arnon Warshavsky wrote: > + if (cryptodev->data->dev_private == NULL) { > + RTE_LOG(ERR, PMD, "%s() Cannot allocate memzone for private device data", > + __func__); dpaa2_sec is already doing private log type, via DPAA2_SEC_LOG macro. You should go through your patch and make sure there are as few direct calls to RTE_LOG as possible.