From: Stephen Hemminger <stephen@networkplumber.org>
To: Arnon Warshavsky <arnon@qwilt.com>
Cc: thomas@monjalon.net, anatoly.burakov@intel.com,
wenzhuo.lu@intel.com, declan.doherty@intel.com,
jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com,
ferruh.yigit@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v6 05/11] eal: replace rte_panic instances in eventdev
Date: Tue, 24 Apr 2018 08:04:49 -0700 [thread overview]
Message-ID: <20180424080449.0478c7b4@xeon-e3> (raw)
In-Reply-To: <1524552123-31378-6-git-send-email-arnon@qwilt.com>
On Tue, 24 Apr 2018 09:41:57 +0300
Arnon Warshavsky <arnon@qwilt.com> wrote:
> diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> index 8fb6138..6e08705 100644
> --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
> @@ -66,9 +66,11 @@
> RTE_CACHE_LINE_SIZE,
> rte_socket_id());
>
> - if (eventdev->data->dev_private == NULL)
> - rte_panic("Cannot allocate memzone for private "
> - "device data");
> + if (eventdev->data->dev_private == NULL) {
> + RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone for private device data",
> + __func__);
> + return -ENOMEM;
> + }
>
Off topic, why is the probe function inline in a .h file.
This is wasteful, and not at all performance critical. it should be in the .c file.
next prev parent reply other threads:[~2018-04-24 15:04 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 6:41 [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 01/11] crypto/dpaa: replace rte_panic instances in crypto/dpaa driver Arnon Warshavsky
2018-04-24 15:00 ` Stephen Hemminger
2018-04-24 19:27 ` Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 02/11] bond: replace rte_panic instances in bonding driver Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 03/11] e1000: replace rte_panic instances in e1000 driver Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 04/11] ixgbe: replace rte_panic instances in ixgbe driver Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 05/11] eal: replace rte_panic instances in eventdev Arnon Warshavsky
2018-04-24 15:04 ` Stephen Hemminger [this message]
2018-04-24 15:06 ` Stephen Hemminger
2018-04-24 19:28 ` Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 06/11] kni: replace rte_panic instances in kni Arnon Warshavsky
2018-04-24 6:41 ` [dpdk-dev] [PATCH v6 07/11] eal: replace rte_panic instances in hugepage_info Arnon Warshavsky
2018-04-24 6:42 ` [dpdk-dev] [PATCH v6 08/11] eal: replace rte_panic instances in interrupts thread Arnon Warshavsky
2018-04-24 6:42 ` [dpdk-dev] [PATCH v6 09/11] eal: replace rte_panic instances in ethdev Arnon Warshavsky
2018-04-24 6:42 ` [dpdk-dev] [PATCH v6 10/11] eal: replace rte_panic instances in init sequence Arnon Warshavsky
2018-04-24 6:42 ` [dpdk-dev] [PATCH v6 11/11] devtools: prevent new instances of rte_panic and rte_exit Arnon Warshavsky
2018-04-24 6:44 ` [dpdk-dev] [PATCH v6 00/11] al: replace calls to rte_panic and refrain from new instances Arnon Warshavsky
2018-04-24 6:57 ` Arnon Warshavsky
2019-04-18 14:50 ` Thomas Monjalon
2019-04-18 14:50 ` Thomas Monjalon
2019-04-21 19:16 ` Arnon Warshavsky
2019-04-21 19:16 ` Arnon Warshavsky
2019-04-21 21:10 ` Thomas Monjalon
2019-04-21 21:10 ` Thomas Monjalon
2019-05-08 11:15 ` Thomas Monjalon
2019-05-08 11:15 ` Thomas Monjalon
2019-05-08 14:47 ` David Marchand
2019-05-08 14:47 ` David Marchand
2019-05-09 12:05 ` Burakov, Anatoly
2019-05-09 12:05 ` Burakov, Anatoly
2019-05-09 13:16 ` Thomas Monjalon
2019-05-09 13:16 ` Thomas Monjalon
2019-05-23 11:14 ` Thomas Monjalon
2019-05-23 13:13 ` Arnon Warshavsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424080449.0478c7b4@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=anatoly.burakov@intel.com \
--cc=arnon@qwilt.com \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerin.jacob@caviumnetworks.com \
--cc=thomas@monjalon.net \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).