From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f67.google.com (mail-pg0-f67.google.com [74.125.83.67]) by dpdk.org (Postfix) with ESMTP id 14ED94F93 for ; Tue, 24 Apr 2018 17:04:52 +0200 (CEST) Received: by mail-pg0-f67.google.com with SMTP id p10so11085059pgn.1 for ; Tue, 24 Apr 2018 08:04:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=a5U1ZzL7G+rSlw77BlWhtaSpEIDz2SIss8ykkUj8r74=; b=IjfcYRRWQPqlcmsTuZtb8PbMO2hURFIbh7o9xDcNXcDa4OdXYZyzBnFetmhCXp9BuV /vP0EJQJI0C5y+PjacO/EoihGpvC581nL3KzGdnRVNQs8swc0ACNMWmycZsyS5OXaMCp B+RQNp8ZS0Eiklj5K82QmHFxeSvgAoOEq1/Xzx9AAyuNTDuS0HZwiYCGfOQdvEzS9g1U TTd68x1rXOrBEYyU6k61AM2iqD0lz8aQy/pWCe67cuxcQtbaTJHw9o/uY71UPO72mQgG pCO1CWTY1p0QaY3/FimWPtrl3zQYOUD2EjvzTiJtQuwuraRSV/ewviq1AHvoK8FXUerj Vd0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=a5U1ZzL7G+rSlw77BlWhtaSpEIDz2SIss8ykkUj8r74=; b=CduAHDZiaebE95yoiOZ8ahZgVjuyNXHJLpQoMmVkSnE2qjWNSXsdocl6asPRf+N34O rfP4i7mVcLBVDLlmRcoNwyrwhc1zjX0H9vMwoK+w0M/fqJVUgs3GD8fczmJgQ18Fdojj F/ap4orkctMMUIDOBCxdUEmk5DT/yzOhvB1mZJvbGKPY+tk6I8f55oaVwHlJIAdiqCOR N15yrQltEf7VwYd31tyMPwRpjtQtIiQW9u0XH2TRO2x5+/6cP8THIuvo2CYDSgggymMI qoWZmfphbffOnQfRyU7kgDPXDHll6pRa0qw0LnBG1jZ2ginOU831mHciCnnHhKIbt75j 5hLA== X-Gm-Message-State: ALQs6tBHDZmIBexF/etUy+954RFCivp3AH6gevvyEymsGoQXrOrUxuSM v7NUUv/ngyJGLZJlz8ODEJu7DA== X-Google-Smtp-Source: AB8JxZosjnjFuwWGr37Gxl6IM3UOTqhZW40tRoPAZ100uLmCTKxxblJpqj2/VPx13b7TtM2Qjz7Rag== X-Received: by 2002:a17:902:d882:: with SMTP id b2-v6mr1627648plz.381.1524582291866; Tue, 24 Apr 2018 08:04:51 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id o64sm28252944pfb.62.2018.04.24.08.04.51 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 08:04:51 -0700 (PDT) Date: Tue, 24 Apr 2018 08:04:49 -0700 From: Stephen Hemminger To: Arnon Warshavsky Cc: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180424080449.0478c7b4@xeon-e3> In-Reply-To: <1524552123-31378-6-git-send-email-arnon@qwilt.com> References: <1524552123-31378-1-git-send-email-arnon@qwilt.com> <1524552123-31378-6-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v6 05/11] eal: replace rte_panic instances in eventdev X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 15:04:53 -0000 On Tue, 24 Apr 2018 09:41:57 +0300 Arnon Warshavsky wrote: > diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > index 8fb6138..6e08705 100644 > --- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h > +++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h > @@ -66,9 +66,11 @@ > RTE_CACHE_LINE_SIZE, > rte_socket_id()); > > - if (eventdev->data->dev_private == NULL) > - rte_panic("Cannot allocate memzone for private " > - "device data"); > + if (eventdev->data->dev_private == NULL) { > + RTE_LOG(CRIT, EAL, "%s(): Cannot allocate memzone for private device data", > + __func__); > + return -ENOMEM; > + } > Off topic, why is the probe function inline in a .h file. This is wasteful, and not at all performance critical. it should be in the .c file.