From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 4C206271 for ; Tue, 24 Apr 2018 12:59:08 +0200 (CEST) X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Apr 2018 03:59:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.49,322,1520924400"; d="scan'208";a="193945939" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.51]) by orsmga004.jf.intel.com with SMTP; 24 Apr 2018 03:59:04 -0700 Received: by (sSMTP sendmail emulation); Tue, 24 Apr 2018 11:59:00 +0100 Date: Tue, 24 Apr 2018 11:58:59 +0100 From: Bruce Richardson To: Thomas Monjalon Cc: jananeex.m.parthasarathy@intel.com, dev@dpdk.org, Reshma Pattan , david.hunt@intel.com Message-ID: <20180424105859.GA124204@bricha3-MOBL.ger.corp.intel.com> References: <1523022706-12231-1-git-send-email-reshma.pattan@intel.com> <1523456067-14178-1-git-send-email-reshma.pattan@intel.com> <3442093.nS8Mgo2NPm@xps> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3442093.nS8Mgo2NPm@xps> Organization: Intel Research and Development Ireland Ltd. User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [PATCH v2] app/test: enhance power manager unit tests X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 10:59:08 -0000 On Mon, Apr 23, 2018 at 11:04:27PM +0200, Thomas Monjalon wrote: > 11/04/2018 16:14, Reshma Pattan: > > Unit Testcases are added for power_acpi_cpu_freq, > > power_kvm_vm_test to improve coverage > > > > Signed-off-by: Jananee Parthasarathy > > Acked-by: David Hunt > > Applied, thanks > Sadly, this patch seems to break shared library builds. If you try doing "make test-build" with shared libraries on it will fail, or if you do a meson build using shared libraries you will get the same result. The root cause is that the function guest_channel_host_connect() is a private function and so is not listed in the shared library map file, preventing the test app from linking. Regards, /Bruce