From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f196.google.com (mail-pf0-f196.google.com [209.85.192.196]) by dpdk.org (Postfix) with ESMTP id 5D6504C95 for ; Wed, 25 Apr 2018 00:51:49 +0200 (CEST) Received: by mail-pf0-f196.google.com with SMTP id a14so2973687pfi.1 for ; Tue, 24 Apr 2018 15:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BwvkPXTn6BwlFBEa99+GPDYxZ2nThWj6v2j5dpwTveE=; b=VCObhjv7J+JWer5ti5R4nOf2viDvmpnqD2d2Xu+fObcQ4w00onvHslIOQe/+5cU+ah UQdyhPCOXTjO6SRg5eJFg1XnGPL4r/QALvWjk95aq2Z2TtumHojaFyb/SvQTKmmbelQi WmbcrOkbMGHWucxrUlhAoYJrQY7TKLYRl05RwXEiUlqJwNwhb8TDSyF41C++yMJ9DYf3 2lNtCMLyeebrSMM54rI4sbmCok0ubbwwR1jfrARTlLLS+JrznY6vba26RS58bbH9/mcs AUtvO0h888ta7xEK5rYt6Pmv0q6VdVihjbaoHj+Ig6MwBB5yTIR5oNKTw8XC3E7CfXZ6 CuFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BwvkPXTn6BwlFBEa99+GPDYxZ2nThWj6v2j5dpwTveE=; b=qxMddWBVmjBi4MK+BgidGPkh8oGN1ADrFH+oewKKsRczma1swyiMkgEbZJ2bFRHEwL HO5qQtEX5Kd84P1nWdBdgH7fAr7D20KGXK+TlUx/9Gjh5HRuIq+HwDkxsECnNmUwXJKS 0cteupOjjANUtIvOIHSz9c9IjXRZXYGIekR/G2udkFG54wz8mdfYCZPR0MXR3vR4Cjv/ DwEwSaGjDZPRwPkEBsW62p5tzVuzCb/9DTRWY4oIHOAPkbGqXJwt+Qh/GtS6FLgCIpCm wujJnt85mJpgXSsbKgdqHMOAmzEA9Hpdxu3mMRiSEVEtUAr8W4K2ifMijn3qb3/PVXXe +EKQ== X-Gm-Message-State: ALQs6tCo/Hhzjy5rsJZUKRlu9qa+yElY5qodz6/HTvC27ABCU7Wyzg3k sBA+GBdEG9ph3dC3cYSSDhgSVw== X-Google-Smtp-Source: AIpwx4+ZT6PWyQSbyeMFnTEK/gvvWmd10HBs8ACQuWRPL6jULGbZ+BEDWI2tW04hJji5jJN1FQ6NiA== X-Received: by 10.98.163.145 with SMTP id q17mr25724942pfl.87.1524610308367; Tue, 24 Apr 2018 15:51:48 -0700 (PDT) Received: from xeon-e3 (204-195-71-95.wavecable.com. [204.195.71.95]) by smtp.gmail.com with ESMTPSA id j74sm4980052pfk.25.2018.04.24.15.51.47 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 24 Apr 2018 15:51:48 -0700 (PDT) Date: Tue, 24 Apr 2018 15:51:46 -0700 From: Stephen Hemminger To: Arnon Warshavsky Cc: thomas@monjalon.net, anatoly.burakov@intel.com, wenzhuo.lu@intel.com, declan.doherty@intel.com, jerin.jacob@caviumnetworks.com, bruce.richardson@intel.com, ferruh.yigit@intel.com, dev@dpdk.org Message-ID: <20180424155146.35f5031f@xeon-e3> In-Reply-To: <1524608213-2080-3-git-send-email-arnon@qwilt.com> References: <1524608213-2080-1-git-send-email-arnon@qwilt.com> <1524608213-2080-3-git-send-email-arnon@qwilt.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v7 02/11] bond: replace rte_panic instances in bonding driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Apr 2018 22:51:49 -0000 On Wed, 25 Apr 2018 01:16:44 +0300 Arnon Warshavsky wrote: > replace panic calls with log and return value. > Local functions to this file, > changing from void to int are non-abi-breaking > > Signed-off-by: Arnon Warshavsky > --- > drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c | 2 +- > drivers/net/bonding/rte_eth_bond_8023ad.c | 29 ++++++++++++++--------- > drivers/net/bonding/rte_eth_bond_8023ad_private.h | 2 +- > drivers/net/bonding/rte_eth_bond_api.c | 22 ++++++++++++----- > drivers/net/bonding/rte_eth_bond_pmd.c | 9 ++++--- > drivers/net/bonding/rte_eth_bond_private.h | 2 +- > 6 files changed, 43 insertions(+), 23 deletions(-) > > diff --git a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > index a78f3a2..a19fb40 100644 > --- a/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > +++ b/drivers/crypto/dpaa2_sec/dpaa2_sec_dpseci.c > @@ -2884,7 +2884,7 @@ struct rte_security_ops dpaa2_sec_security_ops = { > rte_socket_id()); > > if (cryptodev->data->dev_private == NULL) { > - DPAA_SEC_ERR("%s() Cannot allocate memzone for private device data", > + DPAA2_SEC_ERR("%s() Cannot allocate memzone for private device data", > __func__); > return -ENOMEM; You mixed dpaa2 with bonding in this set.